Improve example AbslUnparseFlag().

1. Move default case outside switch. This is a good practice because it allows -Wswitch to warn about missing enum values. 2. Use absl::StrCat() instead of (nonexistent) SimpleItoa().

Improve example AbslUnparseFlag().
1. Move default case outside switch. This is a good practice because it allows -Wswitch to warn about missing enum values. 2. Use absl::StrCat() instead of (nonexistent) SimpleItoa().
23dc7595 · Michael Shields · GitHub · 43ef2148 · 23dc7595
Commit 23dc7595 authored Jun 20, 2019 by Michael Shields Committed by GitHub Jun 20, 2019
Show whitespace changes
Inline Side-by-side

Showing with 1 additions and 1 deletions

absl/flags/marshalling.h
+1 -1

No files found.
--- a/absl/flags/marshalling.h
+++ b/absl/flags/marshalling.h
@@ -108,8 +108,8 @@
 //    switch (mode) {
 //      case kPlainText: return "plaintext";
 //      case kHtml: return "html";
-//     default: return SimpleItoa(mode);
 //    }
+//    return absl::SimpleItoa(mode);
 //  }
 //
 // Notice that neither `AbslParseFlag()` nor `AbslUnparseFlag()` are class