Skip to content

A
abseil-cpp
Commit 56f5477f by Dino Radakovic Committed by Copybara-Service
Options

any_invocable_test: Re-enable the two conversion tests that used to fail under MSVC 

PiperOrigin-RevId: 461238101
Change-Id: Id3edac104ecd9edd9daf8012894a62692bd9569f
parent b707b6c1
Showing with 0 additions and 6 deletions
absl/functional/any_invocable_test.cc
...@@ -1246,12 +1246,9 @@ TYPED_TEST_P(AnyInvTestNoexceptTrue, ConversionConstructionConstraints) { ...@@ -1246,12 +1246,9 @@ TYPED_TEST_P(AnyInvTestNoexceptTrue, ConversionConstructionConstraints) {
#else #else
using AnyInvType = typename TypeParam::AnyInvType; using AnyInvType = typename TypeParam::AnyInvType;
// TODO(b/217761454): Fix this and re-enable for MSVC.
#ifndef _MSC_VER
EXPECT_FALSE((std::is_constructible< EXPECT_FALSE((std::is_constructible<
AnyInvType, AnyInvType,
typename TypeParam::AnyInvocableFunTypeNotNoexcept*>::value)); typename TypeParam::AnyInvocableFunTypeNotNoexcept*>::value));
#endif
EXPECT_FALSE(( EXPECT_FALSE((
std::is_constructible<AnyInvType, std::is_constructible<AnyInvType,
typename TypeParam::IncompatibleInvocable>::value)); typename TypeParam::IncompatibleInvocable>::value));
...@@ -1264,12 +1261,9 @@ TYPED_TEST_P(AnyInvTestNoexceptTrue, ConversionAssignConstraints) { ...@@ -1264,12 +1261,9 @@ TYPED_TEST_P(AnyInvTestNoexceptTrue, ConversionAssignConstraints) {
#else #else
using AnyInvType = typename TypeParam::AnyInvType; using AnyInvType = typename TypeParam::AnyInvType;
// TODO(b/217761454): Fix this and re-enable for MSVC.
#ifndef _MSC_VER
EXPECT_FALSE((std::is_assignable< EXPECT_FALSE((std::is_assignable<
AnyInvType&, AnyInvType&,
typename TypeParam::AnyInvocableFunTypeNotNoexcept*>::value)); typename TypeParam::AnyInvocableFunTypeNotNoexcept*>::value));
#endif
EXPECT_FALSE( EXPECT_FALSE(
(std::is_assignable<AnyInvType&, (std::is_assignable<AnyInvType&,
typename TypeParam::IncompatibleInvocable>::value)); typename TypeParam::IncompatibleInvocable>::value));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment