Commit 761f04dc by Abseil Team Committed by Copybara-Service

Improve readability of ::testing::ElementsAre and ::testing::Le in unit tests assertions.

PiperOrigin-RevId: 515396682
Change-Id: I1b07d94611323569b199e1f4d03c7c49147c6bfb
parent 5df3ac3b
...@@ -58,6 +58,8 @@ using absl::cord_internal::CordRepSubstring; ...@@ -58,6 +58,8 @@ using absl::cord_internal::CordRepSubstring;
using absl::cord_internal::CordzUpdateTracker; using absl::cord_internal::CordzUpdateTracker;
using absl::cord_internal::kFlatOverhead; using absl::cord_internal::kFlatOverhead;
using absl::cord_internal::kMaxFlatLength; using absl::cord_internal::kMaxFlatLength;
using ::testing::ElementsAre;
using ::testing::Le;
static std::string RandomLowercaseString(RandomEngine* rng); static std::string RandomLowercaseString(RandomEngine* rng);
static std::string RandomLowercaseString(RandomEngine* rng, size_t length); static std::string RandomLowercaseString(RandomEngine* rng, size_t length);
...@@ -618,7 +620,7 @@ TEST_P(CordTest, AppendEmptyBufferToTree) { ...@@ -618,7 +620,7 @@ TEST_P(CordTest, AppendEmptyBufferToTree) {
TEST_P(CordTest, AppendSmallBuffer) { TEST_P(CordTest, AppendSmallBuffer) {
absl::Cord cord; absl::Cord cord;
absl::CordBuffer buffer = absl::CordBuffer::CreateWithDefaultLimit(3); absl::CordBuffer buffer = absl::CordBuffer::CreateWithDefaultLimit(3);
ASSERT_THAT(buffer.capacity(), ::testing::Le(15)); ASSERT_THAT(buffer.capacity(), Le(15));
memcpy(buffer.data(), "Abc", 3); memcpy(buffer.data(), "Abc", 3);
buffer.SetLength(3); buffer.SetLength(3);
cord.Append(std::move(buffer)); cord.Append(std::move(buffer));
...@@ -632,7 +634,7 @@ TEST_P(CordTest, AppendSmallBuffer) { ...@@ -632,7 +634,7 @@ TEST_P(CordTest, AppendSmallBuffer) {
EXPECT_EQ(buffer.length(), 0); // NOLINT EXPECT_EQ(buffer.length(), 0); // NOLINT
EXPECT_GT(buffer.capacity(), 0); // NOLINT EXPECT_GT(buffer.capacity(), 0); // NOLINT
EXPECT_THAT(cord.Chunks(), ::testing::ElementsAre("Abcdefgh")); EXPECT_THAT(cord.Chunks(), ElementsAre("Abcdefgh"));
} }
TEST_P(CordTest, AppendAndPrependBufferArePrecise) { TEST_P(CordTest, AppendAndPrependBufferArePrecise) {
...@@ -671,7 +673,7 @@ TEST_P(CordTest, AppendAndPrependBufferArePrecise) { ...@@ -671,7 +673,7 @@ TEST_P(CordTest, AppendAndPrependBufferArePrecise) {
TEST_P(CordTest, PrependSmallBuffer) { TEST_P(CordTest, PrependSmallBuffer) {
absl::Cord cord; absl::Cord cord;
absl::CordBuffer buffer = absl::CordBuffer::CreateWithDefaultLimit(3); absl::CordBuffer buffer = absl::CordBuffer::CreateWithDefaultLimit(3);
ASSERT_THAT(buffer.capacity(), ::testing::Le(15)); ASSERT_THAT(buffer.capacity(), Le(15));
memcpy(buffer.data(), "Abc", 3); memcpy(buffer.data(), "Abc", 3);
buffer.SetLength(3); buffer.SetLength(3);
cord.Prepend(std::move(buffer)); cord.Prepend(std::move(buffer));
...@@ -685,7 +687,7 @@ TEST_P(CordTest, PrependSmallBuffer) { ...@@ -685,7 +687,7 @@ TEST_P(CordTest, PrependSmallBuffer) {
EXPECT_EQ(buffer.length(), 0); // NOLINT EXPECT_EQ(buffer.length(), 0); // NOLINT
EXPECT_GT(buffer.capacity(), 0); // NOLINT EXPECT_GT(buffer.capacity(), 0); // NOLINT
EXPECT_THAT(cord.Chunks(), ::testing::ElementsAre("defghAbc")); EXPECT_THAT(cord.Chunks(), ElementsAre("defghAbc"));
} }
TEST_P(CordTest, AppendLargeBuffer) { TEST_P(CordTest, AppendLargeBuffer) {
...@@ -707,7 +709,7 @@ TEST_P(CordTest, AppendLargeBuffer) { ...@@ -707,7 +709,7 @@ TEST_P(CordTest, AppendLargeBuffer) {
EXPECT_EQ(buffer.length(), 0); // NOLINT EXPECT_EQ(buffer.length(), 0); // NOLINT
EXPECT_GT(buffer.capacity(), 0); // NOLINT EXPECT_GT(buffer.capacity(), 0); // NOLINT
EXPECT_THAT(cord.Chunks(), ::testing::ElementsAre(s1, s2)); EXPECT_THAT(cord.Chunks(), ElementsAre(s1, s2));
} }
TEST_P(CordTest, PrependLargeBuffer) { TEST_P(CordTest, PrependLargeBuffer) {
...@@ -729,7 +731,7 @@ TEST_P(CordTest, PrependLargeBuffer) { ...@@ -729,7 +731,7 @@ TEST_P(CordTest, PrependLargeBuffer) {
EXPECT_EQ(buffer.length(), 0); // NOLINT EXPECT_EQ(buffer.length(), 0); // NOLINT
EXPECT_GT(buffer.capacity(), 0); // NOLINT EXPECT_GT(buffer.capacity(), 0); // NOLINT
EXPECT_THAT(cord.Chunks(), ::testing::ElementsAre(s2, s1)); EXPECT_THAT(cord.Chunks(), ElementsAre(s2, s1));
} }
class CordAppendBufferTest : public testing::TestWithParam<bool> { class CordAppendBufferTest : public testing::TestWithParam<bool> {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment