Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
A
abseil-cpp
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
open
abseil-cpp
Commits
bf2bf60a
Unverified
Commit
bf2bf60a
authored
Oct 04, 2022
by
Randolf J
Committed by
GitHub
Oct 04, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update charconv.cc
parent
71aa5dda
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
7 deletions
+6
-7
absl/strings/charconv.cc
+6
-7
No files found.
absl/strings/charconv.cc
View file @
bf2bf60a
...
@@ -334,24 +334,23 @@ template <typename FloatType>
...
@@ -334,24 +334,23 @@ template <typename FloatType>
bool
HandleEdgeCase
(
const
strings_internal
::
ParsedFloat
&
input
,
bool
negative
,
bool
HandleEdgeCase
(
const
strings_internal
::
ParsedFloat
&
input
,
bool
negative
,
FloatType
*
value
)
{
FloatType
*
value
)
{
if
(
input
.
type
==
strings_internal
::
FloatType
::
kNan
)
{
if
(
input
.
type
==
strings_internal
::
FloatType
::
kNan
)
{
// A bug in
both clang and gcc would cause the compiler to optimize away the
// A bug in
gcc would cause the compiler to optimize away the buffer
//
buffer
we are building below. Declaring the buffer volatile avoids the
// we are building below. Declaring the buffer volatile avoids the
// issue, and has no measurable performance impact in microbenchmarks.
// issue, and has no measurable performance impact in microbenchmarks.
//
//
// https://bugs.llvm.org/show_bug.cgi?id=37778
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86113
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86113
constexpr
ptrdiff_t
kNanBufferSize
=
128
;
constexpr
ptrdiff_t
kNanBufferSize
=
128
;
#ifdef __GNUC__
volatile
char
n_char_sequence
[
kNanBufferSize
];
volatile
char
n_char_sequence
[
kNanBufferSize
];
#else
char
n_char_sequence
[
kNanBufferSize
];
#endif
if
(
input
.
subrange_begin
==
nullptr
)
{
if
(
input
.
subrange_begin
==
nullptr
)
{
n_char_sequence
[
0
]
=
'\0'
;
n_char_sequence
[
0
]
=
'\0'
;
}
else
{
}
else
{
ptrdiff_t
nan_size
=
input
.
subrange_end
-
input
.
subrange_begin
;
ptrdiff_t
nan_size
=
input
.
subrange_end
-
input
.
subrange_begin
;
nan_size
=
std
::
min
(
nan_size
,
kNanBufferSize
-
1
);
nan_size
=
std
::
min
(
nan_size
,
kNanBufferSize
-
1
);
#ifdef __GNUC__
std
::
copy_n
(
input
.
subrange_begin
,
nan_size
,
n_char_sequence
);
std
::
copy_n
(
input
.
subrange_begin
,
nan_size
,
n_char_sequence
);
#else
std
::
copy_n
(
input
.
subrange_begin
,
nan_size
,
const_cast
<
char
*>
(
n_char_sequence
));
#endif
n_char_sequence
[
nan_size
]
=
'\0'
;
n_char_sequence
[
nan_size
]
=
'\0'
;
}
}
char
*
nan_argument
=
const_cast
<
char
*>
(
n_char_sequence
);
char
*
nan_argument
=
const_cast
<
char
*>
(
n_char_sequence
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment