Commit e9787e7d by Derek Mauro Committed by Copybara-Service

Add some missing copts and linkopts in logging and fix the warnings

PiperOrigin-RevId: 493617276
Change-Id: Ia7fb938c7abfba10e5b62f43f3cf71fb99b132f5
parent 5736d76a
...@@ -344,6 +344,8 @@ cc_library( ...@@ -344,6 +344,8 @@ cc_library(
name = "proto", name = "proto",
srcs = ["proto.cc"], srcs = ["proto.cc"],
hdrs = ["proto.h"], hdrs = ["proto.h"],
copts = ABSL_DEFAULT_COPTS,
linkopts = ABSL_DEFAULT_LINKOPTS,
deps = [ deps = [
"//absl/base", "//absl/base",
"//absl/base:config", "//absl/base:config",
......
...@@ -29,7 +29,7 @@ namespace log_internal { ...@@ -29,7 +29,7 @@ namespace log_internal {
namespace { namespace {
void EncodeRawVarint(uint64_t value, size_t size, absl::Span<char> *buf) { void EncodeRawVarint(uint64_t value, size_t size, absl::Span<char> *buf) {
for (size_t s = 0; s < size; s++) { for (size_t s = 0; s < size; s++) {
(*buf)[s] = (value & 0x7f) | (s + 1 == size ? 0 : 0x80); (*buf)[s] = static_cast<char>((value & 0x7f) | (s + 1 == size ? 0 : 0x80));
value >>= 7; value >>= 7;
} }
buf->remove_prefix(size); buf->remove_prefix(size);
...@@ -61,7 +61,7 @@ bool Encode64Bit(uint64_t tag, uint64_t value, absl::Span<char> *buf) { ...@@ -61,7 +61,7 @@ bool Encode64Bit(uint64_t tag, uint64_t value, absl::Span<char> *buf) {
} }
EncodeRawVarint(tag_type, tag_type_size, buf); EncodeRawVarint(tag_type, tag_type_size, buf);
for (size_t s = 0; s < sizeof(value); s++) { for (size_t s = 0; s < sizeof(value); s++) {
(*buf)[s] = value & 0xff; (*buf)[s] = static_cast<char>(value & 0xff);
value >>= 8; value >>= 8;
} }
buf->remove_prefix(sizeof(value)); buf->remove_prefix(sizeof(value));
...@@ -77,7 +77,7 @@ bool Encode32Bit(uint64_t tag, uint32_t value, absl::Span<char> *buf) { ...@@ -77,7 +77,7 @@ bool Encode32Bit(uint64_t tag, uint32_t value, absl::Span<char> *buf) {
} }
EncodeRawVarint(tag_type, tag_type_size, buf); EncodeRawVarint(tag_type, tag_type_size, buf);
for (size_t s = 0; s < sizeof(value); s++) { for (size_t s = 0; s < sizeof(value); s++) {
(*buf)[s] = value & 0xff; (*buf)[s] = static_cast<char>(value & 0xff);
value >>= 8; value >>= 8;
} }
buf->remove_prefix(sizeof(value)); buf->remove_prefix(sizeof(value));
...@@ -143,8 +143,9 @@ ABSL_MUST_USE_RESULT absl::Span<char> EncodeMessageStart( ...@@ -143,8 +143,9 @@ ABSL_MUST_USE_RESULT absl::Span<char> EncodeMessageStart(
void EncodeMessageLength(absl::Span<char> msg, const absl::Span<char> *buf) { void EncodeMessageLength(absl::Span<char> msg, const absl::Span<char> *buf) {
if (!msg.data()) return; if (!msg.data()) return;
const uint64_t length_size = msg.size(); const size_t length_size = msg.size();
EncodeRawVarint(buf->data() - msg.data() - length_size, length_size, &msg); EncodeRawVarint(static_cast<uint64_t>(buf->data() - msg.data()) - length_size,
length_size, &msg);
} }
namespace { namespace {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment