Commit ed7c1ee1 by Evan Brown Committed by Copybara-Service

Fix flakiness issues in timing tests.

PiperOrigin-RevId: 519939158
Change-Id: I9b049fa55167ed4064f3909887eec7bc52601677
parent 6b4af249
...@@ -48,7 +48,7 @@ class WaiterTest : public ::testing::Test { ...@@ -48,7 +48,7 @@ class WaiterTest : public ::testing::Test {
TYPED_TEST_SUITE_P(WaiterTest); TYPED_TEST_SUITE_P(WaiterTest);
constexpr absl::Duration slop = absl::Milliseconds(2); constexpr absl::Duration slop = absl::Milliseconds(10);
TYPED_TEST_P(WaiterTest, WaitNoTimeout) { TYPED_TEST_P(WaiterTest, WaitNoTimeout) {
absl::synchronization_internal::ThreadPool tp(1); absl::synchronization_internal::ThreadPool tp(1);
...@@ -84,7 +84,7 @@ TYPED_TEST_P(WaiterTest, WaitDurationWoken) { ...@@ -84,7 +84,7 @@ TYPED_TEST_P(WaiterTest, WaitDurationWoken) {
absl::synchronization_internal::KernelTimeout(absl::Seconds(10)))); absl::synchronization_internal::KernelTimeout(absl::Seconds(10))));
absl::Duration waited = absl::Now() - start; absl::Duration waited = absl::Now() - start;
EXPECT_GE(waited, absl::Milliseconds(500) - slop); EXPECT_GE(waited, absl::Milliseconds(500) - slop);
EXPECT_LT(waited, absl::Seconds(1)); EXPECT_LT(waited, absl::Seconds(2));
} }
TYPED_TEST_P(WaiterTest, WaitTimeWoken) { TYPED_TEST_P(WaiterTest, WaitTimeWoken) {
...@@ -102,7 +102,7 @@ TYPED_TEST_P(WaiterTest, WaitTimeWoken) { ...@@ -102,7 +102,7 @@ TYPED_TEST_P(WaiterTest, WaitTimeWoken) {
start + absl::Seconds(10)))); start + absl::Seconds(10))));
absl::Duration waited = absl::Now() - start; absl::Duration waited = absl::Now() - start;
EXPECT_GE(waited, absl::Milliseconds(500) - slop); EXPECT_GE(waited, absl::Milliseconds(500) - slop);
EXPECT_LT(waited, absl::Seconds(1)); EXPECT_LT(waited, absl::Seconds(2));
} }
TYPED_TEST_P(WaiterTest, WaitDurationReached) { TYPED_TEST_P(WaiterTest, WaitDurationReached) {
......
...@@ -79,7 +79,7 @@ static void BasicTests(bool notify_before_waiting, Notification* notification) { ...@@ -79,7 +79,7 @@ static void BasicTests(bool notify_before_waiting, Notification* notification) {
// Allow for a slight early return, to account for quality of implementation // Allow for a slight early return, to account for quality of implementation
// issues on various platforms. // issues on various platforms.
const absl::Duration slop = absl::Microseconds(200); const absl::Duration slop = absl::Milliseconds(5);
EXPECT_LE(delay - slop, elapsed) EXPECT_LE(delay - slop, elapsed)
<< "WaitForNotificationWithTimeout returned " << delay - elapsed << "WaitForNotificationWithTimeout returned " << delay - elapsed
<< " early (with " << slop << " slop), start time was " << start; << " early (with " << slop << " slop), start time was " << start;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment