Fix memory leak

4c1b9d83 · Maarten L. Hekkelman · b976b465 · 4c1b9d83
Commit 4c1b9d83 authored Dec 13, 2022 by Maarten L. Hekkelman
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

include/cif++/condition.hpp
+2 -4

No files found.
--- a/include/cif++/condition.hpp
+++ b/include/cif++/condition.hpp
@@ -681,16 +681,14 @@ inline condition operator or(condition &&a, condition &&b)
 		if (typeid(*a.m_impl) == typeid(detail::key_equals_condition_impl) and
 			typeid(*b.m_impl) == typeid(detail::key_is_empty_condition_impl))
 		{
-			detail::key_equals_condition_impl *ci = static_cast<detail::key_equals_condition_impl *>(std::exchange(a.m_impl, nullptr));
+			auto ci = static_cast<detail::key_equals_condition_impl *>(a.m_impl);
-			delete std::exchange(b.m_impl, nullptr);
 			return condition(new detail::key_equals_or_empty_condition_impl(ci));
 		}
 		if (typeid(*b.m_impl) == typeid(detail::key_equals_condition_impl) and
 			typeid(*a.m_impl) == typeid(detail::key_is_empty_condition_impl))
 		{
-			detail::key_equals_condition_impl *ci = static_cast<detail::key_equals_condition_impl *>(std::exchange(b.m_impl, nullptr));
+			auto ci = static_cast<detail::key_equals_condition_impl *>(b.m_impl);
-			delete std::exchange(a.m_impl, nullptr);
 			return condition(new detail::key_equals_or_empty_condition_impl(ci));
 		}