warnings and compiler detection

CMakeLists.txt

@@ -46,8 +46,11 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 
 find_package(Filesystem REQUIRED)
 find_package(Filesystem REQUIRED)
 
 
-if(CMAKE_COMPILER_IS_GNUCC)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-unused-parameter")
+if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+	if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS_EQUAL 8.4.0)
+		message(FATAL_ERROR "Your gnu compiler is too old, please use a more recent one")
+	endif()
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-unused-parameter -Wno-missing-field-initializers")
 endif()
 endif()
 if(MSVC)
 if(MSVC)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
@@ -261,7 +264,7 @@ set(project_headers
 	${PROJECT_SOURCE_DIR}/include/cif++/TlsParser.hpp
 	${PROJECT_SOURCE_DIR}/include/cif++/TlsParser.hpp
 )
 )
 
 
-add_library(cifpp ${project_sources} ${project_headers} ${PROJECT_SOURCE_DIR}/src/SymOpTable_data.hpp)
+add_library(cifpp ${project_sources} ${project_headers} ${CMAKE_SOURCE_DIR}/src/SymOpTable_data.hpp)
 set_target_properties(cifpp PROPERTIES POSITION_INDEPENDENT_CODE ON)
 set_target_properties(cifpp PROPERTIES POSITION_INDEPENDENT_CODE ON)
 
 
 target_include_directories(cifpp
 target_include_directories(cifpp

src/Structure.cpp

@@ -248,8 +248,8 @@ struct AtomImpl
 	AtomImpl(cif::Datablock &db, cif::Row &row)
 	AtomImpl(cif::Datablock &db, cif::Row &row)
 		: mDb(db)
 		: mDb(db)
 		, mID(row["id"].as<std::string>())
 		, mID(row["id"].as<std::string>())
-		, mRow(row)
 		, mRefcount(1)
 		, mRefcount(1)
+		, mRow(row)
 		, mCompound(nullptr)
 		, mCompound(nullptr)
 	{
 	{
 		prefetch();
 		prefetch();