fix: Windows compiler, missing object initializer (#4188)

* Fix for windows compiler, missing object initializer * Removal of if-else macro for MSVC

fix: Windows compiler, missing object initializer (#4188)
* Fix for windows compiler, missing object initializer * Removal of if-else macro for MSVC
424ac4fe · Jan Iwaszkiewicz · GitHub · d02f219f · 424ac4fe
Commit 424ac4fe authored Sep 20, 2022 by Jan Iwaszkiewicz Committed by GitHub Sep 20, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 additions and 6 deletions

include/pybind11/detail/common.h
+1 -6

No files found.
--- a/include/pybind11/detail/common.h
+++ b/include/pybind11/detail/common.h
@@ -1033,12 +1033,7 @@ PYBIND11_NAMESPACE_END(detail)
 ///  - regular: static_cast<Return (Class::*)(Arg0, Arg1, Arg2)>(&Class::func)
 ///  - sweet:   overload_cast<Arg0, Arg1, Arg2>(&Class::func)
 template <typename... Args>
-#    if (defined(_MSC_VER) && _MSC_VER < 1920) /* MSVC 2017 */                                    \
-        || (defined(__clang__) && __clang_major__ == 5)
-static constexpr detail::overload_cast_impl<Args...> overload_cast = {};
-#    else
-static constexpr detail::overload_cast_impl<Args...> overload_cast;
-#    endif
+static constexpr detail::overload_cast_impl<Args...> overload_cast{};
 #endif

 /// Const member function selector for overload_cast