Merge pull request #369 from jagerman/check-for-tabs

Check for style issues during docs build

.travis.yml

@@ -38,9 +38,11 @@ matrix:
   # Documentation build:
   # Documentation build:
   - os: linux
   - os: linux
     language: docs
     language: docs
-    env: DOCS
+    env: DOCS STYLE
     install: pip install sphinx sphinx_rtd_theme
     install: pip install sphinx sphinx_rtd_theme
-    script: make -C docs html SPHINX_OPTIONS=-W
+    script:
+    - make -C docs html SPHINX_OPTIONS=-W
+    - tools/check-style.sh
 cache:
 cache:
   directories:
   directories:
   - $HOME/.cache/pip
   - $HOME/.cache/pip

tools/check-style.sh

+#!/bin/bash
+# 
+# Script to check include/test code for common pybind11 code style errors.
+# Currently just checks for tabs used instead of spaces.
+# 
+# Invoke as: tools/check-style.sh
+#
+
+errors=0
+IFS=$'\n'
+found=
+grep $'\t' include/ tests/ docs/*.rst -rl | while read f; do
+    if [ -z "$found" ]; then
+        echo -e '\e[31m\e[01mError: found tabs instead of spaces in the following files:\e[0m'
+        found=1
+        errors=1
+    fi
+
+    echo "    $f"
+done
+
+found=
+grep '\<\(if\|for\|while\)(' include/ tests/* -r --color=always | while read line; do
+    if [ -z "$found" ]; then
+        echo -e '\e[31m\e[01mError: found the following coding style problems:\e[0m'
+        found=1
+        errors=1
+    fi
+
+    echo "    $line"
+done
+
+exit $errors