Commit 7d3b0571 by Ralf W. Grosse-Kunstleve Committed by GitHub

Improved workaround for Centos 8 failure (follow-on to PR #3030). (#3193)

* Rollback of PR #3030 (Working around Centos 8 failure).

* Adding `-DCMAKE_BUILD_TYPE=Release`

* Improving existing workaround (undoing the originally intended rollback).

* Fixing minor documentation bug.
parent 0be2ea06
...@@ -594,13 +594,13 @@ jobs: ...@@ -594,13 +594,13 @@ jobs:
- name: VAR_BUILD_TYPE 7 - name: VAR_BUILD_TYPE 7
if: matrix.centos == 7 if: matrix.centos == 7
run: echo Release > VAR_BUILD_TYPE run: echo MinSizeRel > VAR_BUILD_TYPE
# Using Debug to avoid segfault that appeared around 2021-06-04, # Using Release to avoid segfault that appeared around 2021-06-04,
# apparently when the gcc version changed from 8.3 to 8.4. # apparently when the gcc version changed from 8.3 to 8.4.
- name: VAR_BUILD_TYPE 8 - name: VAR_BUILD_TYPE 8
if: matrix.centos == 8 if: matrix.centos == 8
run: echo Debug > VAR_BUILD_TYPE run: echo Release > VAR_BUILD_TYPE
- name: Configure - name: Configure
shell: bash shell: bash
......
...@@ -147,7 +147,7 @@ Add a module and setup all helpers. You can select the type of the library; the ...@@ -147,7 +147,7 @@ Add a module and setup all helpers. You can select the type of the library; the
default is ``MODULE``. There are several options: default is ``MODULE``. There are several options:
``OPT_SIZE`` ``OPT_SIZE``
Optimize for size, even if the ``CMAKE_BUILD_TYPE`` is not ``RelSize``. Optimize for size, even if the ``CMAKE_BUILD_TYPE`` is not ``MinSizeRel``.
``THIN_LTO`` ``THIN_LTO``
Use thin TLO instead of regular if there's a choice (pybind11's selection Use thin TLO instead of regular if there's a choice (pybind11's selection
is disabled if ``CMAKE_INTERPROCEDURAL_OPTIMIZATIONS`` is set). is disabled if ``CMAKE_INTERPROCEDURAL_OPTIMIZATIONS`` is set).
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment