Make compiler flags for -Werror specific to GNU, Clang, or Intel

e11e71d8 · Wenzel Jakob · 21c3911b · e11e71d8
Commit e11e71d8 authored Jun 11, 2019 by Wenzel Jakob
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

tests/CMakeLists.txt
+2 -2

No files found.
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -126,14 +126,14 @@ find_package(Boost 1.56)
 function(pybind11_enable_warnings target_name)
  if(MSVC)
    target_compile_options(${target_name} PRIVATE /W4)
-  else()
+  elseif(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Intel|Clang)")
      target_compile_options(${target_name} PRIVATE -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated)
  endif()

  if(PYBIND11_WERROR)
    if(MSVC)
      target_compile_options(${target_name} PRIVATE /WX)
-    else()
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Intel|Clang)")
      target_compile_options(${target_name} PRIVATE -Werror)
    endif()
  endif()