Commit 00c9e49c by Sébastien Eustace Committed by Arun Babu Neelicattu

Make get-poetry.py fallback to standard executables

Co-authored-by: Jonathan Piché <jonapich@users.noreply.github.com>
parent fd1e56b0
...@@ -77,6 +77,15 @@ POETRY_VERSION=0.12.0 python get-poetry.py ...@@ -77,6 +77,15 @@ POETRY_VERSION=0.12.0 python get-poetry.py
Note that the installer does not support Poetry releases < 0.12.0. Note that the installer does not support Poetry releases < 0.12.0.
!!!note
The setup script must be able to find one of following executables in your shell's path environment:
- `python` (which can be a py3 or py2 interpreter)
- `python3`
- `py.exe -3` (Windows)
- `py.exe -2` (Windows)
### Alternative installation methods (not recommended) ### Alternative installation methods (not recommended)
!!!note !!!note
......
...@@ -197,8 +197,7 @@ POETRY_LIB = os.path.join(POETRY_HOME, "lib") ...@@ -197,8 +197,7 @@ POETRY_LIB = os.path.join(POETRY_HOME, "lib")
POETRY_LIB_BACKUP = os.path.join(POETRY_HOME, "lib-backup") POETRY_LIB_BACKUP = os.path.join(POETRY_HOME, "lib-backup")
BIN = """#!/usr/bin/env python BIN = """# -*- coding: utf-8 -*-
# -*- coding: utf-8 -*-
import glob import glob
import sys import sys
import os import os
...@@ -217,7 +216,7 @@ if __name__ == "__main__": ...@@ -217,7 +216,7 @@ if __name__ == "__main__":
main() main()
""" """
BAT = u('@echo off\r\npython "{poetry_bin}" %*\r\n') BAT = u('@echo off\r\n{python_executable} "{poetry_bin}" %*\r\n')
PRE_MESSAGE = """# Welcome to {poetry}! PRE_MESSAGE = """# Welcome to {poetry}!
...@@ -589,23 +588,63 @@ class Installer: ...@@ -589,23 +588,63 @@ class Installer:
finally: finally:
gz.close() gz.close()
def _which_python(self):
"""Decides which python executable we'll embed in the launcher script."""
allowed_executables = ["python", "python3"]
if WINDOWS:
allowed_executables += ["py.exe -3", "py.exe -2"]
# \d in regex ensures we can convert to int later
version_matcher = re.compile(r"^Python (?P<major>\d+)\.(?P<minor>\d+)\..+$")
fallback = None
for executable in allowed_executables:
try:
raw_version = subprocess.check_output(
executable + " --version", stderr=subprocess.STDOUT, shell=True
).decode("utf-8")
except subprocess.CalledProcessError:
continue
match = version_matcher.match(raw_version.strip())
if match:
return executable
if fallback is None:
# keep this one as the fallback; it was the first valid executable we found.
fallback = executable
if fallback is None:
raise RuntimeError(
"No python executable found in shell environment. Tried: "
+ str(allowed_executables)
)
return fallback
def make_bin(self): def make_bin(self):
if not os.path.exists(POETRY_BIN): if not os.path.exists(POETRY_BIN):
os.mkdir(POETRY_BIN, 0o755) os.mkdir(POETRY_BIN, 0o755)
python_executable = self._which_python()
if WINDOWS: if WINDOWS:
with open(os.path.join(POETRY_BIN, "poetry.bat"), "w") as f: with open(os.path.join(POETRY_BIN, "poetry.bat"), "w") as f:
f.write( f.write(
u( u(
BAT.format( BAT.format(
python_executable=python_executable,
poetry_bin=os.path.join(POETRY_BIN, "poetry").replace( poetry_bin=os.path.join(POETRY_BIN, "poetry").replace(
os.environ["USERPROFILE"], "%USERPROFILE%" os.environ["USERPROFILE"], "%USERPROFILE%"
) ),
) )
) )
) )
with open(os.path.join(POETRY_BIN, "poetry"), "w", encoding="utf-8") as f: with open(os.path.join(POETRY_BIN, "poetry"), "w", encoding="utf-8") as f:
if WINDOWS:
python_executable = "python"
f.write(u("#!/usr/bin/env {}\n".format(python_executable)))
f.write(u(BIN)) f.write(u(BIN))
if not WINDOWS: if not WINDOWS:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment