Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
python-poetry
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
open
python-poetry
Commits
1a3ecfb8
Commit
1a3ecfb8
authored
Nov 22, 2021
by
Randy Döring
Committed by
Bjorn Neergaard
Nov 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Normalize case before hashing so that the generated venv name is independent of case on Windows
parent
65d25b67
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
1 deletions
+11
-1
src/poetry/utils/env.py
+2
-1
tests/utils/test_env.py
+9
-0
No files found.
src/poetry/utils/env.py
View file @
1a3ecfb8
...
@@ -1072,7 +1072,8 @@ class EnvManager:
...
@@ -1072,7 +1072,8 @@ class EnvManager:
def
generate_env_name
(
cls
,
name
:
str
,
cwd
:
str
)
->
str
:
def
generate_env_name
(
cls
,
name
:
str
,
cwd
:
str
)
->
str
:
name
=
name
.
lower
()
name
=
name
.
lower
()
sanitized_name
=
re
.
sub
(
r'[ $`!*@"\\\r\n\t]'
,
"_"
,
name
)[:
42
]
sanitized_name
=
re
.
sub
(
r'[ $`!*@"\\\r\n\t]'
,
"_"
,
name
)[:
42
]
h
=
hashlib
.
sha256
(
encode
(
cwd
))
.
digest
()
normalized_cwd
=
os
.
path
.
normcase
(
cwd
)
h
=
hashlib
.
sha256
(
encode
(
normalized_cwd
))
.
digest
()
h
=
base64
.
urlsafe_b64encode
(
h
)
.
decode
()[:
8
]
h
=
base64
.
urlsafe_b64encode
(
h
)
.
decode
()[:
8
]
return
f
"{sanitized_name}-{h}"
return
f
"{sanitized_name}-{h}"
...
...
tests/utils/test_env.py
View file @
1a3ecfb8
...
@@ -1120,3 +1120,12 @@ def test_create_venv_accepts_fallback_version_w_nonzero_patchlevel(
...
@@ -1120,3 +1120,12 @@ def test_create_venv_accepts_fallback_version_w_nonzero_patchlevel(
with_setuptools
=
True
,
with_setuptools
=
True
,
with_wheel
=
True
,
with_wheel
=
True
,
)
)
def
test_generate_env_name_ignores_case_for_case_insensitive_fs
(
tmp_dir
):
venv_name1
=
EnvManager
.
generate_env_name
(
"simple-project"
,
"MyDiR"
)
venv_name2
=
EnvManager
.
generate_env_name
(
"simple-project"
,
"mYdIr"
)
if
sys
.
platform
==
"win32"
:
assert
venv_name1
==
venv_name2
else
:
assert
venv_name1
!=
venv_name2
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment