Skip to content

P
python-poetry
Commit 5b3df562 by Randy Döring Committed by Arun Babu Neelicattu
Options

transaction: code documentation for special condition to decide if packages have to be updated

parent 03e9c2b0
Showing with 11 additions and 0 deletions
src/poetry/puzzle/transaction.py
...@@ -42,8 +42,19 @@ class Transaction: ...@@ -42,8 +42,19 @@ class Transaction:
if result_package.name == installed_package.name: if result_package.name == installed_package.name:
installed = True installed = True
# We have to perform an update if the version or another
# attribute of the package has changed (source type, url, ref, ...).
if result_package.version != installed_package.version or ( if result_package.version != installed_package.version or (
( (
# This has to be done because installed packages cannot
# have type "legacy". If a package with type "legacy"
# is installed, the installed package has no source_type.
# Thus, if installed_package has no source_type and
# the result_package has source_type "legacy" (negation of
# the following condition), update must not be performed.
# This quirk has the side effect that when switching
# from PyPI to legacy (or vice versa),
# no update is performed.
installed_package.source_type installed_package.source_type
or result_package.source_type != "legacy" or result_package.source_type != "legacy"
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment