Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
python-poetry
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
open
python-poetry
Commits
69d171cd
Unverified
Commit
69d171cd
authored
Apr 25, 2019
by
Sébastien Eustace
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix packages not being removed after using the remove command
parent
f2e2ed47
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
13 additions
and
2 deletions
+13
-2
CHANGELOG.md
+7
-0
poetry/installation/installer.py
+0
-1
poetry/masonry/builders/editable.py
+0
-0
tests/installation/test_installer.py
+6
-1
No files found.
CHANGELOG.md
View file @
69d171cd
# Change Log
## [Unreleased]
### Fixed
-
Fixed packages not being removed after using the
`remove`
command.
## [0.12.12] - 2019-04-11
### Fixed
...
...
poetry/installation/installer.py
View file @
69d171cd
...
...
@@ -209,7 +209,6 @@ class Installer:
# Making a new repo containing the packages
# newly resolved and the ones from the current lock file
locked_repository
=
self
.
_locker
.
locked_repository
(
True
)
repo
=
Repository
()
for
package
in
local_repo
.
packages
+
locked_repository
.
packages
:
if
not
repo
.
has_package
(
package
):
...
...
poetry/masonry/builders/editable.py
0 → 100644
View file @
69d171cd
tests/installation/test_installer.py
View file @
69d171cd
...
...
@@ -75,6 +75,7 @@ class Locker(BaseLocker):
package
[
"python-versions"
]
=
python_versions
self
.
_written_data
=
data
self
.
_lock_data
=
data
@pytest.fixture
()
...
...
@@ -330,7 +331,7 @@ def test_run_whitelist_add(installer, locker, repo, package):
assert
locker
.
written_data
==
expected
def
test_run_whitelist_remove
(
installer
,
locker
,
repo
,
package
):
def
test_run_whitelist_remove
(
installer
,
locker
,
repo
,
package
,
installed
):
locker
.
locked
(
True
)
locker
.
mock_lock_data
(
{
...
...
@@ -366,6 +367,7 @@ def test_run_whitelist_remove(installer, locker, repo, package):
package_b
=
get_package
(
"B"
,
"1.1"
)
repo
.
add_package
(
package_a
)
repo
.
add_package
(
package_b
)
installed
.
add_package
(
package_b
)
package
.
add_dependency
(
"A"
,
"~1.0"
)
...
...
@@ -376,6 +378,9 @@ def test_run_whitelist_remove(installer, locker, repo, package):
expected
=
fixture
(
"remove"
)
assert
locker
.
written_data
==
expected
assert
len
(
installer
.
installer
.
installs
)
==
1
assert
len
(
installer
.
installer
.
updates
)
==
0
assert
len
(
installer
.
installer
.
removals
)
==
1
def
test_add_with_sub_dependencies
(
installer
,
locker
,
repo
,
package
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment