Fix the possible deletion of system paths by cache:clear

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fixed a recursion error with circular dependencies.
 - Fixed a recursion error with circular dependencies.
 - Fixed the `config` command setting incorrect values for paths.
 - Fixed the `config` command setting incorrect values for paths.
 - Fixed an `OSError` on Python >= 3.5 for `git` dependencies with recursive symlinks.
 - Fixed an `OSError` on Python >= 3.5 for `git` dependencies with recursive symlinks.
+- Fixed the possible deletion of system paths by `cache:clear`.
 
 
 
 
 ## [0.11.4] - 2018-07-30
 ## [0.11.4] - 2018-07-30

poetry/console/commands/cache/clear.py

@@ -15,16 +15,26 @@ class CacheClearCommand(Command):
     def handle(self):
     def handle(self):
         from cachy import CacheManager
         from cachy import CacheManager
         from poetry.locations import CACHE_DIR
         from poetry.locations import CACHE_DIR
+        from poetry.utils._compat import Path
 
 
         cache = self.argument("cache")
         cache = self.argument("cache")
 
 
         parts = cache.split(":")
         parts = cache.split(":")
-        cache_dir = os.path.join(CACHE_DIR, "cache", "repositories", parts[0])
+        root = parts[0]
+
+        base_cache = Path(CACHE_DIR) / "cache" / "repositories"
+        cache_dir = base_cache / root
+
+        try:
+            cache_dir.relative_to(base_cache)
+        except ValueError:
+            raise ValueError("{} is not a valid repository cache".format(root))
+
         cache = CacheManager(
         cache = CacheManager(
             {
             {
                 "default": parts[0],
                 "default": parts[0],
                 "serializer": "json",
                 "serializer": "json",
-                "stores": {parts[0]: {"driver": "file", "path": cache_dir}},
+                "stores": {parts[0]: {"driver": "file", "path": str(cache_dir)}},
             }
             }
         )
         )
 
 
@@ -41,7 +51,7 @@ class CacheClearCommand(Command):
 
 
             # Calculate number of entries
             # Calculate number of entries
             entries_count = 0
             entries_count = 0
-            for path, dirs, files in os.walk(cache_dir):
+            for path, dirs, files in os.walk(str(cache_dir)):
                 entries_count += len(files)
                 entries_count += len(files)
 
 
             delete = self.confirm(
             delete = self.confirm(