Commit 7f152988 by Daniel Eades Committed by Bjorn Neergaard

de-glob mypy whitelist for 'installation' module

parent 06fcff08
...@@ -136,8 +136,12 @@ module = [ ...@@ -136,8 +136,12 @@ module = [
'poetry.console.commands.source.add', 'poetry.console.commands.source.add',
'poetry.console.commands.update', 'poetry.console.commands.update',
'poetry.console.commands.version', 'poetry.console.commands.version',
'poetry.inspection.*', 'poetry.inspection.info',
'poetry.installation.*', 'poetry.installation.chef',
'poetry.installation.chooser',
'poetry.installation.executor',
'poetry.installation.installer',
'poetry.installation.pip_installer',
'poetry.mixology.assignment', 'poetry.mixology.assignment',
'poetry.mixology.failure', 'poetry.mixology.failure',
'poetry.mixology.incompatibility', 'poetry.mixology.incompatibility',
......
...@@ -10,9 +10,9 @@ if TYPE_CHECKING: ...@@ -10,9 +10,9 @@ if TYPE_CHECKING:
class NoopInstaller(BaseInstaller): class NoopInstaller(BaseInstaller):
def __init__(self) -> None: def __init__(self) -> None:
self._installs = [] self._installs: List["Package"] = []
self._updates = [] self._updates: List["Package"] = []
self._removals = [] self._removals: List["Package"] = []
@property @property
def installs(self) -> List["Package"]: def installs(self) -> List["Package"]:
......
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
from typing import Optional from typing import Optional
from typing import TypeVar from typing import TypeVar
from typing import Union
if TYPE_CHECKING: if TYPE_CHECKING:
...@@ -10,11 +11,13 @@ T = TypeVar("T", bound="Operation") ...@@ -10,11 +11,13 @@ T = TypeVar("T", bound="Operation")
class Operation: class Operation:
def __init__(self, reason: Optional[str] = None, priority: int = 0) -> None: def __init__(
self, reason: Optional[str] = None, priority: Union[int, float] = 0
) -> None:
self._reason = reason self._reason = reason
self._skipped = False self._skipped = False
self._skip_reason = None self._skip_reason: Optional[str] = None
self._priority = priority self._priority = priority
@property @property
...@@ -22,7 +25,7 @@ class Operation: ...@@ -22,7 +25,7 @@ class Operation:
raise NotImplementedError raise NotImplementedError
@property @property
def reason(self) -> str: def reason(self) -> Optional[str]:
return self._reason return self._reason
@property @property
...@@ -34,7 +37,7 @@ class Operation: ...@@ -34,7 +37,7 @@ class Operation:
return self._skip_reason return self._skip_reason
@property @property
def priority(self) -> int: def priority(self) -> Union[float, int]:
return self._priority return self._priority
@property @property
......
from typing import TYPE_CHECKING from typing import TYPE_CHECKING
from typing import Optional from typing import Optional
from typing import Union
from poetry.installation.operations.operation import Operation from poetry.installation.operations.operation import Operation
...@@ -13,7 +14,7 @@ class Uninstall(Operation): ...@@ -13,7 +14,7 @@ class Uninstall(Operation):
self, self,
package: "Package", package: "Package",
reason: Optional[str] = None, reason: Optional[str] = None,
priority: int = float("inf"), priority: Union[float, int] = float("inf"),
) -> None: ) -> None:
super().__init__(reason, priority=priority) super().__init__(reason, priority=priority)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment