Fix packages with no hashes retrieval for alternative repositories

8b1afebb · Sébastien Eustace · dd444198 · 8b1afebb · 8b1afebb · 8b1afebb
Commit 8b1afebb authored May 17, 2019 by Sébastien Eustace
Show whitespace changes
Inline Side-by-side

Showing with 17 additions and 2 deletions

CHANGELOG.md
+7 -0

poetry/repositories/legacy_repository.py
+1 -1

tests/repositories/fixtures/legacy/jupyter.html
+1 -1

tests/repositories/test_legacy_repository.py
+8 -0

No files found.
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
 # Change Log

+## [Unreleased]
+
+### Fixed
+
+- Fixed packages with no hashes retrieval for legacy repositories.
+
+
 ## [0.12.15] - 2019-05-03

 ### Fixed

--- a/poetry/repositories/legacy_repository.py
+++ b/poetry/repositories/legacy_repository.py
@@ -359,7 +359,7 @@ class LegacyRepository(PyPiRepository):
            hash = link.hash
            if link.hash_name == "sha256":
                hashes.append(hash)
-            else:
+            elif hash:
                hashes.append(link.hash_name + ":" + hash)

        data["digests"] = hashes

--- a/tests/repositories/fixtures/legacy/jupyter.html
+++ b/tests/repositories/fixtures/legacy/jupyter.html
@@ -5,7 +5,7 @@
  </head>
  <body>
    <h1>Links for jupyter</h1>
-    <a href="https://files.pythonhosted.org/packages/c9/a9/371d0b8fe37dd231cf4b2cff0a9f0f25e98f3a73c3771742444be27f2944/jupyter-1.0.0.tar.gz#sha256=d9dc4b3318f310e34c82951ea5d6683f67bed7def4b259fafbfe4f1beb1d8e5f">jupyter-1.0.0.tar.gz</a><br/>
+    <a href="https://files.pythonhosted.org/packages/c9/a9/371d0b8fe37dd231cf4b2cff0a9f0f25e98f3a73c3771742444be27f2944/jupyter-1.0.0.tar.gz">jupyter-1.0.0.tar.gz</a><br/>
    </body>
 </html>
 <!--SERIAL 1673841-->
--- a/tests/repositories/test_legacy_repository.py
+++ b/tests/repositories/test_legacy_repository.py
@@ -245,3 +245,11 @@ def test_get_package_retrieves_non_sha256_hashes():
    ]

    assert expected == package.hashes
+
+
+def test_get_package_retrieves_packages_with_no_hashes():
+    repo = MockRepository()
+
+    package = repo.package("jupyter", "1.0.0")
+
+    assert [] == package.hashes