Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
P
python-poetry
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
open
python-poetry
Commits
ad40e5bc
Unverified
Commit
ad40e5bc
authored
Nov 13, 2019
by
Sébastien Eustace
Committed by
GitHub
Nov 13, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix an invalid git url error when solving with installed and locked git depednencies (#1576)
parent
4f1b0f8a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
34 additions
and
0 deletions
+34
-0
poetry/puzzle/solver.py
+3
-0
tests/puzzle/test_solver.py
+31
-0
No files found.
poetry/puzzle/solver.py
View file @
ad40e5bc
...
@@ -62,6 +62,9 @@ class Solver:
...
@@ -62,6 +62,9 @@ class Solver:
pkg_source_url
=
Git
.
normalize_url
(
pkg
.
source_url
)
pkg_source_url
=
Git
.
normalize_url
(
pkg
.
source_url
)
package_source_url
=
Git
.
normalize_url
(
package
.
source_url
)
package_source_url
=
Git
.
normalize_url
(
package
.
source_url
)
for
locked
in
self
.
_locked
.
packages
:
for
locked
in
self
.
_locked
.
packages
:
if
locked
.
name
!=
pkg
.
name
or
locked
.
source_type
!=
"git"
:
continue
locked_source_url
=
Git
.
normalize_url
(
locked
.
source_url
)
locked_source_url
=
Git
.
normalize_url
(
locked
.
source_url
)
if
(
if
(
locked
.
name
==
pkg
.
name
locked
.
name
==
pkg
.
name
...
...
tests/puzzle/test_solver.py
View file @
ad40e5bc
...
@@ -1856,3 +1856,34 @@ def test_solver_does_not_loop_indefinitely_on_duplicate_constraints_with_extras(
...
@@ -1856,3 +1856,34 @@ def test_solver_does_not_loop_indefinitely_on_duplicate_constraints_with_extras(
ops
,
ops
,
[{
"job"
:
"install"
,
"package"
:
idna
},
{
"job"
:
"install"
,
"package"
:
requests
}],
[{
"job"
:
"install"
,
"package"
:
idna
},
{
"job"
:
"install"
,
"package"
:
requests
}],
)
)
def
test_solver_does_not_fail_with_locked_git_and_non_git_dependencies
(
solver
,
repo
,
package
,
locked
,
pool
,
installed
,
io
):
package
.
add_dependency
(
"demo"
,
{
"git"
:
"https://github.com/demo/demo.git"
})
package
.
add_dependency
(
"a"
,
"^1.2.3"
)
git_package
=
get_package
(
"demo"
,
"0.1.2"
)
git_package
.
source_type
=
"git"
git_package
.
source_url
=
"https://github.com/demo/demo.git"
git_package
.
source_reference
=
"commit"
installed
.
add_package
(
git_package
)
locked
.
add_package
(
get_package
(
"a"
,
"1.2.3"
))
locked
.
add_package
(
git_package
)
repo
.
add_package
(
get_package
(
"a"
,
"1.2.3"
))
solver
=
Solver
(
package
,
pool
,
installed
,
locked
,
io
)
ops
=
solver
.
solve
()
check_solver_result
(
ops
,
[
{
"job"
:
"install"
,
"package"
:
get_package
(
"a"
,
"1.2.3"
)},
{
"job"
:
"install"
,
"package"
:
git_package
,
"skipped"
:
True
},
],
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment