Skip to content

P
python-poetry
Commit bf331a54 by Sébastien Eustace Committed by GitHub
Options

Speed up tests (#2257) 

When testing the behavior for git packages with a setup.py file, the Provider class would create a temporary virtual environment and execute python setup.py egg_info. Both actions are costly and take time. By mocking them, we can reduce the tests time by a factor of 4 or 5.
parent 655f5825
Showing with 125 additions and 10 deletions
.gitignore
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
*.egg *.egg
!/tests/**/*.egg !/tests/**/*.egg
/*.egg-info /*.egg-info
/tests/fixtures/**/*.egg-info
/dist/* /dist/*
build build
_build _build
......
poetry/puzzle/provider.py
...@@ -326,10 +326,7 @@ class Provider: ...@@ -326,10 +326,7 @@ class Provider:
os.chdir(str(directory)) os.chdir(str(directory))
try: try:
with temporary_directory() as tmp_dir: cls._execute_setup()
EnvManager.build_venv(tmp_dir)
venv = VirtualEnv(Path(tmp_dir), Path(tmp_dir))
venv.run("python", "setup.py", "egg_info")
except EnvCommandError: except EnvCommandError:
result = SetupReader.read_from_directory(directory) result = SetupReader.read_from_directory(directory)
if not result["name"]: if not result["name"]:
...@@ -817,3 +814,9 @@ class Provider: ...@@ -817,3 +814,9 @@ class Provider:
yield yield
self._in_progress = False self._in_progress = False
def _execute_setup(self):
with temporary_directory() as tmp_dir:
EnvManager.build_venv(tmp_dir)
venv = VirtualEnv(Path(tmp_dir), Path(tmp_dir))
venv.run("python", "setup.py", "egg_info")
pyproject.toml
...@@ -116,3 +116,23 @@ known_third_party = [ ...@@ -116,3 +116,23 @@ known_third_party = [
"shellingham", "shellingham",
"tomlkit", "tomlkit",
] ]
[tool.black]
line-length = 88
include = '\.pyi?$'
exclude = '''
/(
\.eggs
| \.git
| \.hg
| \.mypy_cache
| \.tox
| \.venv
| _build
| buck-out
| build
| dist
| tests/.*/setup.py
)/
'''
tests/conftest.py
...@@ -74,6 +74,11 @@ def download_mock(mocker): ...@@ -74,6 +74,11 @@ def download_mock(mocker):
mocker.patch("poetry.utils.inspector.Inspector.download", new=mock_download) mocker.patch("poetry.utils.inspector.Inspector.download", new=mock_download)
@pytest.fixture(autouse=True)
def execute_setup_mock(mocker):
mocker.patch("poetry.puzzle.provider.Provider._execute_setup")
@pytest.fixture @pytest.fixture
def environ(): def environ():
original_environ = dict(os.environ) original_environ = dict(os.environ)
......
tests/fixtures/git/github.com/demo/demo/demo.egg-info/PKG-INFO 0 → 100755
Metadata-Version: 2.1
Name: demo
Version: 0.1.2
Summary: Demo project.
Home-page: https://github.com/demo/demo
Author: Sébastien Eustace
Author-email: sebastien@eustace.io
License: MIT
Description: UNKNOWN
Platform: UNKNOWN
Provides-Extra: bar
Provides-Extra: foo
tests/fixtures/git/github.com/demo/demo/demo.egg-info/SOURCES.txt 0 → 100755
setup.py
demo/__init__.py
demo.egg-info/PKG-INFO
demo.egg-info/SOURCES.txt
demo.egg-info/dependency_links.txt
demo.egg-info/requires.txt
demo.egg-info/top_level.txt
tests/fixtures/git/github.com/demo/no-dependencies/demo.egg-info/PKG-INFO 0 → 100644
Metadata-Version: 1.0
Name: demo
Version: 0.1.2
Summary: Demo project.
Home-page: https://github.com/demo/demo
Author: Sébastien Eustace
Author-email: sebastien@eustace.io
License: MIT
Description: UNKNOWN
Platform: UNKNOWN
tests/fixtures/git/github.com/demo/no-dependencies/demo.egg-info/SOURCES.txt 0 → 100644
setup.py
demo/__init__.py
demo.egg-info/PKG-INFO
demo.egg-info/SOURCES.txt
demo.egg-info/dependency_links.txt
demo.egg-info/top_level.txt
tests/fixtures/git/github.com/demo/non-canonical-name/Demo.egg-info/PKG-INFO 0 → 100644
Metadata-Version: 2.1
Name: Demo
Version: 0.1.2
Summary: Demo project.
Home-page: https://github.com/demo/demo
Author: Sébastien Eustace
Author-email: sebastien@eustace.io
License: MIT
Description: UNKNOWN
Platform: UNKNOWN
Provides-Extra: foo
Provides-Extra: bar
tests/fixtures/git/github.com/demo/non-canonical-name/Demo.egg-info/SOURCES.txt 0 → 100644
setup.py
Demo.egg-info/PKG-INFO
Demo.egg-info/SOURCES.txt
Demo.egg-info/dependency_links.txt
Demo.egg-info/requires.txt
Demo.egg-info/top_level.txt
demo/__init__.py
tests/fixtures/project_with_setup/my_package.egg-info/PKG-INFO 0 → 100644
Metadata-Version: 1.0
Name: my-package
Version: 0.1.2
Summary: Demo project.
Home-page: https://github.com/demo/demo
Author: Sébastien Eustace
Author-email: sebastien@eustace.io
License: MIT
Description: UNKNOWN
Platform: UNKNOWN
tests/fixtures/project_with_setup/my_package.egg-info/SOURCES.txt 0 → 100644
setup.py
my_package/__init__.py
my_package.egg-info/PKG-INFO
my_package.egg-info/SOURCES.txt
my_package.egg-info/dependency_links.txt
my_package.egg-info/requires.txt
my_package.egg-info/top_level.txt
tests/masonry/builders/fixtures/excluded_subpackage/README.rst
My Package My Package
========== ==========
\ No newline at end of file
tests/puzzle/test_provider.py
...@@ -118,7 +118,7 @@ def test_search_for_vcs_read_setup_with_extras(provider, mocker): ...@@ -118,7 +118,7 @@ def test_search_for_vcs_read_setup_with_extras(provider, mocker):
def test_search_for_vcs_read_setup_raises_error_if_no_version(provider, mocker): def test_search_for_vcs_read_setup_raises_error_if_no_version(provider, mocker):
mocker.patch( mocker.patch(
"poetry.utils.env.VirtualEnv.run", "poetry.puzzle.provider.Provider._execute_setup",
side_effect=EnvCommandError(CalledProcessError(1, "python", output="")), side_effect=EnvCommandError(CalledProcessError(1, "python", output="")),
) )
......
tests/repositories/fixtures/installed/vendor/py3.7/attrs-19.3.0.dist-info/METADATA
...@@ -225,5 +225,3 @@ A full list of contributors can be found in `GitHub's overview <https://github.c ...@@ -225,5 +225,3 @@ A full list of contributors can be found in `GitHub's overview <https://github.c
It’s the spiritual successor of `characteristic <https://characteristic.readthedocs.io/>`_ and aspires to fix some of it clunkiness and unfortunate decisions. It’s the spiritual successor of `characteristic <https://characteristic.readthedocs.io/>`_ and aspires to fix some of it clunkiness and unfortunate decisions.
Both were inspired by Twisted’s `FancyEqMixin <https://twistedmatrix.com/documents/current/api/twisted.python.util.FancyEqMixin.html>`_ but both are implemented using class decorators because `subclassing is bad for you <https://www.youtube.com/watch?v=3MNVP9-hglc>`_, m’kay? Both were inspired by Twisted’s `FancyEqMixin <https://twistedmatrix.com/documents/current/api/twisted.python.util.FancyEqMixin.html>`_ but both are implemented using class decorators because `subclassing is bad for you <https://www.youtube.com/watch?v=3MNVP9-hglc>`_, m’kay?
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment