Commit eb27f816 by Anthony Clark Committed by GitHub

mypy type checks in password_manager (#5399)

* Remove password_manager from mypy overrides in pyproject.toml

* mypy now passing on password_manager.py
parent 9b8d8304
...@@ -132,7 +132,6 @@ module = [ ...@@ -132,7 +132,6 @@ module = [
'poetry.utils.authenticator', 'poetry.utils.authenticator',
'poetry.utils.env', 'poetry.utils.env',
'poetry.utils.exporter', 'poetry.utils.exporter',
'poetry.utils.password_manager',
'poetry.utils.setup_reader', 'poetry.utils.setup_reader',
] ]
ignore_errors = true ignore_errors = true
......
...@@ -121,10 +121,10 @@ class KeyRing: ...@@ -121,10 +121,10 @@ class KeyRing:
class PasswordManager: class PasswordManager:
def __init__(self, config: Config) -> None: def __init__(self, config: Config) -> None:
self._config = config self._config = config
self._keyring = None self._keyring: KeyRing | None = None
@property @property
def keyring(self) -> KeyRing | None: def keyring(self) -> KeyRing:
if self._keyring is None: if self._keyring is None:
self._keyring = KeyRing("poetry-repository") self._keyring = KeyRing("poetry-repository")
if not self._keyring.is_available(): if not self._keyring.is_available():
...@@ -140,7 +140,7 @@ class PasswordManager: ...@@ -140,7 +140,7 @@ class PasswordManager:
else: else:
self.keyring.set_password(name, "__token__", token) self.keyring.set_password(name, "__token__", token)
def get_pypi_token(self, name: str) -> str: def get_pypi_token(self, name: str) -> str | None:
if not self.keyring.is_available(): if not self.keyring.is_available():
return self._config.get(f"pypi-token.{name}") return self._config.get(f"pypi-token.{name}")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment