Commit 1524b1ac by pateldeev

Use InlinedVector

parent afc9206b
...@@ -1169,6 +1169,7 @@ cc_library( ...@@ -1169,6 +1169,7 @@ cc_library(
":strings", ":strings",
"//absl/base:config", "//absl/base:config",
"//absl/base:core_headers", "//absl/base:core_headers",
"//absl/container:inlined_vector",
"//absl/functional:function_ref", "//absl/functional:function_ref",
"//absl/meta:type_traits", "//absl/meta:type_traits",
"//absl/numeric:bits", "//absl/numeric:bits",
......
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
#include <string> #include <string>
#include "absl/base/port.h" #include "absl/base/port.h"
#include "absl/container/inlined_vector.h"
#include "absl/strings/internal/str_format/arg.h" #include "absl/strings/internal/str_format/arg.h"
#include "absl/strings/internal/str_format/checker.h" #include "absl/strings/internal/str_format/checker.h"
#include "absl/strings/internal/str_format/parser.h" #include "absl/strings/internal/str_format/parser.h"
...@@ -177,17 +178,7 @@ class Streamable { ...@@ -177,17 +178,7 @@ class Streamable {
public: public:
Streamable(const UntypedFormatSpecImpl& format, Streamable(const UntypedFormatSpecImpl& format,
absl::Span<const FormatArgImpl> args) absl::Span<const FormatArgImpl> args)
: format_(format) { : format_(format), args_(args.begin(), args.end()) { }
if (args.size() <= ABSL_ARRAYSIZE(few_args_)) {
for (size_t i = 0; i < args.size(); ++i) {
few_args_[i] = args[i];
}
args_ = absl::MakeSpan(few_args_, args.size());
} else {
many_args_.assign(args.begin(), args.end());
args_ = many_args_;
}
}
std::ostream& Print(std::ostream& os) const; std::ostream& Print(std::ostream& os) const;
...@@ -197,12 +188,7 @@ class Streamable { ...@@ -197,12 +188,7 @@ class Streamable {
private: private:
const UntypedFormatSpecImpl& format_; const UntypedFormatSpecImpl& format_;
absl::Span<const FormatArgImpl> args_; absl::InlinedVector<FormatArgImpl, 4> args_;
// if args_.size() is 4 or less:
FormatArgImpl few_args_[4] = {FormatArgImpl(0), FormatArgImpl(0),
FormatArgImpl(0), FormatArgImpl(0)};
// if args_.size() is more than 4:
std::vector<FormatArgImpl> many_args_;
}; };
// for testing // for testing
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment