Skip to content

A
abseil-cpp
Commit d36d20c0 by Arkady Shapkin Committed by GitHub
Options

Fix MSVC version checking in lifetime_test.cc

parent 1649c037
Showing with 2 additions and 3 deletions
absl/synchronization/lifetime_test.cc
...@@ -123,10 +123,9 @@ class OnDestruction { ...@@ -123,10 +123,9 @@ class OnDestruction {
}; };
// These tests require that the compiler correctly supports C++11 constant // These tests require that the compiler correctly supports C++11 constant
// initialization... but MSVC has a known regression since v19.10: // initialization... but MSVC has a known regression since v19.10 till v19.25:
// https://developercommunity.visualstudio.com/content/problem/336946/class-with-constexpr-constructor-not-using-static.html // https://developercommunity.visualstudio.com/content/problem/336946/class-with-constexpr-constructor-not-using-static.html
// TODO(epastor): Limit the affected range once MSVC fixes this bug. #if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900 && _MSC_VER < 1925)
#if defined(__clang__) || !(defined(_MSC_VER) && _MSC_VER > 1900)
// kConstInit // kConstInit
// Test early usage. (Declaration comes first; definitions must appear after // Test early usage. (Declaration comes first; definitions must appear after
// the test runner.) // the test runner.)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment