Add some nullability annotations in logging and tidy up some NOLINTs and comments.

PiperOrigin-RevId: 694512830
Change-Id: Ibeb8eb5fd18af5c49fe45a903e5cb129ee15974d

absl/log/BUILD.bazel

@@ -187,6 +187,7 @@ cc_library(
     deps = [
     deps = [
         ":log_sink",
         ":log_sink",
         "//absl/base:config",
         "//absl/base:config",
+        "//absl/base:nullability",
         "//absl/log/internal:log_sink_set",
         "//absl/log/internal:log_sink_set",
     ],
     ],
 )
 )

absl/log/CMakeLists.txt

@@ -196,8 +196,8 @@ absl_cc_library(
     absl::config
     absl::config
     absl::core_headers
     absl::core_headers
     absl::errno_saver
     absl::errno_saver
-    absl::inlined_vector
     absl::examine_stack
     absl::examine_stack
+    absl::inlined_vector
     absl::log_internal_append_truncated
     absl::log_internal_append_truncated
     absl::log_internal_format
     absl::log_internal_format
     absl::log_internal_globals
     absl::log_internal_globals
@@ -210,11 +210,12 @@ absl_cc_library(
     absl::log_sink
     absl::log_sink
     absl::log_sink_registry
     absl::log_sink_registry
     absl::memory
     absl::memory
+    absl::nullability
     absl::raw_logging_internal
     absl::raw_logging_internal
-    absl::strings
+    absl::span
     absl::strerror
     absl::strerror
+    absl::strings
     absl::time
     absl::time
-    absl::span
 )
 )
 
 
 absl_cc_library(
 absl_cc_library(
@@ -603,6 +604,7 @@ absl_cc_library(
     absl::config
     absl::config
     absl::log_sink
     absl::log_sink
     absl::log_internal_log_sink_set
     absl::log_internal_log_sink_set
+    absl::nullability
   PUBLIC
   PUBLIC
 )
 )
 
 

absl/log/internal/BUILD.bazel

@@ -179,6 +179,7 @@ cc_library(
         "//absl/base:core_headers",
         "//absl/base:core_headers",
         "//absl/base:errno_saver",
         "//absl/base:errno_saver",
         "//absl/base:log_severity",
         "//absl/base:log_severity",
+        "//absl/base:nullability",
         "//absl/base:raw_logging_internal",
         "//absl/base:raw_logging_internal",
         "//absl/base:strerror",
         "//absl/base:strerror",
         "//absl/container:inlined_vector",
         "//absl/container:inlined_vector",

absl/log/internal/log_message.cc

@@ -418,23 +418,26 @@ LogMessage& LogMessage::operator<<(std::ios_base& (*m)(std::ios_base& os)) {
   data_->manipulated << m;
   data_->manipulated << m;
   return *this;
   return *this;
 }
 }
+// NOLINTBEGIN(runtime/int)
+// NOLINTBEGIN(google-runtime-int)
 template LogMessage& LogMessage::operator<<(const char& v);
 template LogMessage& LogMessage::operator<<(const char& v);
 template LogMessage& LogMessage::operator<<(const signed char& v);
 template LogMessage& LogMessage::operator<<(const signed char& v);
 template LogMessage& LogMessage::operator<<(const unsigned char& v);
 template LogMessage& LogMessage::operator<<(const unsigned char& v);
-template LogMessage& LogMessage::operator<<(const short& v);           // NOLINT
-template LogMessage& LogMessage::operator<<(const unsigned short& v);  // NOLINT
+template LogMessage& LogMessage::operator<<(const short& v);
+template LogMessage& LogMessage::operator<<(const unsigned short& v);
 template LogMessage& LogMessage::operator<<(const int& v);
 template LogMessage& LogMessage::operator<<(const int& v);
 template LogMessage& LogMessage::operator<<(const unsigned int& v);
 template LogMessage& LogMessage::operator<<(const unsigned int& v);
-template LogMessage& LogMessage::operator<<(const long& v);           // NOLINT
-template LogMessage& LogMessage::operator<<(const unsigned long& v);  // NOLINT
-template LogMessage& LogMessage::operator<<(const long long& v);      // NOLINT
-template LogMessage& LogMessage::operator<<(
-    const unsigned long long& v);  // NOLINT
+template LogMessage& LogMessage::operator<<(const long& v);
+template LogMessage& LogMessage::operator<<(const unsigned long& v);
+template LogMessage& LogMessage::operator<<(const long long& v);
+template LogMessage& LogMessage::operator<<(const unsigned long long& v);
 template LogMessage& LogMessage::operator<<(void* const& v);
 template LogMessage& LogMessage::operator<<(void* const& v);
 template LogMessage& LogMessage::operator<<(const void* const& v);
 template LogMessage& LogMessage::operator<<(const void* const& v);
 template LogMessage& LogMessage::operator<<(const float& v);
 template LogMessage& LogMessage::operator<<(const float& v);
 template LogMessage& LogMessage::operator<<(const double& v);
 template LogMessage& LogMessage::operator<<(const double& v);
 template LogMessage& LogMessage::operator<<(const bool& v);
 template LogMessage& LogMessage::operator<<(const bool& v);
+// NOLINTEND(google-runtime-int)
+// NOLINTEND(runtime/int)
 
 
 void LogMessage::Flush() {
 void LogMessage::Flush() {
   if (data_->entry.log_severity() < absl::MinLogLevel()) return;
   if (data_->entry.log_severity() < absl::MinLogLevel()) return;

absl/log/log_sink_registry.h

@@ -22,6 +22,7 @@
 #define ABSL_LOG_LOG_SINK_REGISTRY_H_
 #define ABSL_LOG_LOG_SINK_REGISTRY_H_
 
 
 #include "absl/base/config.h"
 #include "absl/base/config.h"
+#include "absl/base/nullability.h"
 #include "absl/log/internal/log_sink_set.h"
 #include "absl/log/internal/log_sink_set.h"
 #include "absl/log/log_sink.h"
 #include "absl/log/log_sink.h"
 
 
@@ -43,8 +44,10 @@ ABSL_NAMESPACE_BEGIN
 // sink instead which writes them to `stderr`.
 // sink instead which writes them to `stderr`.
 //
 //
 // Do not call these inside `absl::LogSink::Send`.
 // Do not call these inside `absl::LogSink::Send`.
-inline void AddLogSink(absl::LogSink* sink) { log_internal::AddLogSink(sink); }
-inline void RemoveLogSink(absl::LogSink* sink) {
+inline void AddLogSink(absl::Nonnull<absl::LogSink*> sink) {
+  log_internal::AddLogSink(sink);
+}
+inline void RemoveLogSink(absl::Nonnull<absl::LogSink*> sink) {
   log_internal::RemoveLogSink(sink);
   log_internal::RemoveLogSink(sink);
 }
 }