Commit fd7713cb by Derek Mauro Committed by Copybara-Service

Disable ABSL_ATTRIBUTE_OWNER and ABSL_ATTRIBUTE_VIEW prior to Clang-13

due to false positives.

https://godbolt.org/z/evjd73cv6

PiperOrigin-RevId: 666027404
Change-Id: Ib0fe9c7b3d2aeb8710342e9e2aadc6a346e03e60
parent 5a01d0f7
...@@ -844,10 +844,16 @@ ...@@ -844,10 +844,16 @@
// return s; // warning: address of stack memory returned // return s; // warning: address of stack memory returned
// } // }
// //
// We disable this on Clang versions < 13 because of the following
// false-positive:
//
// absl::string_view f(absl::optional<absl::string_view> sv) { return *sv; }
//
// See the following links for details: // See the following links for details:
// https://reviews.llvm.org/D64448 // https://reviews.llvm.org/D64448
// https://lists.llvm.org/pipermail/cfe-dev/2018-November/060355.html // https://lists.llvm.org/pipermail/cfe-dev/2018-November/060355.html
#if ABSL_HAVE_CPP_ATTRIBUTE(gsl::Pointer) #if ABSL_HAVE_CPP_ATTRIBUTE(gsl::Pointer) && \
(!defined(__clang_major__) || __clang_major__ >= 13)
#define ABSL_ATTRIBUTE_VIEW [[gsl::Pointer]] #define ABSL_ATTRIBUTE_VIEW [[gsl::Pointer]]
#else #else
#define ABSL_ATTRIBUTE_VIEW #define ABSL_ATTRIBUTE_VIEW
...@@ -870,10 +876,16 @@ ...@@ -870,10 +876,16 @@
// return s; // warning: address of stack memory returned // return s; // warning: address of stack memory returned
// } // }
// //
// We disable this on Clang versions < 13 because of the following
// false-positive:
//
// absl::string_view f(absl::optional<absl::string_view> sv) { return *sv; }
//
// See the following links for details: // See the following links for details:
// https://reviews.llvm.org/D64448 // https://reviews.llvm.org/D64448
// https://lists.llvm.org/pipermail/cfe-dev/2018-November/060355.html // https://lists.llvm.org/pipermail/cfe-dev/2018-November/060355.html
#if ABSL_HAVE_CPP_ATTRIBUTE(gsl::Owner) #if ABSL_HAVE_CPP_ATTRIBUTE(gsl::Owner) && \
(!defined(__clang_major__) || __clang_major__ >= 13)
#define ABSL_ATTRIBUTE_OWNER [[gsl::Owner]] #define ABSL_ATTRIBUTE_OWNER [[gsl::Owner]]
#else #else
#define ABSL_ATTRIBUTE_OWNER #define ABSL_ATTRIBUTE_OWNER
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment