Commits · 031d99ab8761084ea3499688dc82c27abd10314e · open / abseil-cpp

13 Dec, 2023 1 commit

Add `ostream<<` and `AbslStringify` to `absl::StatusOr`. · 031d99ab

These methods will only be defined if they're defined for `T`.  Additionally,
we add jitter to the output to discourage people relying on the output format.

PiperOrigin-RevId: 590598988
Change-Id: I4e7173b5f0c66fd3a1cdd3392944e20b8a26641f

committed Dec 13, 2023

031d99ab Browse Files

12 Dec, 2023 2 commits

Unit-tests to verify ABSL raw_hash_set does not double-hash in prod · f16e457b
```
PiperOrigin-RevId: 590337123
Change-Id: Ib98bbb5a5dadbce5e891567038e016f4da2efc0b
```
Abseil Team committed Dec 12, 2023
f16e457b Browse Files

Add `MaskFull` to `Group`. · ad0a6d2f

It is not used at the moment. Usage is planned to be submitted separately.

Useful for faster iterating over all slots in the internal functions.

PiperOrigin-RevId: 590300049
Change-Id: I081f33113268761db868771d29796d94c24e4e7a

committed Dec 12, 2023

ad0a6d2f Browse Files

11 Dec, 2023 3 commits

`absl/utility`: Delete tests for C++11-compatible `integer_sequence` and friends · 011aeede

These used to be independent implementations. Now that they are aliases, maintaining tests doesn't make sense anymore.

PiperOrigin-RevId: 589947915
Change-Id: I555496e3467d56a75468b180383482eee2e8f198

committed Dec 11, 2023

011aeede Browse Files

`absl/utility`: Delete C++11-compatible `integer_sequence` and friends · 8843e8e2

Abseil does not support C++11 anymore: https://github.com/google/oss-policies-info/blob/b842c39db88e6569dfe2cf98be434b03507cb503/foundational-cxx-support-matrix.md

NOTE: This is a breaking change because `std::integer_sequence<T>` requires `std::is_integral_v<T>`, but `absl::integer_sequence<T>` does not.

Unit tests will be deleted in a follow-up.

PiperOrigin-RevId: 589908215
Change-Id: I57a81e4451840304d5fba60bef286e81e024af9c

committed Dec 11, 2023

8843e8e2 Browse Files

Add nullability annotations · 55621d1a
```
PiperOrigin-RevId: 589842893
Change-Id: I9657761d1f71c665582406f278c6605f6d382f6d
```
Dmitri Gribenko committed Dec 11, 2023
55621d1a Browse Files

07 Dec, 2023 3 commits

Enable ABSL_HAVE_POSIX_WRITE for Hexagon DSP build. · fad94622
```
PiperOrigin-RevId: 588893303
Change-Id: I3f9278f2f7f0bc4b8903a87cb4a740daf7349755
```
Abseil Team committed Dec 07, 2023
fad94622 Browse Files

Small table growth optimization. · 0ef87fa0

Details:
- In case the table entirely fits into a single group size (`capacity <= Group::kWidth`), the order of elements is not important.
- For growing upto Group::kWidth we rotate control bytes and slots deterministically (using memcpy).
- We also avoid second find_first_non_full right after resize for small growing.
PiperOrigin-RevId: 588825966
Change-Id: I09bd7fd489e3868dcf56c36b436805d08dae7ab5

committed Dec 07, 2023

0ef87fa0 Browse Files

Elide calls to MakeCheckOpString when ABSL_MIN_LOG_LEVEL makes them unnecessary · 026e9fe0

Reduces final binary size by avoiding stream I/O and all its associated
overhead.

PiperOrigin-RevId: 588789394
Change-Id: Ib8653db77aee0dae45e44f4ac72fe7dd87aa2eba

committed Dec 07, 2023

026e9fe0 Browse Files

06 Dec, 2023 5 commits

Fixing a comment to be correct with the current code. · 3abf3298
```
PiperOrigin-RevId: 588530709
Change-Id: Iee28c7693a4802f11e13728e1c28febee8c8576f
```
Abseil Team committed Dec 06, 2023
3abf3298 Browse Files

absl qualify HasAbslStringify in log_message.h. · d84f20a9

This works around a Clang bug, https://github.com/llvm/llvm-project/issues/25168

PiperOrigin-RevId: 588491254
Change-Id: Ia59afae4df45474d6025a2ab1ca487b381c9ee66

committed Dec 06, 2023

d84f20a9 Browse Files

Remove a global destructor in vlog_config.cc · a436472b

Chromium requires no global destructors.

PiperOrigin-RevId: 588466793
Change-Id: Icd255d9fb37667b4f5ce4b2552b70fa53cbf6ecf

committed Dec 06, 2023

a436472b Browse Files

Avoid leaking an unprefixed VLOG_IS_ON transitively though absl_log.h · 8588e7d1

absl_log.h is supposed to be a mirror of log.h that only uses ABSL_
prefixed macros. This change adds ABSL_VLOG_IS_ON to absl_vlog_is_on.h
and uses it in the implementation of VLOG. VLOG_IS_ON is then only
exported though vlog_is_on.h.

PiperOrigin-RevId: 588435577
Change-Id: Ifa9193afa0b782194b64447f4fedfaf24b72c95a

committed Dec 06, 2023

8588e7d1 Browse Files

Move vlog_config to the internal directory and change the namespace of VLogSite · 9b83dc9f
```
PiperOrigin-RevId: 588403935
Change-Id: I6a3af3c044b887ec65b19390d316cfb3ccdcc853
```
Derek Mauro committed Dec 06, 2023
9b83dc9f Browse Files

05 Dec, 2023 5 commits

Adds support for wchar_t/wchar_t*/std::wstring{_view} arguments to StrFormat(). · 5dc2cc1a
```
This converts to UTF-8 regardless of locale.

PiperOrigin-RevId: 588186076
Change-Id: I2c9598279b413d460e13ad65da2ba421c0b40b83
```
Abseil Team committed Dec 05, 2023
5dc2cc1a Browse Files

Roll-forward: Honor ABSL_MIN_LOG_LEVEL in CHECK_XX, CHECK_STRXX, CHECK_OK, and… · 3e6ecec7

Roll-forward: Honor ABSL_MIN_LOG_LEVEL in CHECK_XX, CHECK_STRXX, CHECK_OK, and the QCHECK flavors of these.

In particular, if ABSL_MIN_LOG_LEVEL exceeds kFatal, these should, upon failure, terminate the program without logging anything. The lack of logging should be visible to the optimizer so that it can strip string literals and stringified variable names from the object file.

Making some edge cases work under Clang required rewriting NormalizeLogSeverity to help make constraints on its return value more obvious to the optimizer.

PiperOrigin-RevId: 588181755
Change-Id: I95db3bae39f8dadb52a307ca3b80775db23de766

committed Dec 05, 2023

3e6ecec7 Browse Files

Fix codegen trunks in `absl/hash/hash_benchmark.cc`. · 71d553b1
```
PiperOrigin-RevId: 588121665
Change-Id: Id057772e426aefe2fe7b2f1e94fd405b97167fed
```
Shahriar Rouf committed Dec 05, 2023
71d553b1 Browse Files

Make `absl::{partial,weak,strong}_ordering` aliases for the `std::` ordering · f845e60a

types when they are available.

This makes them interchangeable in contexts known to be compiled as C++20.
This also makes `absl::` ordering types compatible with `<=>`, allowing to
unconditionally use `absl::` spelling for types but conditionally use `<=>`
when available.

PiperOrigin-RevId: 588085408
Change-Id: I1aa5247f0e31acbb838ee76829b7a13c74b0a94f

committed Dec 05, 2023

f845e60a Browse Files

Add VLOG and friends · 7b6c17e3

These are methods for configurable verbose logging

PiperOrigin-RevId: 588059727
Change-Id: Ib3703edd2493050a5da8b30e88b21adc643b1f7f

committed Dec 05, 2023

7b6c17e3 Browse Files

04 Dec, 2023 1 commit

Remove `absl::weak_equality` and `absl::strong_equality`. · a39d71a8

The corresponding `std` types were removed before C++20 was finalized:
https://wg21.link/P1959R0.

They are unused. The language mechanisms and recommendations changed since they
were originally proposed. In particular:

* An explicitly defaulted `operator==` is defined in terms of memberwise
  `operator==` rather than sibling `operator<=>`.

* An `operator!=` can be implicitly added to an overload set in terms of
  `operator==` rather than `operator<=>`.

* A class which has equality but not ordering defined should provide
  `operator==` rather than `operator<=>`.

PiperOrigin-RevId: 587834267
Change-Id: I2c2513c13f3485b9edc6a345dca4a577d8e65167

committed Dec 04, 2023

a39d71a8 Browse Files

28 Nov, 2023 2 commits
- Avoid #pragma intrinsic(_mm_prefetch) on Arm64EC (and other platforms · 8028a87c
```
without SSE)

Closes #1575

PiperOrigin-RevId: 586009018
Change-Id: Icc34c1201268303dde96bfbb067506b861754b3a
```
  Derek Mauro committed Nov 28, 2023
  8028a87c Browse Files
- `btree_map`: avoid a copy in `map_params::key`. · 0c09fd0f
```
PiperOrigin-RevId: 585892739
Change-Id: I30490dac5826bff2a33d9872f71154d360f9cc0d
```
  Abseil Team committed Nov 28, 2023
  0c09fd0f Browse Files
27 Nov, 2023 1 commit
- Update documentation to reflect best practices (prefer brace initialization) · ac7ec8ea
```
PiperOrigin-RevId: 585691325
Change-Id: Icd18dc0294dfd1e22f9878b628d5e5898fcc8185
```
  Abseil Team committed Nov 27, 2023
  ac7ec8ea Browse Files
22 Nov, 2023 1 commit
- Avoid AbslHashValue for std::filesystem::path when <filesystem> is not included · 2fca6417
```
PiperOrigin-RevId: 584675181
Change-Id: I78c9a29055327c84f1e78b8440221439839a041c
```
  Abseil Team committed Nov 22, 2023
  2fca6417 Browse Files
20 Nov, 2023 1 commit

Make `FlatHashMapPolicy` return `std::true_type` for relocatable objects. · db5c7993

This reduces produced binary size and can trigger even more optimizations in the future.

PiperOrigin-RevId: 584136517
Change-Id: I3854833799f88f28b755ec53132925f0c3d468ab

committed Nov 20, 2023

db5c7993 Browse Files

17 Nov, 2023 3 commits

Respect libc++ config option for disable of filesystem · f393335c

- libc++ throws errors when filesystem is included when disabled

PiperOrigin-RevId: 583474609
Change-Id: I205edc5c508f12b84244912f9acc47308a8ca540

committed Nov 17, 2023

f393335c Browse Files

Provide AbslHashValue for std::filesystem::path in C++17 · 00e087fd

This is somewhat tricky to implement because path equality is not
straightforward. See
https://github.com/abseil/abseil-cpp/pull/1560#issuecomment-1799983471
for discussion.

This re-lands 3bd86026 with a fix
for iOS 13 unavailability of std::filesystem::path.

Roll-forward of 524ebb7e.

Closes #655
Closes #1560

PiperOrigin-RevId: 583365100
Change-Id: Id49735c49d123e0cd6a620a2b5b5a12d94129f94

committed Nov 17, 2023

00e087fd Browse Files

Use absl::NoDestructor for global log sinks. · 8197f8f1
```
PiperOrigin-RevId: 583235586
Change-Id: Ia472b8d6530fd829fed1c07558e152975d9b24ac
```
Abseil Team committed Nov 16, 2023
8197f8f1 Browse Files

16 Nov, 2023 3 commits

Rollback providing AbslHashValue for std::filesystem::path in C++17 · 524ebb7e
```
'path' is unavailable: introduced in iOS 13.0

PiperOrigin-RevId: 583036562
Change-Id: I5aea530d03c3317896c3c15bcf7cb5f9d8bc466a
```
Derek Mauro committed Nov 16, 2023
524ebb7e Browse Files

Provide AbslHashValue for std::filesystem::path in C++17 · 3bd86026

This is somewhat tricky to implement because path equality is not
straightforward. See
https://github.com/abseil/abseil-cpp/pull/1560#issuecomment-1799983471
for discussion.

Closes #655
Closes #1560

PiperOrigin-RevId: 582863821
Change-Id: I03517a7f2003614c027c786abbfb91b6571ab662

committed Nov 15, 2023

3bd86026 Browse Files

Use absl::NoDestructor for global FlagRegistry. · 20f92b10
```
PiperOrigin-RevId: 582861689
Change-Id: Iac257539ab282e9bfdc6d90e86c8da0c0d57b9c9
```
Abseil Team committed Nov 15, 2023
20f92b10 Browse Files

15 Nov, 2023 1 commit

Speed-up absl::Symbolize by ~6x via faster file reads. · aa146013

absl::Symbolize does tons of tiny reads. Speed this up by switching
from lseek+read to a pread, and by reading more data than requested
into a buffer.

A faster absl::Symbolize will be helpful in tests and when printing
stack traces on /threadz etc.

Results for absl::Symbolize benchmark that exercises uncached behavior
of absl::Symbolize:

```
name          old time/op  new time/op  delta
BM_Symbolize  16.4ms ±12%   2.6ms ± 0%  -84.06%  (p=0.001 n=5+9)
```

PiperOrigin-RevId: 582687566
Change-Id: I44caf189d81867f3fd8c050a3100a4b9a8e744d7

committed Nov 15, 2023

aa146013 Browse Files

14 Nov, 2023 4 commits

Fixed a very small typo in the Cord::empty() docstring. · 61ea5d25
```
PiperOrigin-RevId: 582455513
Change-Id: Ic78d14d6dd748420a64e7026ec7f8b967bebbf42
```
Abseil Team committed Nov 14, 2023
61ea5d25 Browse Files
Fix documentation on when SpinLock is async-signal-safe · 67f3af26
```
PiperOrigin-RevId: 582426024
Change-Id: Ic8650de4faff9688f4cb5529c1df9bc752878b5a
```
Abseil Team committed Nov 14, 2023
67f3af26 Browse Files

Don't allow AbslHashValue() to take a C-style array parameter. The · 14158405

current behavior of decaying the array to a pointer and hashing the
pointer can lead to subtle bugs.

The most common potential error is passing a C-string literal. Hashing
the char pointer in those cases is correct only if the string literals
are guaranteed to be deduplicated, which is dangerous to rely on even
if true (and the call sites in header files require deduplication
across translation units). After this change, these call-sites
requires wrapping the literal in absl::string_view.

This is a breaking change for code doing something like
absl::HashOf("string");
Instead, this should be changed to
absl::HashOf(absl::string_view("string"));
PiperOrigin-RevId: 582393585
Change-Id: I3810c07b5b74bf153cb62a7beedce243be5a69ee

committed Nov 14, 2023

14158405 Browse Files

Support AbslStringify in absl Civil Time types. · 4a0255b1
```
PiperOrigin-RevId: 582342910
Change-Id: Iada5420867779ed352d8fb0695ff6d6044acfba2
```
Abseil Team committed Nov 14, 2023
4a0255b1 Browse Files

13 Nov, 2023 2 commits

Partial roll forward of reentrant validation with the validation itself… · 716fa007

Partial roll forward of reentrant validation with the validation itself disabled. This will make it easier to roll back and forwards in the future (if needed) without causing merge conflicts in unrelated code.

PiperOrigin-RevId: 582059046
Change-Id: I66dc6527e7a0b351367b7a391c2d653fe793143f

committed Nov 13, 2023

716fa007 Browse Files

Add new benchmark for integer `StrAppend` · c046692a
```
PiperOrigin-RevId: 582033534
Change-Id: I9af42210f65b40ccd7f55c9a2e0c8387b69760dc
```
Abseil Team committed Nov 13, 2023
c046692a Browse Files

09 Nov, 2023 1 commit
- Roll back due to leak sanitizer reports. · 483a2d59
```
PiperOrigin-RevId: 580726428
Change-Id: I12b0f22c2084aef90bcca67536220a6bb550b57e
```
  Aaron Jacobs committed Nov 08, 2023
  483a2d59 Browse Files
08 Nov, 2023 1 commit
- Use absl::NoDestructor to replace a bespoke optimized implementation · c79e6b3d
```
PiperOrigin-RevId: 580596792
Change-Id: I2f79c9b719e7e95a181b6641e8da191cf0a4d71a
```
  Derek Mauro committed Nov 08, 2023
  c79e6b3d Browse Files