Skip to content

A
abseil-cpp
Switch branch/tag
  1. 01 Aug, 2022 1 commit
    • Fix "unsafe narrowing" warnings in absl, 2/n. · 16af2bbc 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in dirs a-h.)

Bug: chromium:1292951
PiperOrigin-RevId: 464541951
Change-Id: If23b63ccea8e9b730159ff1c7288e9300a40b6bd
      Abseil Team committed
  3. 29 Jul, 2022 1 commit
    • debugging: honour `STRICT_UNWINDING` in RISCV path · dc370a82 
      The changes in d6f96eda enabled handling cases
where the stack may be non-contiguous or not fully symbolicated (e.g. in cases
of alternate signal stacks).  However, it did not properly honour the requests
from the caller to perform a strict unwinding where such frames are terminated
upon the discontinuity.  This repairs that condition.

Hoist the alignment check since that is safe to perform early.

PiperOrigin-RevId: 464160529
Change-Id: Ic65645928ec60c2a3b4844f3abd4fed1b991edab
      Saleem Abdulrasool committed
  5. 28 Jul, 2022 1 commit
    • Fix "unsafe narrowing" warnings in absl, 1/n. · 7f51ef5e 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .h and win32 .inc files.)

Bug: chromium:1292951
PiperOrigin-RevId: 463835431
Change-Id: If8e5f7f651d5cd96035e23e4623bdb08a7fedabe
      Abseil Team committed
  7. 27 Jul, 2022 2 commits
  9. 26 Jul, 2022 2 commits
    • Fix frame pointer alignment check. · b0787ae6 
      The frame pointer sanity check in NextStackFrame() was more restrictive than it is necessary. The frame pointer is used to load the saved link-register and the address for the next stack frame. So it only needs to be 8-byte aligned. The aarch64 ABI does not specify an alignment requirement for the frame point.

PiperOrigin-RevId: 463368519
Change-Id: I473e05181603288f14734fe29013900c7505e201
      Abseil Team committed
    • Fixed sign-conversion warning in code. · 63c9eeca 
      PiperOrigin-RevId: 463214218
Change-Id: I54a37fd9560b480f9eaf0454670eacf875015fe8
      Abseil Team committed
  11. 25 Jul, 2022 1 commit
  13. 22 Jul, 2022 2 commits
  15. 21 Jul, 2022 1 commit
  17. 20 Jul, 2022 2 commits
    • Renamespace absl::raw_logging_internal to absl::raw_log_internal to match… · 2c489bb5 
      Renamespace absl::raw_logging_internal to absl::raw_log_internal to match (upcoming) non-raw logging namespace.

PiperOrigin-RevId: 462213222
Change-Id: I3b9371097b368d55cc86b6106d6dec24ce122762
      Andy Getzendanner committed
    • fix(mutex): safely call snprintf · 68da198e 
      In the PostSynchEvent() function, the pos integer uses an implementation
of snprintf that is fundamentally unsafe: since the return value of
snprintf is the number of characters that would have been written to the
buffer, if an operation reaches the end of the buffer with more than one
character discarded, the return value will be greater than the buffer
size, requiring a check of the buffer's current size.

Signed-off-by: Elijah Conners <business@elijahpepe.com>
      Elijah Conners committed
  19. 19 Jul, 2022 1 commit
    • Check for negative return values from ReadFromOffset · 0c8bd82e 
      In some places, we check if the amount we read is a multiple of some amount we are interested in. However, ReadFromOffset returns -1 when it errors. Certain record sizes can cause ReadFromOffset to cause us to think that we succeeded when we did not.

It also results in confusing messages in logs.

PiperOrigin-RevId: 461798762
Change-Id: I8c9c7f2cea4d1789e95e50833d5405239a47f02e
      David Majnemer committed
  21. 18 Jul, 2022 4 commits
  23. 15 Jul, 2022 2 commits
  25. 14 Jul, 2022 2 commits
  27. 13 Jul, 2022 4 commits
  29. 12 Jul, 2022 4 commits
  31. 11 Jul, 2022 1 commit
  33. 07 Jul, 2022 2 commits
    • Make exponential_distribution_test a bigger test (timeout small -> moderate). · 427d8f57 
      This test indicates it has a 90% chance of timing out at its current 60 second limit.

Stats over 1000 runs: max = 102.5s, min = 40.4s, avg = 71.1s, dev = 11.2s

Note that if you run this test locally from a workstation without flags, it'll take maybe 3 to 5 seconds.  However, the test is run with config of android_arm, which seems to drastically change the execution time.

PiperOrigin-RevId: 459503103
Change-Id: I7b7aaa2db7880370f47d1a83d295a3234f738a18
      Abseil Team committed
    • Move Abseil to C++14 minimum · 97ab3dcf 
      Adds policy checks the raise the minimum C++ version to C++14
and the minimum GCC version to GCC 5

Updates the docs to indicate the C++14 minimum.

PiperOrigin-RevId: 459401288
Change-Id: I18878f0e13001c57e97e26ad7c9a9c9c12c39265
      Derek Mauro committed
  35. 06 Jul, 2022 1 commit
    • Revert commit f4988f5b · 9edef234 
      This seems to have caused some regressions by causing a flaky failure in some
cases.  Revert the change to enable investigation.

PiperOrigin-RevId: 459331687
Change-Id: Iaa4e4bfcb3013a75a2cd72768d980ac5e450f70c
      Saleem Abdulrasool committed
  37. 05 Jul, 2022 1 commit
  39. 30 Jun, 2022 1 commit
    • debugging: account for differences in alternate signal stacks · f4988f5b 
      The alternate signal stack may be sufficiently beyond the esimated frame size
(100k).  If we run into the case that the frame is not in the correct direction
assume that the frames may be non-contiguous due to an alternate signal stack
layout.  In such a case, if we find that there is an alternate stack configured,
ignore the discontiuity (assuming that it is a removable point-wise
discontinuity) and continue the stack unwinding.  This permits us to capture
stack traces in more cases.

PiperOrigin-RevId: 458327775
Change-Id: Ia8b461847401492f72a23ba26601c72e0109402c
      Saleem Abdulrasool committed
  41. 29 Jun, 2022 1 commit
  43. 25 Jun, 2022 1 commit
  45. 24 Jun, 2022 2 commits