Commits · 20230802.rc2 · open / abseil-cpp

07 Aug, 2023 1 commit
- Cherry pick CCTZ fix for MinGW (#1508) · 29bf8085
  Derek Mauro committed Aug 07, 2023
  
  29bf8085 Browse Files
02 Aug, 2023 3 commits
- Apply LTS transformations for 20230802 LTS branch (#1505) · d583a597
  Derek Mauro committed Aug 02, 2023
  
  d583a597 Browse Files
- Update Abseil dependencies · fdf5be11
```
PiperOrigin-RevId: 553199830
Change-Id: Ida9fc1c51a39b8c21ffd34f95de076b1b21369bd
```
  Derek Mauro committed Aug 02, 2023
  fdf5be11 Browse Files
- Rollback of "Speed up StrAppend by up to 4x." · 5d06f796
```
PiperOrigin-RevId: 553158292
Change-Id: I28350321550accd72da2f9f6f5992af311fe4b00
```
  Abseil Team committed Aug 02, 2023
  5d06f796 Browse Files
01 Aug, 2023 8 commits

Implement AbslStringify for crc32c_t in order to support absl::StrFormat natively · e945c8d9
```
PiperOrigin-RevId: 552940359
Change-Id: I925764757404c0c9f2a13ed729190d51f4ac46cf
```
Abseil Team committed Aug 01, 2023
e945c8d9 Browse Files
Changes absl::crc32c_t insertion operator (<<) to return value as 0-padded hex instead of dec · fc1dcc0f
```
PiperOrigin-RevId: 552927211
Change-Id: I0375d60a9df4cdfc694fe8d3b3d790f80fc614a1
```
Abseil Team committed Aug 01, 2023
fc1dcc0f Browse Files

PR #1500: Define MAP_ANONYMOUS if not defined · 5b3b0ed8

Included are additional automated edits by clang-format on import.

Merge d74896699faacc4a1667603e52e72cbdc8006cf6 into 22091f4c

Merging this change closes #1500

COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1500 from ryandesign:MAP_ANONYMOUS d74896699faacc4a1667603e52e72cbdc8006cf6
PiperOrigin-RevId: 552922776
Change-Id: I96a0395cb5e7156d7c7a889491c5d0b4cf755819

committed Aug 01, 2023

5b3b0ed8 Browse Files

raw_hash_set_test: Expect tsan to catch heap-use-after-free on iterators invalidated by rehashing · c66815ac
```
PiperOrigin-RevId: 552901078
Change-Id: I137d01fe87b1bbf591b400305f6f7919982fc1c9
```
Dino Radakovic committed Aug 01, 2023
c66815ac Browse Files
Import of CCTZ from GitHub. · f6acd471
```
PiperOrigin-RevId: 552848883
Change-Id: Ibcf4b59e2ab671d8dd8fddcbc9d74d4c8cd3f0ff
```
Abseil Team committed Aug 01, 2023
f6acd471 Browse Files

InlinedVector: Disable CFI checking on the const GetInlinedData() path · a4771dbd

as well. Some empty cases can trigger this.

See also:
https://clang.llvm.org/docs/ControlFlowIntegrity.html#bad-cast-checking.

PiperOrigin-RevId: 552846765
Change-Id: I6adb3c0c73efec841ffe8fdac4342f641c68ddbe

committed Aug 01, 2023

a4771dbd Browse Files

Speed up StrAppend by up to 4x. · 22091f4c
```
PiperOrigin-RevId: 552802740
Change-Id: I662da1b03bfffb7939b44ea3850566d3c209c6cc
```
Abseil Team committed Aug 01, 2023
22091f4c Browse Files
Remove deprecated function. · d7aae58c
```
PiperOrigin-RevId: 552638642
Change-Id: I6b43289ca10ee9aecd6b848e78471863b22b01d1
```
Abseil Team committed Jul 31, 2023
d7aae58c Browse Files

31 Jul, 2023 3 commits

PR #1498: Fix order of link options in pkg-config files · 407f2fdd

Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1498

In Windows, a few libraries (`dbghelp`, `advapi32`, and `bcrypt`) are added via link options. However, the .pc files produced for pkg-config erroneously include them before the abseil libraries. This can cause undefined references when trying to build against abseil.

This commit swaps the order and adds the custom link options after the abseil dependencies. The following is a list of `.pc` files affected by this and the additional link options used:

* all: `-L${libdir}`
*  `absl_base.pc`: `-ladvapi32`
* `absl_random_internal_seed_material.pc`: `-lbcrypt`
* `absl_symbolize.pc`: `-ldbghelp`

Closes https://github.com/abseil/abseil-cpp/issues/1497

Merge af61f6d5d5fa7b390fc2e009652cd6da68b0fd38 into c9c0fd51

Merging this change closes #1498

COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1498 from stanhu:sh-fix-pc-link-order af61f6d5d5fa7b390fc2e009652cd6da68b0fd38
PiperOrigin-RevId: 552564626
Change-Id: I9d2a6ab99993bb4315dc94eade2cd419f1109c13

committed Jul 31, 2023

407f2fdd Browse Files

PR #1495: CMake: Link CoreFoundation with -framework · 4b6e59a9

Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1495

This fixes https://github.com/abseil/abseil-cpp/issues/1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc01ff45970d2b803ca51421483b423b72b into c9c0fd51

Merging this change closes #1495

COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1495 from daschuer:framework-link-fix f3ff6bc01ff45970d2b803ca51421483b423b72b
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8

committed Jul 31, 2023

4b6e59a9 Browse Files

raw_hash_set_test: Match lowercase "invalid iterator" in death tests · d3ddfaa1
```
PiperOrigin-RevId: 552520562
Change-Id: I5d311871afbc2906894c3b754a503a6abace8ceb
```
Dino Radakovic committed Jul 31, 2023
d3ddfaa1 Browse Files

27 Jul, 2023 2 commits

Refactor raw_hash_set deallocation to pass CommonFields instead of passing the… · c9c0fd51

Refactor raw_hash_set deallocation to pass CommonFields instead of passing the results of a bunch of accessors of CommonFields.

Motivation: this makes it easier to refactor CommonFields to be smaller.
PiperOrigin-RevId: 551616928
Change-Id: I3710443fb156537d716944584bea02f945559e99

committed Jul 27, 2023

c9c0fd51 Browse Files

InlinedVector: Disable CFI checking during the reinterpret_cast on the · 8f4fcc62

heap allocation path. The cast occurs before the memory is initialized.

See also:
https://clang.llvm.org/docs/ControlFlowIntegrity.html#bad-cast-checking.

PiperOrigin-RevId: 551542366
Change-Id: Id5834892c36a5cb8ec095bcfee3e9e31f20c48ae

committed Jul 27, 2023

8f4fcc62 Browse Files

26 Jul, 2023 3 commits

Undefine internal `ABSL_FORMAT_PARSER_INTERNAL_GET_CHAR` macro after usage · 4ff6968d
```
PiperOrigin-RevId: 551287955
Change-Id: Ic77831cec71f6ffe0a4e091baabe932b245269ea
```
Abseil Team committed Jul 26, 2023
4ff6968d Browse Files

Change the API constraints of erase(const_iterator, const_iterator) so that… · 7fc3c7fe

Change the API constraints of erase(const_iterator, const_iterator) so that calling erase(begin(), end()) resets reserved growth.

PiperOrigin-RevId: 551248712
Change-Id: I34755c63e3ee40da4ba7047e0d24eec567d28173

committed Jul 26, 2023

7fc3c7fe Browse Files

InlinedVector: Disable CFI checking on GetInlinedData() · c108cd03

GetInlinedDataUninitialized() is removed. Just use GetInlinedData() in
all cases instead. GetInlinedData() is sometimes used to return
uninitialized memory.  In these cases it is immediately constructed.

This is a followup to 511ad649. See also:
https://clang.llvm.org/docs/ControlFlowIntegrity.html#bad-cast-checking.

PiperOrigin-RevId: 551205766
Change-Id: I4ddb45e29a723ccf6fc7dc203e762f4ad559fc83

committed Jul 26, 2023

c108cd03 Browse Files

25 Jul, 2023 2 commits

InlinedVector: Fix control-flow-inregrity warning when using a class · 511ad649

with a vtable

The code is getting the pointer, then constructing it on the next
line. Using reinterpret_cast on this pointer is legal according to
https://clang.llvm.org/docs/ControlFlowIntegrity.html#bad-cast-checking,
but it flags it anyway. The docs say it might be necessary for
`allocate()`-type APIs, and recommends adding them to an ignorelist.

Also note that std::addressof is removed. It is unnecessary since
inlined_data is a char-array.

PiperOrigin-RevId: 550972834
Change-Id: Ib224cec330bb6bcb770296de6c91881f404ef531

committed Jul 25, 2023

511ad649 Browse Files

Import of CCTZ from GitHub. · ac39cc1e
```
PiperOrigin-RevId: 550964088
Change-Id: I54e4bff1cf72442c34e1668dbe8af9337eb0aa46
```
Abseil Team committed Jul 25, 2023
ac39cc1e Browse Files

21 Jul, 2023 1 commit
- `absl/BUILD.bazel`: Make license comment consistent with other bazel build files · d74b1104
```
PiperOrigin-RevId: 549965642
Change-Id: I708dd56a36d60cbc00564fa789e1cb1ef37f950a
```
  Richard Levasseur committed Jul 21, 2023
  d74b1104 Browse Files
20 Jul, 2023 1 commit

Add a special case for erase(begin(), end()) to reset the control bytes. The… · 9f1dcc70

Add a special case for erase(begin(), end()) to reset the control bytes. The motivation is to avoid potentially expanding the table unnecessarily later.

Note: I prefer doing this as a special case in erase(iterator, iterator) rather than special casing erase(iterator) for size==1 because IIUC that changes the time complexity of erase(iterator) from O(1) to O(N) and in pathological cases, it could change loops from O(N) to O(N^2).
PiperOrigin-RevId: 549661855
Change-Id: I8603324260f51a98809db32f840ff09f25cf2481

committed Jul 20, 2023

9f1dcc70 Browse Files

19 Jul, 2023 1 commit

Rename CommonFields::slots_ptr to slot_array to match the name of the… · 89367c60

Rename CommonFields::slots_ptr to slot_array to match the name of the corresponding function in raw_hash_set.

PiperOrigin-RevId: 549379884
Change-Id: I305745dbea2c15821b2092441c9b4546fc7aabbe

committed Jul 19, 2023

89367c60 Browse Files

18 Jul, 2023 1 commit

Add tests for the "%#04x" pattern · 47d467e4

Verifies that values other than 0 are prepended with "0x", while 0 is printed as "0000".

PiperOrigin-RevId: 549108651
Change-Id: Ib0f87d42066c46f3a5d4b05ca5c9d7ac17be9b66

committed Jul 18, 2023

47d467e4 Browse Files

17 Jul, 2023 2 commits
- Move growth_left to the backing array. · 5be22f98
```
PiperOrigin-RevId: 548794485
Change-Id: Ie82d5f8ad752518ef05b38144ca1e32b21c9def8
```
  Evan Brown committed Jul 17, 2023
  5be22f98 Browse Files
- Add Support for mmap on Qualcomm Hexagon DSP targets. · be85b347
```
PiperOrigin-RevId: 548709037
Change-Id: I6eb03553299265660aa0abc180ae0f197a416ba4
```
  Abseil Team committed Jul 17, 2023
  be85b347 Browse Files
14 Jul, 2023 1 commit

Test that CHECK respects ABSL_MIN_LOG_LEVEL · 59382630

Ensure that the CHECK expression and message are stripped when FATAL is below
ABSL_MIN_LOG_LEVEL.

PiperOrigin-RevId: 548157637
Change-Id: I4308ff7ff75aabebdd2dcefa2771cd7e77112817

committed Jul 14, 2023

59382630 Browse Files

13 Jul, 2023 2 commits
- Use new emscripten_errn to avoid copying strings. · c16a2f43
```
PiperOrigin-RevId: 547895328
Change-Id: If5da952604415fa6ed2402052f80add6c4b7dfb3
```
  Abseil Team committed Jul 13, 2023
  c16a2f43 Browse Files
- Adding sw prefetchers to absl::hash. · b8ebbc2e
```
PiperOrigin-RevId: 547850162
Change-Id: I43208c7fa1eaa2a7acfad5891b80c150ee58c65f
```
  Abseil Team committed Jul 13, 2023
  b8ebbc2e Browse Files
11 Jul, 2023 3 commits

Add a smaller library for string_view so that users can · 1adf896e

depend on string_view without depending on all of
//absl/strings:strings

New code that uses string_view.h should depend on
//absl/strings:string_view (Bazel) or
absl::string_view (CMake) instead.
PiperOrigin-RevId: 547283268
Change-Id: I6006b19605ce377d12c462129dda14251d16e1c1

committed Jul 11, 2023

1adf896e Browse Files

Add a comment to absl/flags/parse.cc indicating that the flags defined there are… · 25800da2

Add a comment to absl/flags/parse.cc indicating that the flags defined there are not intended to be read or set from C++ code.

PiperOrigin-RevId: 547264846
Change-Id: Idd0958f308ec74f907c22cce965fac2e06692e2c

committed Jul 11, 2023

25800da2 Browse Files

Cleanup `//absl/strings/internal/memutil.h` · b2a6c1bc

`memmatch()` is only used in `string_view.cc`, so move it there.
The moving of `memmatch()` to `string_view.cc` decouples `string_view`
from `memutil`, which will allow us to move `string_view` into its
own target in a followup.

The only other function that is used is `memcasecmp()`, so delete
all other functions.

PiperOrigin-RevId: 547238386
Change-Id: Id6fad47dd24191c8e8f26dd923fffa1007c8db4a

committed Jul 11, 2023

b2a6c1bc Browse Files

10 Jul, 2023 2 commits
- Use an allowlist visibility model for //absl/synchronization · 20cf119d
```
PiperOrigin-RevId: 546914671
Change-Id: I6f0419103efdd8125e4027e7d5eec124ca604156
```
  Derek Mauro committed Jul 10, 2023
  20cf119d Browse Files
- Fix a typo of absl::Nonnull in the example comment. · 81b9030e
```
PiperOrigin-RevId: 546897533
Change-Id: I3ad12f252c49e4672a64d00d0107111fdc5b6ac8
```
  Abseil Team committed Jul 10, 2023
  81b9030e Browse Files
08 Jul, 2023 1 commit
- Merge pull request #1485 from bebuch:patch-1 · 7152f9bc
```
PiperOrigin-RevId: 546421283
Change-Id: I44bc6b8fe386cf947fc5c91945d5eca4333fd4ae
```
  Copybara-Service committed Jul 07, 2023
  7152f9bc Browse Files
07 Jul, 2023 1 commit
- enable CMP0141 to allow user CMAKE_MSVC_DEBUG_INFORMATION_FORMAT · c3db8330
  Benjamin Buch committed Jul 07, 2023
  
  c3db8330 Browse Files
06 Jul, 2023 2 commits

Rename `absl::NonNull` to `absl::Nonnull`. · 93ef827f

The current spelling is inconsistent with standard casing rules: "nonnull" is a single word, not two.

PiperOrigin-RevId: 546034114
Change-Id: I04e5a204f4a74ebaa76031dd0b0874ca9cfa902c

committed Jul 06, 2023

93ef827f Browse Files

symbolize_test: Add an indirection for getting the PC from function ptr. · c26cd952

Don't assume that function ptr == PC. Adds a redirection mechanism, GetPCFromFnPtr, and enables more test cases for Emscripten/Wasm.

On many (most?) platforms, the address of a function ptr is the same as its
Program Counter (PC) for the purpose of most things, including symbolization.

In Emscripten WebAssembly, the function ptr is just an index into a table of
functions. However, the name section maps function names to their literal
offsets into a Wasm binary. The WasmOffsetConverter is actually capable of both
indirections, so we can effectively go from function ptr to offset into the
binary (which is typically the "PC" for other Stack dumping things in Wasm,
including `emscripten_pc_get_function`).

More info: https://www.w3.org/TR/wasm-js-api-2/#exported-function-exotic-objects

Also fix Emscripten symbolize handling for `nullptr` now that we have tests for
that.

PiperOrigin-RevId: 546006678
Change-Id: I0d4015ca9035b004158451b36c933cad009184ba

committed Jul 06, 2023

c26cd952 Browse Files