Commits · 3ed4ca1f7f6a32cbfaabb095dcd6a2b81c5a3155 · open / abseil-cpp

15 Nov, 2022 1 commit

Updated documentation on use of %v · 3ed4ca1f

Also updated documentation around FormatSink and PutPaddedString

PiperOrigin-RevId: 488651398
Change-Id: Ic6c586dbb8bea61df841a142f12d22c7e5b03f43

committed Nov 15, 2022

3ed4ca1f Browse Files

14 Nov, 2022 2 commits

Use the correct Bazel copts in crc targets · edbf6628
```
PiperOrigin-RevId: 488373221
Change-Id: I1e30820188cc860ce4df8fddafa04de343ec46af
```
Derek Mauro committed Nov 14, 2022
edbf6628 Browse Files

Run the //absl/time timezone tests with a data dependency on, and a · 4b65075a

matching ${TZDIR} setting for, //absl/time/internal/cctz:zoneinfo.

This eliminates any hidden dependency on /usr/share/zoneinfo, and
enables the upcoming deletion of the embedded internal/zoneinfo.inc
data from //absl/time:test_util.

PiperOrigin-RevId: 488372848
Change-Id: If1c8525b5ca4348cb2fc3b4760819f791b6e9725

committed Nov 14, 2022

4b65075a Browse Files

11 Nov, 2022 2 commits

Stop unnecessary clearing of fields in ~raw_hash_set. · 1b976982

Previously, ~raw_hash_set() would change *this to have the same
representation as an empty hash table. This is unnecessary since
nobody should be touching a destroyed hash table, and prevents future
optimizations/changes that might not be able to preserve this
behavior.

PiperOrigin-RevId: 487899950
Change-Id: I2d4470677bdd411c2e48ef511187e39f4e7fc2f4

committed Nov 11, 2022

1b976982 Browse Files

Fix throw_delegate_test when using libc++ with shared libraries · 3a35cb3d
```
PiperOrigin-RevId: 487707178
Change-Id: Ie8f57a6327a6460ab37566b8b6f56d470f6dd2dc
```
Derek Mauro committed Nov 10, 2022
3a35cb3d Browse Files

10 Nov, 2022 5 commits

CRC: Ensure SupportsArmCRC32PMULL() is defined · 44bb8045

This fixes the build on arm64 macOS.

Note that hardware acceleration is not yet enabled on arm64 when not
running under Linux.

Addresses the report from https://github.com/abseil/abseil-cpp/commit/1687dbf814eceb93de2d93f91b31acaab404091c#commitcomment-89529264

PiperOrigin-RevId: 487655295
Change-Id: I168dfc863c960d0b694b26dfcb85ff0fd0e95a1e

committed Nov 10, 2022

44bb8045 Browse Files

Improve error messages when comparing btree iterators. · 04658377

- Add assertions that the iterators are either (a) from the same container or (b) both default constructed. Standard says: "The domain of == for forward iterators is that of iterators over the same underlying sequence. However, value-initialized iterators may be compared and shall compare equal to other value-initialized iterators of the same type." - [reference](https://eel.is/c++draft/forward.iterators#2).
- Also optimize IsEndIterator a bit.

PiperOrigin-RevId: 487617518
Change-Id: Iefba5c3bc8caa93954671793e6929e22f419c298

committed Nov 10, 2022

04658377 Browse Files

Refactor the throw_delegate test into separate test cases · cc143ed3
```
PiperOrigin-RevId: 487592054
Change-Id: Iff24f6e2a304fbc85843f10417fc3343c41333da
```
Derek Mauro committed Nov 10, 2022
cc143ed3 Browse Files

Replace std::atomic_flag with std::atomic<bool> to avoid the C++20 · b4a4a6b0

deprecation of ATOMIC_FLAG_INIT.

Another option would have been to use macros to only initialize
std::atomic_flag before C++20, but I decided to use one compilation
path instead.

The major difference between std::atomic_flag and std::atomic<bool> is
that the former is guaranteed to be lock-free, but we already assume
std::atomic<bool> is lock-free in many places.

https://en.cppreference.com/w/cpp/atomic/atomic_flag

PiperOrigin-RevId: 487397075
Change-Id: I3f1c539ec8b2ca58547282e69ed73e93243e8efe

committed Nov 09, 2022

b4a4a6b0 Browse Files

Add support for enum types with AbslStringify · db8cd478
```
PiperOrigin-RevId: 487394692
Change-Id: I55e9b57055483dc921e9773c3643ea9be4f9bdf6
```
Abseil Team committed Nov 09, 2022
db8cd478 Browse Files

09 Nov, 2022 3 commits

Release the CRC library · 1687dbf8

This implementation can advantage of hardware acceleration available
on common CPUs when using GCC and Clang. A future update may enable
this on MSVC as well.

PiperOrigin-RevId: 487327024
Change-Id: I99a8f1bcbdf25297e776537e23bd0a902e0818a1

committed Nov 09, 2022

1687dbf8 Browse Files

Improve error messages when comparing swisstable iterators. · 8cfc1500

We check for comparisons of swisstable iterators from different heap allocations, which can indicate either iterators from different containers or that there was a rehash between when the iterators were initialized.

PiperOrigin-RevId: 487304602
Change-Id: I5c596c5ea07948d66e048f99937f9032a630344f

committed Nov 09, 2022

8cfc1500 Browse Files

Auto increase inlined capacity whenever it does not affect class' size. · 66bfca85
```
PiperOrigin-RevId: 487292771
Change-Id: I2454e28fe91017fb2954a4ad194712fcafe893d2
```
Abseil Team committed Nov 09, 2022
66bfca85 Browse Files

08 Nov, 2022 1 commit
- drop an unused dep · 64f00b1f
```
PiperOrigin-RevId: 486867412
Change-Id: Ib54b1acaf1ea57f8f377c87261d7d52e9a48784f
```
  Andy Getzendanner committed Nov 08, 2022
  64f00b1f Browse Files
07 Nov, 2022 3 commits

Factor out the internal helper AppendTruncated, which is used and redefined in a… · 615f2147

Factor out the internal helper AppendTruncated, which is used and redefined in a couple places, plus several more that have yet to be released.

PiperOrigin-RevId: 486759835
Change-Id: Ib1b24f287f856ca38b691fbce7e747f0f5a34626

committed Nov 07, 2022

615f2147 Browse Files

Fix some invalid iterator bugs in btree_test.cc for multi{set,map} emplace{_hint} tests. · d459fe71

Note that multi{set,map}::emplace doesn't specify in which order the new element is inserted if there are equivalent keys in the table, whereas emplace_hint specifies that the new element must be before the hint if possible.
https://en.cppreference.com/w/cpp/container/multiset/emplace
https://en.cppreference.com/w/cpp/container/multiset/emplace_hint

Also refactor to rely on IsAssertEnabled instead of checking for NDEBUG.

PiperOrigin-RevId: 486733450
Change-Id: Ie90d33c584a6caccd8301ad6fc0396234dbbfac4

committed Nov 07, 2022

d459fe71 Browse Files

Force a conservative allocation for pointers to methods in Condition objects. · 4ed8e46f

In order for Condition to work on Microsoft platforms, it has to store pointers to methods that are larger than we usually expect. MSVC pointers to methods from class hierarchies that employ multiple inheritance or virtual inheritance are strictly larger than pointers to methods in class hierarchies that only employ single inheritance.

This change introduces an opaque declaration of a class, which is not fulfilled. This declaration is used to calculate the size of the Condition method pointer allocation. Because the declaration is of unspecified inheritance, the compiler is forced to use a conservatively large allocation, which will thereby accommodate all method pointer sizes.

Because the `method_` and `function_` callbacks are only populated in mutually exclusive conditions, they can be allowed to take up the same space in the Condition object. This change combines the `method_` and `function_` fields and renames the new field to `callback_`. The constructor logic is updated to reflect the new field.

PiperOrigin-RevId: 486701312
Change-Id: If06832cc26f27d91e295183e44dc29440af5f9db

committed Nov 07, 2022

4ed8e46f Browse Files

06 Nov, 2022 1 commit
- Fix a few lint findings in flags' usage.cc · 1ee0ea84
```
PiperOrigin-RevId: 486480813
Change-Id: I05292dd0550dfb4130bbe47eafa96ff5b58c040b
```
  Michael Diamond committed Nov 06, 2022
  1ee0ea84 Browse Files
04 Nov, 2022 2 commits
- Narrow some _MSC_VER checks to not catch clang-cl. · ce1d3484
```
PiperOrigin-RevId: 486227733
Change-Id: If492d715e5758971cf7bd0ccd748b47b1424a3c7
```
  Andy Getzendanner committed Nov 04, 2022
  ce1d3484 Browse Files
- Small cleanups in logging test helpers · 32e928d2
```
PiperOrigin-RevId: 486023797
Change-Id: I0b82754fd40c2d6fb451f304aaf1d795eed8d009
```
  Andy Getzendanner committed Nov 03, 2022
  32e928d2 Browse Files
03 Nov, 2022 4 commits
- Import of CCTZ from GitHub. · 4a98f786
```
PiperOrigin-RevId: 485921596
Change-Id: I453801e3d7b4a60ecedf173d448c8b6f51cb0b2e
```
  Derek Mauro committed Nov 03, 2022
  4a98f786 Browse Files
- Merge pull request #1287 from GOGOYAO:patch-1 · b45f7e09
```
PiperOrigin-RevId: 485886212
Change-Id: Ic7a710913f8376d07b9bdeb987d007ec04e48465
```
  Copybara-Service committed Nov 03, 2022
  b45f7e09 Browse Files
- Merge pull request #1307 from KindDragon:patch-1 · 34172a0e
```
PiperOrigin-RevId: 485885633
Change-Id: Idfaf6ce22a9421fe05ae38029c8a68b720ce50ba
```
  Copybara-Service committed Nov 03, 2022
  34172a0e Browse Files
- Stop disabling some test warnings that have been fixed · 8542ee6a
```
PiperOrigin-RevId: 485868656
Change-Id: I09d70adc570b6b79a80c29f89601186aab390032
```
  Derek Mauro committed Nov 03, 2022
  8542ee6a Browse Files
02 Nov, 2022 4 commits

Support logging of user-defined types that implement `AbslStringify()` · e6044634

If a user-defined type has `AbslStringify()` defined, it will always be used for logging over `operator<<`.

`HasAbslStringify` now uses the empty class `UnimplementedSink` for its checks instead of `StringifySink` in order to make it work in cases involving other sinks.

PiperOrigin-RevId: 485710377
Change-Id: Ibdd916151c7abc3269c35fbe79b772867f3d25e1

committed Nov 02, 2022

e6044634 Browse Files

Fix MSVC version checking in lifetime_test.cc · d36d20c0
Arkady Shapkin committed Nov 03, 2022

d36d20c0 Browse Files

Eliminate span_internal::Min in favor of std::min, since Min conflicts with a… · 1649c037

Eliminate span_internal::Min in favor of std::min, since Min conflicts with a macro in a third-party library.

PiperOrigin-RevId: 485653193
Change-Id: I0615ceb9ea3e1533a989470e7c9863c86b70698b

committed Nov 02, 2022

1649c037 Browse Files

Fix -Wimplicit-int-conversion. · a87df8e9
```
PiperOrigin-RevId: 485575914
Change-Id: If1752252e3cc2f91dc3c171382c9fb3a4def0377
```
Abseil Team committed Nov 02, 2022
a87df8e9 Browse Files

01 Nov, 2022 2 commits

Improve error messages when dereferencing invalid swisstable iterators. · 0064d9db

- Separate the failure cases into different assertions: end/default constructed vs rehashed or erased.
- Update the assertion error for AssertIsValid to not mention the end iterator case because end iterators are considered valid by AssertIsValid.
- Also fix an out-of-date comment for skip_empty_or_deleted.

PiperOrigin-RevId: 485402559
Change-Id: I593056abdc6c3565d0396fb885923fef643bf4e4

committed Nov 01, 2022

0064d9db Browse Files

Cord: Avoid leaking a node if SetExpectedChecksum() is called on an · 2b403ec7
```
empty cord twice in a row.

PiperOrigin-RevId: 485367641
Change-Id: I6605ff25acbcef7c40b68e15a8888076a2da63be
```
Derek Mauro committed Nov 01, 2022
2b403ec7 Browse Files

31 Oct, 2022 4 commits

Add a warning about extract invalidating iterators (not just the iterator of the… · d819278a

Add a warning about extract invalidating iterators (not just the iterator of the element being extracted).

PiperOrigin-RevId: 485120182
Change-Id: Ic54d538721678bed0a748dacbf33c319e62b93b8

committed Oct 31, 2022

d819278a Browse Files

CMake: installed artifacts reflect the compiled ABI · ea882fb7

In a previous change, I forgot to fix the DLLs to
also set the target_compile_features() as needed.

Some amount of refactoring to expose the necessary
variables and functions in AbseilDll.cmake

Fixes #1116

PiperOrigin-RevId: 485101834
Change-Id: I5cd0eff9e20c0ddf48c364f917e40d66df0aac17

committed Oct 31, 2022

ea882fb7 Browse Files

Import of CCTZ from GitHub. · f5fd4cc7
```
PiperOrigin-RevId: 485070787
Change-Id: Ie62021eaf84f5a43e8943d3167e98e3986fcf5a6
```
Abseil Team committed Oct 31, 2022
f5fd4cc7 Browse Files
Import of CCTZ from GitHub. · 37a1aa00
```
PiperOrigin-RevId: 485054062
Change-Id: Ieafa217b562548f8bb8dc6fc4e1e414f8ede0579
```
Abseil Team committed Oct 31, 2022
37a1aa00 Browse Files

28 Oct, 2022 2 commits
- Support empty Cords with an expected checksum · 1db72eb0
```
PiperOrigin-RevId: 484578104
Change-Id: Ie4be3e4de27dc28d88395e16fd075fb10ab7a302
```
  Derek Mauro committed Oct 28, 2022
  1db72eb0 Browse Files
- Move internal details from one source file to another more appropriate source · fd9fbe74
```
file.

PiperOrigin-RevId: 484419458
Change-Id: Ic2c1afa1a3434ac071c01ae2e6c75dee41b1f069
```
  Andy Soffer committed Oct 27, 2022
  fd9fbe74 Browse Files
27 Oct, 2022 2 commits

Removes `PutPaddedString()` function · 82794003

This function is unnecessary as it was originally used to support modifiers with `absl::StrFormat()`. This functionality is irrelevant to `absl::StrCat()`.

PiperOrigin-RevId: 484339246
Change-Id: I8c4a0ee01b30aee7a83f6ab54e5465465cc9cc56

committed Oct 27, 2022

82794003 Browse Files

Return uint8_t from CappedDamerauLevenshteinDistance. · 1b6a9e95
```
PiperOrigin-RevId: 484181180
Change-Id: I00206c1506a25dca5555261d6500c1e54368a368
```
Abseil Team committed Oct 27, 2022
1b6a9e95 Browse Files

26 Oct, 2022 2 commits
- Remove the unknown CMAKE_SYSTEM_PROCESSOR warning when configuring · bc097314
```
ABSL_RANDOM_RANDEN_COPTS

Everything works fine when this is empty

Fixes #1301

PiperOrigin-RevId: 484014466
Change-Id: I2fa96d845320f23063e1e86ee2df3ac14bd44012
```
  Derek Mauro committed Oct 26, 2022
  bc097314 Browse Files
- Enforce Visual Studio 2017 (MSVC++ 15.0) minumum · 46913216
```
PiperOrigin-RevId: 483972593
Change-Id: I5358871cdf825bbfae65bf9f5872c4fd56005fb7
```
  Derek Mauro committed Oct 26, 2022
  46913216 Browse Files