Commits · 68be7315913c8ef8a791a0fb60d98e98787d88b6 · open / abseil-cpp

20 May, 2023 1 commit

Rename ABSL_*_IMPL macros to match the other ABSL_LOG_INTERNAL_* macros and to… · 68be7315

Rename ABSL_*_IMPL macros to match the other ABSL_LOG_INTERNAL_* macros and to make sure it's clear that they're internal.

Also rename the log and check test files from .h to .inc per https://google.github.io/styleguide/cppguide.html#Self_contained_Headers.

PiperOrigin-RevId: 533603350
Change-Id: Iad5d8b683e33b63784cc8e64b84da09f5fc3bf1e

committed May 19, 2023

68be7315 Browse Files

19 May, 2023 2 commits

Optimize absl::StrCat for integers · 15d26cdd

Previous implementation used a lookup table of 200 bytes which, if not in L1 cache, could cause memory stalls and consumes 3-4 cache lines. This is suboptimal in real world scenarious. We are going to use a purely scalar version of merging 2/4/8 bytes together.

PiperOrigin-RevId: 533576619
Change-Id: Icd730d18536f7eb35979b62582f6edf86b786019

committed May 19, 2023

15d26cdd Browse Files

Import of CCTZ from GitHub. · aaf81ec8
```
PiperOrigin-RevId: 533455360
Change-Id: Ia95b225f8c186a831801f1ee008d7a5c0fff544b
```
Derek Mauro committed May 19, 2023
aaf81ec8 Browse Files

18 May, 2023 1 commit
- Merge pull request #1448 from glandium:clang · f6f65f9b
```
PiperOrigin-RevId: 533121605
Change-Id: I82390045985db5db56e93c40eae24cdcd93e3ab4
```
  Copybara-Service committed May 18, 2023
  f6f65f9b Browse Files
17 May, 2023 2 commits

Use UB impl of launder on when using clang < 8 and c++17 · 486db28a

libstdc++'s definition of std::launder places it behind a check for
__builtin_launder, which is not available before clang 8.

Fixes: #1309

committed May 18, 2023

486db28a Browse Files

Add compiler deprecation warnings for absl::ConvertDateTime() and absl::FromDateTime(). · 07e8b2a1

These have been marked deprecated in the comments for some time,
(since f340f773) but the warnings
were never enabled.

A warning suppression is enabled for Abseil code so that when we
declare types in our code, we don't get a warning.

PiperOrigin-RevId: 532891102
Change-Id: Ife0c5696a061ea44769e02869e4e3d1196e86f9d

committed May 17, 2023

07e8b2a1 Browse Files

16 May, 2023 1 commit
- Add non-public API for internal users · c8b33b01
```
PiperOrigin-RevId: 532553508
Change-Id: I813841ff3e5085b64c9b02ca41897bf7f6a8570e
```
  Eric Fiselier committed May 16, 2023
  c8b33b01 Browse Files
15 May, 2023 3 commits

Merge pull request #1290 from jun-sheaf:patch-1 · abe63eb9
```
PiperOrigin-RevId: 532199109
Change-Id: I5a2a96b9c8b52feb0107d912b0011911fc1f0f4c
```
Copybara-Service committed May 15, 2023
abe63eb9 Browse Files

Mutex: Remove the deprecated absl::RegisterSymbolizer() hook · 34dd639a

absl::RegisterSymbolizer() has been deprecated for 5 years.
It is being removed following our compatibility policy.
<https://abseil.io/about/compatibility>
PiperOrigin-RevId: 532174866
Change-Id: Id5c3b86698e389099d3d707c4e57f30f1f155d2e

committed May 15, 2023

34dd639a Browse Files

Merge pull request #1115 from h-vetinari:dll_targets · c15196ee
```
PiperOrigin-RevId: 532174747
Change-Id: I39dc6d5c369e8bfbdde5c826836e42f5baa69dc5
```
Copybara-Service committed May 15, 2023
c15196ee Browse Files

13 May, 2023 1 commit
- fix some missing ABSL_INTERNAL_DLL_TARGETS for shared builds · df283a20
  H. Vetinari committed May 13, 2023
  
  df283a20 Browse Files
12 May, 2023 1 commit

Fixed Windows DLL builds of test targets · 3aa3377e

This is a heavily modified version of
https://github.com/abseil/abseil-cpp/pull/1445,
which adds some missing test libraries to the test DLL.

Unlike #1445, this change moves several global variables out of
headers that did not need to be in headers.

For instance, cord_btree_exhaustive_validation was a global
defined/declared in cord_internal, but only used in cord_rep_btree
and its test.

cordz_handle defined a queue in its header even though it wasn't needed,
which also led to ODR problems.

The Spinlock used in CordzHandle is replaced with a Mutex. This was
originally a Mutex, but Chromium asked us to change it to a Spinlock
to avoid a static initializer. After this change, the static
initializer is no longer an issue.

#1407

PiperOrigin-RevId: 531516991
Change-Id: I0e431a193698b20ba03fac6e414c26f153f330a7

committed May 12, 2023

3aa3377e Browse Files

11 May, 2023 1 commit
- Remove ABSL_HARDENING_ASSERT in AnyInvocable to avoid performance impact in optimized builds · 2526926b
```
PiperOrigin-RevId: 531301442
Change-Id: Ib5a67f827bf89a66a0a8d24d3191f278566af6c8
```
  Abseil Team committed May 11, 2023
  2526926b Browse Files
10 May, 2023 1 commit
- YuleSimon/SkewedLow: Cleanup/move benchmarks and overload tests. · 67f9650c
```
PiperOrigin-RevId: 530999471
Change-Id: Ifca68cd53be629088244eaa3560d43fd81090747
```
  Laramie Leavitt committed May 10, 2023
  67f9650c Browse Files
09 May, 2023 1 commit

Stop moving an absl::FunctionRef, since the class isn't movable, it · b19ec98a

will just be a copy anyway. Also remove the typedef so that it is
clear from the type at the callsite that moving it isn't necessary.

Fixes #1443

PiperOrigin-RevId: 530596294
Change-Id: I58ffc370bbccc0816bca4c4f85c3bb12c7ee2eb2

committed May 09, 2023

b19ec98a Browse Files

08 May, 2023 4 commits
- Add semicolon at the end of the line on code example · 41aecd02
```
PiperOrigin-RevId: 530445615
Change-Id: I0c112773e7f42989840cb8b915167ade8833ef73
```
  Abseil Team committed May 08, 2023
  41aecd02 Browse Files
- For Bazel builds, mark some of the low-level tests that are dependent · 4aa4f331
```
on timing as flaky.

This will run them up to 3 times (in the default configuration) and only
consider the test failed if it fails each time.

PiperOrigin-RevId: 530348477
Change-Id: Ib77bd8a166828b82a1b49ee5ef2e8321752e51d0
```
  Derek Mauro committed May 08, 2023
  4aa4f331 Browse Files
- Add missing dependency on dynamic_annotations to stacktrace, which is needed in some of the · 2662ae4a
```
builds.

PiperOrigin-RevId: 530308301
Change-Id: I7c885156e14d9c8c444c7c6f8d38e7aaac7c01a7
```
  Abseil Team committed May 08, 2023
  2662ae4a Browse Files
- Nop change. · 7e22b302
```
PiperOrigin-RevId: 530238518
Change-Id: I2bfca582c0734f7e6943c5359730a2857809e2d2
```
  Abseil Team committed May 08, 2023
  7e22b302 Browse Files
05 May, 2023 1 commit

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · 419b54d4

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming (attempt #2 after internal fix)

PiperOrigin-RevId: 529796927
Change-Id: I755b7d907f96f4a05d01620503bf0862ce35e847

committed May 05, 2023

419b54d4 Browse Files

04 May, 2023 4 commits
- Breaks internal code · f39f340c
```
PiperOrigin-RevId: 529514670
Change-Id: Ia9a19da52f58c91d5131c2a17308a7a322db2714
```
  Abseil Team committed May 04, 2023
  f39f340c Browse Files
- Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · b2abe7ad
```
Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming

PiperOrigin-RevId: 529484669
Change-Id: I9889a9f7a7fa7dc6ef8c731f1b583a74e6afd2cf
```
  Dino Radakovic committed May 04, 2023
  b2abe7ad Browse Files
- Add tests for btrees in which slot_type is overaligned and slot_type is equal to field_type. · 3d604bc6
```
Also do some minor refactoring in btree.h.

PiperOrigin-RevId: 529460378
Change-Id: I278833ada93bbb7652e149fceed08ce3485e4312
```
  Evan Brown committed May 04, 2023
  3d604bc6 Browse Files
- Add lifetimebound attribute to more Abseil container methods and remove them from internal ones. · 25852951
```
PiperOrigin-RevId: 529423722
Change-Id: Ib1cc427299100956c0f2ae6cb5214467ef5a3790
```
  Abseil Team committed May 04, 2023
  25852951 Browse Files
03 May, 2023 2 commits
- Add lifetimebound attribute to some Abseil containers · 20c087a7
```
PiperOrigin-RevId: 529119690
Change-Id: If585274c409e2a344c8d60759da6f8f990023d29
```
  Abseil Team committed May 03, 2023
  20c087a7 Browse Files
- Merge pull request #1441 from Vertexwahn:fix-spelling3 · 3e9f08d9
```
PiperOrigin-RevId: 529086715
Change-Id: Id5462322d5707a1b4475438520fcb70ee7b15450
```
  Copybara-Service committed May 03, 2023
  3e9f08d9 Browse Files
02 May, 2023 4 commits

Fix spelling mistakes · d60c3ac6
Vertexwahn committed May 02, 2023

d60c3ac6 Browse Files

Add pointer-stability validation in btree. · 3132b83a

When we insert a new element, when ASan is enabled, we replace the node that the new element is on in order to try to detect cases of code depending on pointer/reference-stability.

PiperOrigin-RevId: 528826645
Change-Id: Ie5c15c13016a8aa831a0d1edc3ad33c1f5ca4d65

committed May 02, 2023

3132b83a Browse Files

PR #1433: Fix incorrect timespec definition on 32-bit platforms with 64-bit time_t · c0d58db0

Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1433

Some 32-bit configurations may use 64-bit time_t, which leads to different layout of userspace timespec and the one expected by SYS_futex implementation in kernel. In particular the issue occurs when using musl libc which has switched to unconditional 64-bit time_t definition.

This patch introduces custom struct timespec with two longs when old SYS_futex is used to match the kernel timespec definition.
Merge 2eaca415da825b3f31a90f58a35bdef2b6d2a6c5 into f8bf9091

Merging this change closes #1433

COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1433 from olegartys:futex_time64_bug 2eaca415da825b3f31a90f58a35bdef2b6d2a6c5
PiperOrigin-RevId: 528796119
Change-Id: Idaa952f64bd97c6dc9703a8b44deac43e29ff9ae

committed May 02, 2023

c0d58db0 Browse Files

For Bazel builds, mark some of the low-level tests that are dependent · 502769bf

on timing as flaky.

This will run them up to 3 times (in the default configuration) and only
consider the test failed if it fails each time.

PiperOrigin-RevId: 528785128
Change-Id: I4aa5b74aa3a6873c83f2a01734c679351b1cd5d0

committed May 02, 2023

502769bf Browse Files

01 May, 2023 2 commits

Instantiate LogMessage::CopyToEncodedBuffer separately for literals and… · 61cac1fa

Instantiate LogMessage::CopyToEncodedBuffer separately for literals and non-literals to save an instruction at each operator<<(string) callsite.

The operator<<s get inlined at the callsite. The saved instruction is a 'load immediate' to put the StringType argument in a register for passing.

This does make the logging TU slightly larger, but it will be an overall size win for all but the smallest programs. Smaller, faster code at callsites is worth it anyway.

PiperOrigin-RevId: 528569773
Change-Id: Id8185266a975a12ab6f1a553c2c0846261822396

committed May 01, 2023

61cac1fa Browse Files

Merge pull request #1438 from Vertexwahn:fix-spelling · 201c426c
```
PiperOrigin-RevId: 528547013
Change-Id: I9b57ee062ef666d6a34696778ff16a46c5ccb17d
```
Copybara-Service committed May 01, 2023
201c426c Browse Files

28 Apr, 2023 2 commits

Shrink most LOG callsites by one instruction (SysV x86_64 ABI) by dispatching to… · e9a7eea6

Shrink most LOG callsites by one instruction (SysV x86_64 ABI) by dispatching to per-severity constructors and omitting the severity argument.

In that particular ABI, the empty tag structs are NO_CLASS and don't appear in the generated code.

https://godbolt.org/z/crqaPh8Kv

PiperOrigin-RevId: 527989179
Change-Id: I365f11f6ca1de2623690d0a04e6f02f7de82b1fc

committed Apr 28, 2023

e9a7eea6 Browse Files

Introduce IfConstexpr(Else) utilities for use internally in abseil library implementation. · 56c5fc62

These functions are meant to allow for avoiding complex SFINAE pre-C++17.

PiperOrigin-RevId: 527968428
Change-Id: I6524206c9dc50663d7c38abf6d0e8080ca93fc30

committed Apr 28, 2023

56c5fc62 Browse Files

27 Apr, 2023 2 commits
- Fix spelling mistakes · 9c32e50d
  Vertexwahn committed Apr 27, 2023
  
  9c32e50d Browse Files
- trivial: format some files using clang-format · 65109ecd
```
PiperOrigin-RevId: 527598377
Change-Id: I0ae1505db595b7f3a420f2f608c6e02f8800f138
```
  Patrick Xia committed Apr 27, 2023
  65109ecd Browse Files
25 Apr, 2023 1 commit
- Merge pull request #1434 from Vertexwahn:fix-spelling · 8518869e
```
PiperOrigin-RevId: 527066823
Change-Id: Ifa1e9a43c7490b34f9f4dbfa12d3acbed6b49777
```
  Copybara-Service committed Apr 25, 2023
  8518869e Browse Files
24 Apr, 2023 3 commits
- Fix some spelling mistakes · 421a74dc
  Vertexwahn committed Apr 24, 2023
  
  421a74dc Browse Files
- Merge pull request #1416 from AtariDreams:fill · 4ffaea74
```
PiperOrigin-RevId: 526675031
Change-Id: Ib84423ccea2d0183166194a0916a97a7ed32915c
```
  Copybara-Service committed Apr 24, 2023
  4ffaea74 Browse Files
- Mutex: Remove MSVC 2015 workarounds · 0b49f8af
```
PiperOrigin-RevId: 526653332
Change-Id: I0a20d4ac636da3f1a930f96e0cdb9275527e4688
```
  Derek Mauro committed Apr 24, 2023
  0b49f8af Browse Files