Commits · 88cc63ef739d83277b492e881be72e9069fcb1fe · open / abseil-cpp

25 May, 2023 3 commits

Implement a better GetTID on Apple platforms, and a better fallback too. · 88cc63ef

The fallback isn't totally portable, even within POSIX, but we can special case any future platforms where it's not just like this change does for Apple.

PiperOrigin-RevId: 535324103
Change-Id: Ib628925c4946b6c112373678fe37e9bb44259090

committed May 25, 2023

88cc63ef Browse Files

Split absl/hash/hash_test.cc into two files · c154d20a

hash_test.cc leans heavily on INSTANTIATE_TYPED_TEST_SUITE_P, which is
quite memory- and CPU-hungry. Split a few heavyweight tests into a new
hash_instantiated_test.cc, reducing peak RAM consumption (or, on
multicore systems, compilation time).

PiperOrigin-RevId: 535305679
Change-Id: Ic204da0a47c749c3f7db5f902ade8d74ed3043bb

committed May 25, 2023

c154d20a Browse Files

Note that AsyncSignalSafeWriteToStderr preserves errno, and inline one use of it into a lambda. · 4e4b48fa
```
PiperOrigin-RevId: 535245982
Change-Id: I816f60c8b6476536df6836500f01c9a3ad88ddd4
```
Andy Getzendanner committed May 25, 2023
4e4b48fa Browse Files

24 May, 2023 3 commits
- Merge pull request #1454 from niranjan-nilakantan:niranjan-nilakantan/issue1450 · c3e9485b
```
PiperOrigin-RevId: 534841675
Change-Id: I6fbee6f0fe61d8dd51c9c7d93c3b47684a2f4d9f
```
  Copybara-Service committed May 24, 2023
  c3e9485b Browse Files
- fill ABSL_INTERNAL_(DISABLE|RESTORE)_DEPRECATED_DECLARATION_WARNING macro for clang · 7d7defda
```
PiperOrigin-RevId: 534824761
Change-Id: I0ab78fcb211bc5df756fb581761ed8febc3d18fd
```
  Abseil Team committed May 24, 2023
  7d7defda Browse Files
- Merge pull request #1455 from juergbi:solaris · d23adc1c
```
PiperOrigin-RevId: 534619764
Change-Id: Ied99569176766f9708d5504eac9c7024cdcfd64b
```
  Copybara-Service committed May 23, 2023
  d23adc1c Browse Files
23 May, 2023 4 commits

Migrate most RAW_LOGs and RAW_CHECKs in tests to regular LOG and CHECK. · 52747821

The non-RAW_ versions provide better output but weren't available when most of these tests were written.

There are just a couple spots where RAW_ is actually needed, e.g. signal handlers and malloc hooks.

Also fix a couple warnings in layout_test.cc newly surfaced because the optimizer understands CHECK_XX differently than INTERNAL_CHECK.

PiperOrigin-RevId: 534584435
Change-Id: I8d36fa809ffdaae5a3813064bd602cb8611c1613

committed May 23, 2023

52747821 Browse Files

Add a declaration for __cpuid for the IntelLLVM compiler. · 79ca5d7a

Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1452

__cpuid is declared in intrin.h, but is excluded on non-Windows platforms.
We add this declaration to compensate.

Fixes #1358

PiperOrigin-RevId: 534449804
Change-Id: I91027f79d8d52c4da428d5c3a53e2cec00825c13

committed May 23, 2023

79ca5d7a Browse Files

absl/debugging: Fix build on Solaris · 962e8be1
Jürg Billeter committed May 23, 2023

962e8be1 Browse Files

CI: Move the GCC-latest testing to GCC 13.1 on Linux · 9d434709

This includes an upgrade to CMake 3.26.3 and Bazel 6.2.0

This change includes support for both GCC 12 and 13 since we
were only testing GCC 11 before this change.

PiperOrigin-RevId: 534235753
Change-Id: I4183a02469b1c3425c52a31b71fcefe403315a42

committed May 22, 2023

9d434709 Browse Files

22 May, 2023 5 commits
- Rollback of add a declaration for __cpuid for the IntelLLVM compiler. · 830dabdb
```
PiperOrigin-RevId: 534213948
Change-Id: I56b897060b9afe9d3d338756c80e52f421653b55
```
  Abseil Team committed May 22, 2023
  830dabdb Browse Files
- Clone the Clang flags section for IntelLLVM. · 7723d9a1
```
This uses the same flags that Clang based builds use for Windows/Linux.

A future change will add floating point related flags and some warning
suppressions.  So, we clone the section rather than just change the check
at line 77.

Fixes #1450
```
  Niranjan Nilakantan committed May 22, 2023
  7723d9a1 Browse Files
- Merge pull request #1452 from niranjan-nilakantan:niranjan-nilakantan/issue1358 · 051aa980
```
PiperOrigin-RevId: 534179290
Change-Id: I9ad24518cc6a336fbaf602269fb01319491c8b60
```
  Copybara-Service committed May 22, 2023
  051aa980 Browse Files
- Import of CCTZ from GitHub. · 02d1f5e1
```
PiperOrigin-RevId: 534150392
Change-Id: I4c0c111202178031e08d9edad3a4501800d924f0
```
  Abseil Team committed May 22, 2023
  02d1f5e1 Browse Files
- Fix endianess in FastIntToBuffer · 25d7c2ae
```
PiperOrigin-RevId: 534117706
Change-Id: Id48f1538e71d30286675eb32c9fb3e6f47774aa8
```
  Abseil Team committed May 22, 2023
  25d7c2ae Browse Files
20 May, 2023 1 commit

Rename ABSL_*_IMPL macros to match the other ABSL_LOG_INTERNAL_* macros and to… · 68be7315

Rename ABSL_*_IMPL macros to match the other ABSL_LOG_INTERNAL_* macros and to make sure it's clear that they're internal.

Also rename the log and check test files from .h to .inc per https://google.github.io/styleguide/cppguide.html#Self_contained_Headers.

PiperOrigin-RevId: 533603350
Change-Id: Iad5d8b683e33b63784cc8e64b84da09f5fc3bf1e

committed May 19, 2023

68be7315 Browse Files

19 May, 2023 3 commits

Optimize absl::StrCat for integers · 15d26cdd

Previous implementation used a lookup table of 200 bytes which, if not in L1 cache, could cause memory stalls and consumes 3-4 cache lines. This is suboptimal in real world scenarious. We are going to use a purely scalar version of merging 2/4/8 bytes together.

PiperOrigin-RevId: 533576619
Change-Id: Icd730d18536f7eb35979b62582f6edf86b786019

committed May 19, 2023

15d26cdd Browse Files

Import of CCTZ from GitHub. · aaf81ec8
```
PiperOrigin-RevId: 533455360
Change-Id: Ia95b225f8c186a831801f1ee008d7a5c0fff544b
```
Derek Mauro committed May 19, 2023
aaf81ec8 Browse Files
Add a declaration for __cpuid for the IntelLLVM compiler. · bd748714
```
__cpuid is declared in intrin.h, but is "excluded" on non-Windows
platforms.
We add this declaration to compensate.

Fixes #1358
```
Niranjan Nilakantan committed May 18, 2023
bd748714 Browse Files

18 May, 2023 1 commit
- Merge pull request #1448 from glandium:clang · f6f65f9b
```
PiperOrigin-RevId: 533121605
Change-Id: I82390045985db5db56e93c40eae24cdcd93e3ab4
```
  Copybara-Service committed May 18, 2023
  f6f65f9b Browse Files
17 May, 2023 2 commits

Use UB impl of launder on when using clang < 8 and c++17 · 486db28a

libstdc++'s definition of std::launder places it behind a check for
__builtin_launder, which is not available before clang 8.

Fixes: #1309

committed May 18, 2023

486db28a Browse Files

Add compiler deprecation warnings for absl::ConvertDateTime() and absl::FromDateTime(). · 07e8b2a1

These have been marked deprecated in the comments for some time,
(since f340f773) but the warnings
were never enabled.

A warning suppression is enabled for Abseil code so that when we
declare types in our code, we don't get a warning.

PiperOrigin-RevId: 532891102
Change-Id: Ife0c5696a061ea44769e02869e4e3d1196e86f9d

committed May 17, 2023

07e8b2a1 Browse Files

16 May, 2023 1 commit
- Add non-public API for internal users · c8b33b01
```
PiperOrigin-RevId: 532553508
Change-Id: I813841ff3e5085b64c9b02ca41897bf7f6a8570e
```
  Eric Fiselier committed May 16, 2023
  c8b33b01 Browse Files
15 May, 2023 3 commits

Merge pull request #1290 from jun-sheaf:patch-1 · abe63eb9
```
PiperOrigin-RevId: 532199109
Change-Id: I5a2a96b9c8b52feb0107d912b0011911fc1f0f4c
```
Copybara-Service committed May 15, 2023
abe63eb9 Browse Files

Mutex: Remove the deprecated absl::RegisterSymbolizer() hook · 34dd639a

absl::RegisterSymbolizer() has been deprecated for 5 years.
It is being removed following our compatibility policy.
<https://abseil.io/about/compatibility>
PiperOrigin-RevId: 532174866
Change-Id: Id5c3b86698e389099d3d707c4e57f30f1f155d2e

committed May 15, 2023

34dd639a Browse Files

Merge pull request #1115 from h-vetinari:dll_targets · c15196ee
```
PiperOrigin-RevId: 532174747
Change-Id: I39dc6d5c369e8bfbdde5c826836e42f5baa69dc5
```
Copybara-Service committed May 15, 2023
c15196ee Browse Files

13 May, 2023 1 commit
- fix some missing ABSL_INTERNAL_DLL_TARGETS for shared builds · df283a20
  H. Vetinari committed May 13, 2023
  
  df283a20 Browse Files
12 May, 2023 1 commit

Fixed Windows DLL builds of test targets · 3aa3377e

This is a heavily modified version of
https://github.com/abseil/abseil-cpp/pull/1445,
which adds some missing test libraries to the test DLL.

Unlike #1445, this change moves several global variables out of
headers that did not need to be in headers.

For instance, cord_btree_exhaustive_validation was a global
defined/declared in cord_internal, but only used in cord_rep_btree
and its test.

cordz_handle defined a queue in its header even though it wasn't needed,
which also led to ODR problems.

The Spinlock used in CordzHandle is replaced with a Mutex. This was
originally a Mutex, but Chromium asked us to change it to a Spinlock
to avoid a static initializer. After this change, the static
initializer is no longer an issue.

#1407

PiperOrigin-RevId: 531516991
Change-Id: I0e431a193698b20ba03fac6e414c26f153f330a7

committed May 12, 2023

3aa3377e Browse Files

11 May, 2023 1 commit
- Remove ABSL_HARDENING_ASSERT in AnyInvocable to avoid performance impact in optimized builds · 2526926b
```
PiperOrigin-RevId: 531301442
Change-Id: Ib5a67f827bf89a66a0a8d24d3191f278566af6c8
```
  Abseil Team committed May 11, 2023
  2526926b Browse Files
10 May, 2023 1 commit
- YuleSimon/SkewedLow: Cleanup/move benchmarks and overload tests. · 67f9650c
```
PiperOrigin-RevId: 530999471
Change-Id: Ifca68cd53be629088244eaa3560d43fd81090747
```
  Laramie Leavitt committed May 10, 2023
  67f9650c Browse Files
09 May, 2023 1 commit

Stop moving an absl::FunctionRef, since the class isn't movable, it · b19ec98a

will just be a copy anyway. Also remove the typedef so that it is
clear from the type at the callsite that moving it isn't necessary.

Fixes #1443

PiperOrigin-RevId: 530596294
Change-Id: I58ffc370bbccc0816bca4c4f85c3bb12c7ee2eb2

committed May 09, 2023

b19ec98a Browse Files

08 May, 2023 4 commits
- Add semicolon at the end of the line on code example · 41aecd02
```
PiperOrigin-RevId: 530445615
Change-Id: I0c112773e7f42989840cb8b915167ade8833ef73
```
  Abseil Team committed May 08, 2023
  41aecd02 Browse Files
- For Bazel builds, mark some of the low-level tests that are dependent · 4aa4f331
```
on timing as flaky.

This will run them up to 3 times (in the default configuration) and only
consider the test failed if it fails each time.

PiperOrigin-RevId: 530348477
Change-Id: Ib77bd8a166828b82a1b49ee5ef2e8321752e51d0
```
  Derek Mauro committed May 08, 2023
  4aa4f331 Browse Files
- Add missing dependency on dynamic_annotations to stacktrace, which is needed in some of the · 2662ae4a
```
builds.

PiperOrigin-RevId: 530308301
Change-Id: I7c885156e14d9c8c444c7c6f8d38e7aaac7c01a7
```
  Abseil Team committed May 08, 2023
  2662ae4a Browse Files
- Nop change. · 7e22b302
```
PiperOrigin-RevId: 530238518
Change-Id: I2bfca582c0734f7e6943c5359730a2857809e2d2
```
  Abseil Team committed May 08, 2023
  7e22b302 Browse Files
05 May, 2023 1 commit

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · 419b54d4

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming (attempt #2 after internal fix)

PiperOrigin-RevId: 529796927
Change-Id: I755b7d907f96f4a05d01620503bf0862ce35e847

committed May 05, 2023

419b54d4 Browse Files

04 May, 2023 4 commits
- Breaks internal code · f39f340c
```
PiperOrigin-RevId: 529514670
Change-Id: Ia9a19da52f58c91d5131c2a17308a7a322db2714
```
  Abseil Team committed May 04, 2023
  f39f340c Browse Files
- Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · b2abe7ad
```
Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming

PiperOrigin-RevId: 529484669
Change-Id: I9889a9f7a7fa7dc6ef8c731f1b583a74e6afd2cf
```
  Dino Radakovic committed May 04, 2023
  b2abe7ad Browse Files
- Add tests for btrees in which slot_type is overaligned and slot_type is equal to field_type. · 3d604bc6
```
Also do some minor refactoring in btree.h.

PiperOrigin-RevId: 529460378
Change-Id: I278833ada93bbb7652e149fceed08ce3485e4312
```
  Evan Brown committed May 04, 2023
  3d604bc6 Browse Files
- Add lifetimebound attribute to more Abseil container methods and remove them from internal ones. · 25852951
```
PiperOrigin-RevId: 529423722
Change-Id: Ib1cc427299100956c0f2ae6cb5214467ef5a3790
```
  Abseil Team committed May 04, 2023
  25852951 Browse Files