Commits · b19ec98accca194511616f789c0a448c2b9d40e7 · open / abseil-cpp

09 May, 2023 1 commit

Stop moving an absl::FunctionRef, since the class isn't movable, it · b19ec98a

will just be a copy anyway. Also remove the typedef so that it is
clear from the type at the callsite that moving it isn't necessary.

Fixes #1443

PiperOrigin-RevId: 530596294
Change-Id: I58ffc370bbccc0816bca4c4f85c3bb12c7ee2eb2

committed May 09, 2023

b19ec98a Browse Files

08 May, 2023 4 commits
- Add semicolon at the end of the line on code example · 41aecd02
```
PiperOrigin-RevId: 530445615
Change-Id: I0c112773e7f42989840cb8b915167ade8833ef73
```
  Abseil Team committed May 08, 2023
  41aecd02 Browse Files
- For Bazel builds, mark some of the low-level tests that are dependent · 4aa4f331
```
on timing as flaky.

This will run them up to 3 times (in the default configuration) and only
consider the test failed if it fails each time.

PiperOrigin-RevId: 530348477
Change-Id: Ib77bd8a166828b82a1b49ee5ef2e8321752e51d0
```
  Derek Mauro committed May 08, 2023
  4aa4f331 Browse Files
- Add missing dependency on dynamic_annotations to stacktrace, which is needed in some of the · 2662ae4a
```
builds.

PiperOrigin-RevId: 530308301
Change-Id: I7c885156e14d9c8c444c7c6f8d38e7aaac7c01a7
```
  Abseil Team committed May 08, 2023
  2662ae4a Browse Files
- Nop change. · 7e22b302
```
PiperOrigin-RevId: 530238518
Change-Id: I2bfca582c0734f7e6943c5359730a2857809e2d2
```
  Abseil Team committed May 08, 2023
  7e22b302 Browse Files
05 May, 2023 1 commit

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · 419b54d4

Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming (attempt #2 after internal fix)

PiperOrigin-RevId: 529796927
Change-Id: I755b7d907f96f4a05d01620503bf0862ce35e847

committed May 05, 2023

419b54d4 Browse Files

04 May, 2023 4 commits
- Breaks internal code · f39f340c
```
PiperOrigin-RevId: 529514670
Change-Id: Ia9a19da52f58c91d5131c2a17308a7a322db2714
```
  Abseil Team committed May 04, 2023
  f39f340c Browse Files
- Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside… · b2abe7ad
```
Make `absl::StatusOr::AssignStatus` public. Recommend against using it outside of generic programming

PiperOrigin-RevId: 529484669
Change-Id: I9889a9f7a7fa7dc6ef8c731f1b583a74e6afd2cf
```
  Dino Radakovic committed May 04, 2023
  b2abe7ad Browse Files
- Add tests for btrees in which slot_type is overaligned and slot_type is equal to field_type. · 3d604bc6
```
Also do some minor refactoring in btree.h.

PiperOrigin-RevId: 529460378
Change-Id: I278833ada93bbb7652e149fceed08ce3485e4312
```
  Evan Brown committed May 04, 2023
  3d604bc6 Browse Files
- Add lifetimebound attribute to more Abseil container methods and remove them from internal ones. · 25852951
```
PiperOrigin-RevId: 529423722
Change-Id: Ib1cc427299100956c0f2ae6cb5214467ef5a3790
```
  Abseil Team committed May 04, 2023
  25852951 Browse Files
03 May, 2023 2 commits
- Add lifetimebound attribute to some Abseil containers · 20c087a7
```
PiperOrigin-RevId: 529119690
Change-Id: If585274c409e2a344c8d60759da6f8f990023d29
```
  Abseil Team committed May 03, 2023
  20c087a7 Browse Files
- Merge pull request #1441 from Vertexwahn:fix-spelling3 · 3e9f08d9
```
PiperOrigin-RevId: 529086715
Change-Id: Id5462322d5707a1b4475438520fcb70ee7b15450
```
  Copybara-Service committed May 03, 2023
  3e9f08d9 Browse Files
02 May, 2023 4 commits

Fix spelling mistakes · d60c3ac6
Vertexwahn committed May 02, 2023

d60c3ac6 Browse Files

Add pointer-stability validation in btree. · 3132b83a

When we insert a new element, when ASan is enabled, we replace the node that the new element is on in order to try to detect cases of code depending on pointer/reference-stability.

PiperOrigin-RevId: 528826645
Change-Id: Ie5c15c13016a8aa831a0d1edc3ad33c1f5ca4d65

committed May 02, 2023

3132b83a Browse Files

PR #1433: Fix incorrect timespec definition on 32-bit platforms with 64-bit time_t · c0d58db0

Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1433

Some 32-bit configurations may use 64-bit time_t, which leads to different layout of userspace timespec and the one expected by SYS_futex implementation in kernel. In particular the issue occurs when using musl libc which has switched to unconditional 64-bit time_t definition.

This patch introduces custom struct timespec with two longs when old SYS_futex is used to match the kernel timespec definition.
Merge 2eaca415da825b3f31a90f58a35bdef2b6d2a6c5 into f8bf9091

Merging this change closes #1433

COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1433 from olegartys:futex_time64_bug 2eaca415da825b3f31a90f58a35bdef2b6d2a6c5
PiperOrigin-RevId: 528796119
Change-Id: Idaa952f64bd97c6dc9703a8b44deac43e29ff9ae

committed May 02, 2023

c0d58db0 Browse Files

For Bazel builds, mark some of the low-level tests that are dependent · 502769bf

on timing as flaky.

This will run them up to 3 times (in the default configuration) and only
consider the test failed if it fails each time.

PiperOrigin-RevId: 528785128
Change-Id: I4aa5b74aa3a6873c83f2a01734c679351b1cd5d0

committed May 02, 2023

502769bf Browse Files

01 May, 2023 2 commits

Instantiate LogMessage::CopyToEncodedBuffer separately for literals and… · 61cac1fa

Instantiate LogMessage::CopyToEncodedBuffer separately for literals and non-literals to save an instruction at each operator<<(string) callsite.

The operator<<s get inlined at the callsite. The saved instruction is a 'load immediate' to put the StringType argument in a register for passing.

This does make the logging TU slightly larger, but it will be an overall size win for all but the smallest programs. Smaller, faster code at callsites is worth it anyway.

PiperOrigin-RevId: 528569773
Change-Id: Id8185266a975a12ab6f1a553c2c0846261822396

committed May 01, 2023

61cac1fa Browse Files

Merge pull request #1438 from Vertexwahn:fix-spelling · 201c426c
```
PiperOrigin-RevId: 528547013
Change-Id: I9b57ee062ef666d6a34696778ff16a46c5ccb17d
```
Copybara-Service committed May 01, 2023
201c426c Browse Files

28 Apr, 2023 2 commits

Shrink most LOG callsites by one instruction (SysV x86_64 ABI) by dispatching to… · e9a7eea6

Shrink most LOG callsites by one instruction (SysV x86_64 ABI) by dispatching to per-severity constructors and omitting the severity argument.

In that particular ABI, the empty tag structs are NO_CLASS and don't appear in the generated code.

https://godbolt.org/z/crqaPh8Kv

PiperOrigin-RevId: 527989179
Change-Id: I365f11f6ca1de2623690d0a04e6f02f7de82b1fc

committed Apr 28, 2023

e9a7eea6 Browse Files

Introduce IfConstexpr(Else) utilities for use internally in abseil library implementation. · 56c5fc62

These functions are meant to allow for avoiding complex SFINAE pre-C++17.

PiperOrigin-RevId: 527968428
Change-Id: I6524206c9dc50663d7c38abf6d0e8080ca93fc30

committed Apr 28, 2023

56c5fc62 Browse Files

27 Apr, 2023 2 commits
- Fix spelling mistakes · 9c32e50d
  Vertexwahn committed Apr 27, 2023
  
  9c32e50d Browse Files
- trivial: format some files using clang-format · 65109ecd
```
PiperOrigin-RevId: 527598377
Change-Id: I0ae1505db595b7f3a420f2f608c6e02f8800f138
```
  Patrick Xia committed Apr 27, 2023
  65109ecd Browse Files
25 Apr, 2023 1 commit
- Merge pull request #1434 from Vertexwahn:fix-spelling · 8518869e
```
PiperOrigin-RevId: 527066823
Change-Id: Ifa1e9a43c7490b34f9f4dbfa12d3acbed6b49777
```
  Copybara-Service committed Apr 25, 2023
  8518869e Browse Files
24 Apr, 2023 5 commits

Fix some spelling mistakes · 421a74dc
Vertexwahn committed Apr 24, 2023

421a74dc Browse Files
Merge pull request #1416 from AtariDreams:fill · 4ffaea74
```
PiperOrigin-RevId: 526675031
Change-Id: Ib84423ccea2d0183166194a0916a97a7ed32915c
```
Copybara-Service committed Apr 24, 2023
4ffaea74 Browse Files
Mutex: Remove MSVC 2015 workarounds · 0b49f8af
```
PiperOrigin-RevId: 526653332
Change-Id: I0a20d4ac636da3f1a930f96e0cdb9275527e4688
```
Derek Mauro committed Apr 24, 2023
0b49f8af Browse Files
Adds template specialization for nullptr assertion of absl::AnyInvocable types. · 8bd7178b
```
PiperOrigin-RevId: 526644558
Change-Id: I050162c2c0d667c32f7e11f51201054cca52667d
```
Abseil Team committed Apr 24, 2023
8bd7178b Browse Files

Fix handling of `CHECK` macros in static analysis tools. · 43e07a0e

Currently static analysis tools built using the Clang Dataflow Analysis framework can't prove that code under `switch (0) case 0:` is executed on all paths. The Clang Dataflow Analysis framework should ultimately be improved to handle these cases. In the meantime, to enable the use of such tools in their current state, we add a `default` case back to the `switch` statement in `ABSL_LOG_INTERNAL_STATELESS_CONDITION` to help them understand that the code is executed on all paths.

PiperOrigin-RevId: 526638852
Change-Id: I49490dd477ba777aae2530697b75b583242aebc5

committed Apr 24, 2023

43e07a0e Browse Files

21 Apr, 2023 1 commit

`AbslHashValue()` applied to a C-style array simply decays the array to a… · 70af93e9

`AbslHashValue()` applied to a C-style array simply decays the array to a pointer and hashes that, which is very unlikely to be what the author intended.

PiperOrigin-RevId: 525923741
Change-Id: I876dbde341f0b0642fa3d10e3f67b0b31d0311bf

committed Apr 20, 2023

70af93e9 Browse Files

20 Apr, 2023 3 commits

Support pthread_cond_clockwait() and sem_clockwait() on Android · f8bf9091

for __ANDROID_API__ >= 30

https://android.googlesource.com/platform/bionic/+/69010802d037dbc10377416bd9cc696fa34b9384%5E%21/libc/include/pthread.h

PiperOrigin-RevId: 525815479
Change-Id: I88cd1a06a4f7bb5380ff7c1e6a8f45e2b04b7df8

committed Apr 20, 2023

f8bf9091 Browse Files

Fix flaky test failures. · 9686b7be
```
PiperOrigin-RevId: 525808747
Change-Id: I01aeef6b8558673bf1fc38a948dcecf00300b641
```
Evan Brown committed Apr 20, 2023
9686b7be Browse Files
Minor optimization in btree: avoid redundant stores to node->position when constructing nodes. · bc65499d
```
PiperOrigin-RevId: 525792213
Change-Id: I4386385e6e05d74a4ccc18cea505530e919f0e28
```
Evan Brown committed Apr 20, 2023
bc65499d Browse Files

19 Apr, 2023 2 commits
- Prefer copy_n and fill_n over copy and fill where appropriate. · a26fc02d
```
This lets us avoid having to do the addition manually.
```
  Rose committed Apr 19, 2023
  a26fc02d Browse Files
- Unify std type detection now that older compilers are no longer supported · e85868cb
```
PiperOrigin-RevId: 525462751
Change-Id: Ibd6202cb95e79a48a6b39ccc4b74ead04128eb91
```
  Derek Mauro committed Apr 19, 2023
  e85868cb Browse Files
18 Apr, 2023 3 commits
- Add ABSL_RAW_DLOG and ABSL_RAW_DCHECK macros · fb0debf5
```
PiperOrigin-RevId: 525241200
Change-Id: I8d1536cb813da8b80a978340343b0243a49928f7
```
  Martijn Vels committed Apr 18, 2023
  fb0debf5 Browse Files
- Add configurability of the log Tag value on Android · 2d04ec1d
```
PiperOrigin-RevId: 525178448
Change-Id: I0f35a38f23316b25621148b7fe59becf72bafeff
```
  Abseil Team committed Apr 18, 2023
  2d04ec1d Browse Files
- Add an API to clear the saved LogBacktraceAt location, and call it when setting… · f3618360
```
Add an API to clear the saved LogBacktraceAt location, and call it when setting an empty or invalid flag value.

PiperOrigin-RevId: 525065479
Change-Id: I3c0822db8301e0999b0669394b415df82edd445f
```
  Andy Getzendanner committed Apr 18, 2023
  f3618360 Browse Files
14 Apr, 2023 3 commits

Optional: Remove workaround for lack of support for inheriting constructors · 387e1bf5
```
PiperOrigin-RevId: 524368346
Change-Id: I68b57a1abc8d805aa5cb4b45c5d7449ade231579
```
Derek Mauro committed Apr 14, 2023
387e1bf5 Browse Files
Span: Remove MSVC 2015 workaround · 2ed3e75e
```
PiperOrigin-RevId: 524347923
Change-Id: I4538eb8d5d6e8befbeb8ab992b0ad44dd8f4f00c
```
Derek Mauro committed Apr 14, 2023
2ed3e75e Browse Files

Reland "Get rid of tail padding within `absl::Duration`. This reduces memory… · bce5bec5

Reland "Get rid of tail padding within `absl::Duration`. This reduces memory usage needs when storing duration in containers (e.g. `vector<absl::Duration>` uses 25% less memory), and allows classes with `absl::Duration` fields to fit other stuff in memory previously used by tail padding (e.g. `std::optional<absl::Duration>` is now 16 bytes instead of 24)."

PiperOrigin-RevId: 524256689
Change-Id: Ibf40d9e5411020179fa34c972349c7b58aa9d908

committed Apr 14, 2023

bce5bec5 Browse Files