Skip to content

A
abseil-cpp
Switch branch/tag
  1. 17 Aug, 2022 2 commits
    • Fix "unsafe narrowing" warnings in absl, 5/n. · fcfc7a6d 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in strings/internal/.)

Bug: chromium:1292951
PiperOrigin-RevId: 468215101
Change-Id: I07fa487bcf2cf62d403489c3be7a5997cdef8987
      Abseil Team committed
    • Fix "unsafe narrowing" warnings in absl, 4/n. · 934f6138 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in strings/, except /internal/.)

Bug: chromium:1292951
PiperOrigin-RevId: 468205572
Change-Id: Ifce3f1a7a4b2b2c359bf7700a11279bebfef8a15
      Abseil Team committed
  3. 16 Aug, 2022 3 commits
  5. 15 Aug, 2022 1 commit
  7. 12 Aug, 2022 3 commits
  9. 11 Aug, 2022 4 commits
  11. 10 Aug, 2022 3 commits
  13. 09 Aug, 2022 1 commit
  15. 05 Aug, 2022 3 commits
  17. 04 Aug, 2022 4 commits
    • debugging: handle alternate signal stacks better on RISCV · 9ab9e487 
      In the case that we are unwinding with context, if the retreived frame pointer
matches the signal context, assume that the value is valid and do not perform
confidence checks.  In any other case, continue to perform some validation to
avoid returning an incorrect frame pointer.

Given that the VDSO path is currently untested, remove the code to simplify the
logic in the frame walking.

PiperOrigin-RevId: 465360612
Change-Id: Iac656012182a12814bafecf20225ba68b90b4db1
      Saleem Abdulrasool committed
    • Revert change "Fix "unsafe narrowing" warnings in absl, 4/n.". · 4b551344 
      The change breaks existing code by changing the return type of absl::bit_width.

PiperOrigin-RevId: 465295951
Change-Id: Id4ce7c2ac3699ce22aa2b4851a949f9e0104a3d7
      Thomas Köppe committed
    • Fix "unsafe narrowing" warnings in absl, 3/n. · 751ade00 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in dirs n-t, except string.)

Bug: chromium:1292951
PiperOrigin-RevId: 465287204
Change-Id: I0fe98ff78bf3c08d86992019eb626755f8b6803e
      Abseil Team committed
    • Fix "unsafe narrowing" warnings in absl, 4/n. · 07360899 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in strings/, except /internal/.)

Bug: chromium:1292951
PiperOrigin-RevId: 465285043
Change-Id: I37e9d1b4c4e9aa655b720da1467927af2aba995e
      Abseil Team committed
  19. 01 Aug, 2022 1 commit
    • Fix "unsafe narrowing" warnings in absl, 2/n. · 16af2bbc 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .cc files in dirs a-h.)

Bug: chromium:1292951
PiperOrigin-RevId: 464541951
Change-Id: If23b63ccea8e9b730159ff1c7288e9300a40b6bd
      Abseil Team committed
  21. 29 Jul, 2022 1 commit
    • debugging: honour `STRICT_UNWINDING` in RISCV path · dc370a82 
      The changes in d6f96eda enabled handling cases
where the stack may be non-contiguous or not fully symbolicated (e.g. in cases
of alternate signal stacks).  However, it did not properly honour the requests
from the caller to perform a strict unwinding where such frames are terminated
upon the discontinuity.  This repairs that condition.

Hoist the alignment check since that is safe to perform early.

PiperOrigin-RevId: 464160529
Change-Id: Ic65645928ec60c2a3b4844f3abd4fed1b991edab
      Saleem Abdulrasool committed
  23. 28 Jul, 2022 1 commit
    • Fix "unsafe narrowing" warnings in absl, 1/n. · 7f51ef5e 
      Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare

(This specific CL focuses on .h and win32 .inc files.)

Bug: chromium:1292951
PiperOrigin-RevId: 463835431
Change-Id: If8e5f7f651d5cd96035e23e4623bdb08a7fedabe
      Abseil Team committed
  25. 27 Jul, 2022 2 commits
  27. 26 Jul, 2022 2 commits
    • Fix frame pointer alignment check. · b0787ae6 
      The frame pointer sanity check in NextStackFrame() was more restrictive than it is necessary. The frame pointer is used to load the saved link-register and the address for the next stack frame. So it only needs to be 8-byte aligned. The aarch64 ABI does not specify an alignment requirement for the frame point.

PiperOrigin-RevId: 463368519
Change-Id: I473e05181603288f14734fe29013900c7505e201
      Abseil Team committed
    • Fixed sign-conversion warning in code. · 63c9eeca 
      PiperOrigin-RevId: 463214218
Change-Id: I54a37fd9560b480f9eaf0454670eacf875015fe8
      Abseil Team committed
  29. 25 Jul, 2022 1 commit
  31. 22 Jul, 2022 2 commits
  33. 21 Jul, 2022 1 commit
  35. 20 Jul, 2022 2 commits
    • Renamespace absl::raw_logging_internal to absl::raw_log_internal to match… · 2c489bb5 
      Renamespace absl::raw_logging_internal to absl::raw_log_internal to match (upcoming) non-raw logging namespace.

PiperOrigin-RevId: 462213222
Change-Id: I3b9371097b368d55cc86b6106d6dec24ce122762
      Andy Getzendanner committed
    • fix(mutex): safely call snprintf · 68da198e 
      In the PostSynchEvent() function, the pos integer uses an implementation
of snprintf that is fundamentally unsafe: since the return value of
snprintf is the number of characters that would have been written to the
buffer, if an operation reaches the end of the buffer with more than one
character discarded, the return value will be greater than the buffer
size, requiring a check of the buffer's current size.

Signed-off-by: Elijah Conners <business@elijahpepe.com>
      Elijah Conners committed
  37. 19 Jul, 2022 1 commit
    • Check for negative return values from ReadFromOffset · 0c8bd82e 
      In some places, we check if the amount we read is a multiple of some amount we are interested in. However, ReadFromOffset returns -1 when it errors. Certain record sizes can cause ReadFromOffset to cause us to think that we succeeded when we did not.

It also results in confusing messages in logs.

PiperOrigin-RevId: 461798762
Change-Id: I8c9c7f2cea4d1789e95e50833d5405239a47f02e
      David Majnemer committed
  39. 18 Jul, 2022 2 commits