Benchmarks: https://pastebin.com/tZ7dr67W. Works well especially on smaller ranges. After a week on spending optimizing NEON SIMD where I almost managed to make hash tables work with NEON SIMD without performance hits (still 1 cycle to optimize and I gave up a little), I found an interesting optimization for aarch64 to use cls instruction (count leading sign bits). The loop has a property that ctrl_ group is not matched against count when the first slot is empty or deleted. ``` void skip_empty_or_deleted() { while (IsEmptyOrDeleted(*ctrl_)) { uint32_t shift = Group{ctrl_}.CountLeadingEmptyOrDeleted(); ctrl_ += shift; slot_ += shift; } ... } ``` However, `kEmpty` and `kDeleted` have format of `1xxxxxx0` and `~ctrl & (ctrl >> 7)` always sets the lowest bit to 1. In naive implementation, it does +1 to start counting zero bits, however, in aarch64 we may start counting one bits immediately. This saves 1 cycle and 5% of iteration performance. Then it becomes hard to find a supported and sustainable C++ version of it. `__clsll` is not supported by GCC and was supported only since clang 8, `__builtin_clrsb` is not producing optimal codegen for clang. `__rbit` is not supported by GCC and there is no intrinsic to do that, however, in clang we have `__builtin_bitreverse{32,64}`. For now I decided to enable this only for clang, only if they have appropriate builtins. PiperOrigin-RevId: 451168570 Change-Id: I7e9256a60aecdc88ced4e6eb15ebc257281b6664
| Name |
Last commit
|
Last Update |
|---|---|---|
| .. | ||
| internal | Loading commit data... | |
| BUILD.bazel | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| attributes.h | Loading commit data... | |
| bit_cast_test.cc | Loading commit data... | |
| call_once.h | Loading commit data... | |
| call_once_test.cc | Loading commit data... | |
| casts.h | Loading commit data... | |
| config.h | Loading commit data... | |
| config_test.cc | Loading commit data... | |
| const_init.h | Loading commit data... | |
| dynamic_annotations.h | Loading commit data... | |
| exception_safety_testing_test.cc | Loading commit data... | |
| inline_variable_test.cc | Loading commit data... | |
| inline_variable_test_a.cc | Loading commit data... | |
| inline_variable_test_b.cc | Loading commit data... | |
| invoke_test.cc | Loading commit data... | |
| log_severity.cc | Loading commit data... | |
| log_severity.h | Loading commit data... | |
| log_severity_test.cc | Loading commit data... | |
| macros.h | Loading commit data... | |
| optimization.h | Loading commit data... | |
| optimization_test.cc | Loading commit data... | |
| options.h | Loading commit data... | |
| policy_checks.h | Loading commit data... | |
| port.h | Loading commit data... | |
| raw_logging_test.cc | Loading commit data... | |
| spinlock_test_common.cc | Loading commit data... | |
| thread_annotations.h | Loading commit data... | |
| throw_delegate_test.cc | Loading commit data... |