fix: Different MSVC versions may be ABI incompatible, guard with _MSC_VER (#2898) (#4779)

76b88581 · Peter Würtz · GitHub · b9359cea · 76b88581
Commit 76b88581 authored Aug 23, 2023 by Peter Würtz Committed by GitHub Aug 23, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

include/pybind11/detail/internals.h
+3 -0

No files found.
--- a/include/pybind11/detail/internals.h
+++ b/include/pybind11/detail/internals.h
@@ -291,9 +291,12 @@ struct type_info {
 #endif

 /// On Linux/OSX, changes in __GXX_ABI_VERSION__ indicate ABI incompatibility.
+/// On MSVC, changes in _MSC_VER may indicate ABI incompatibility (#2898).
 #ifndef PYBIND11_BUILD_ABI
 #    if defined(__GXX_ABI_VERSION)
 #        define PYBIND11_BUILD_ABI "_cxxabi" PYBIND11_TOSTRING(__GXX_ABI_VERSION)
+#    elif defined(_MSC_VER)
+#        define PYBIND11_BUILD_ABI "_mscver" PYBIND11_TOSTRING(_MSC_VER)
 #    else
 #        define PYBIND11_BUILD_ABI ""
 #    endif