Commit f067deb5 by cyy Committed by GitHub

avoid unnecessary strlen (#3058)

parent 733f8de2
...@@ -377,7 +377,7 @@ template <> struct process_attribute<is_new_style_constructor> : process_attribu ...@@ -377,7 +377,7 @@ template <> struct process_attribute<is_new_style_constructor> : process_attribu
}; };
inline void process_kw_only_arg(const arg &a, function_record *r) { inline void process_kw_only_arg(const arg &a, function_record *r) {
if (!a.name || strlen(a.name) == 0) if (!a.name || a.name[0] == '\0')
pybind11_fail("arg(): cannot specify an unnamed argument after an kw_only() annotation"); pybind11_fail("arg(): cannot specify an unnamed argument after an kw_only() annotation");
++r->nargs_kw_only; ++r->nargs_kw_only;
} }
......
...@@ -470,7 +470,7 @@ protected: ...@@ -470,7 +470,7 @@ protected:
signatures += it->signature; signatures += it->signature;
signatures += "\n"; signatures += "\n";
} }
if (it->doc && strlen(it->doc) > 0 && options::show_user_defined_docstrings()) { if (it->doc && it->doc[0] != '\0' && options::show_user_defined_docstrings()) {
// If we're appending another docstring, and aren't printing function signatures, we // If we're appending another docstring, and aren't printing function signatures, we
// need to append a newline first: // need to append a newline first:
if (!options::show_function_signatures()) { if (!options::show_function_signatures()) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment