Commit f8d4aa47 by Aaron Gokaslan Committed by GitHub

Add clang-tidy readability checks for sus args (#3611)

parent 21911e12
...@@ -46,6 +46,7 @@ readability-simplify-subscript-expr, ...@@ -46,6 +46,7 @@ readability-simplify-subscript-expr,
readability-static-accessed-through-instance, readability-static-accessed-through-instance,
readability-static-definition-in-anonymous-namespace, readability-static-definition-in-anonymous-namespace,
readability-string-compare, readability-string-compare,
readability-suspicious-call-argument,
readability-uniqueptr-delete-release, readability-uniqueptr-delete-release,
-bugprone-exception-escape, -bugprone-exception-escape,
-bugprone-reserved-identifier, -bugprone-reserved-identifier,
......
...@@ -350,7 +350,7 @@ TEST_SUBMODULE(virtual_functions, m) { ...@@ -350,7 +350,7 @@ TEST_SUBMODULE(virtual_functions, m) {
m.def("add3", [](const AdderBase::Data& first, const AdderBase::Data& second, const AdderBase::Data& third, m.def("add3", [](const AdderBase::Data& first, const AdderBase::Data& second, const AdderBase::Data& third,
const AdderBase& adder, const AdderBase::DataVisitor& visitor) { const AdderBase& adder, const AdderBase::DataVisitor& visitor) {
adder(first, second, [&] (const AdderBase::Data& first_plus_second) { adder(first, second, [&] (const AdderBase::Data& first_plus_second) {
adder(first_plus_second, third, visitor); adder(first_plus_second, third, visitor); // NOLINT(readability-suspicious-call-argument)
}); });
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment