1. 03 Jul, 2017 1 commit
    • Override deduced Base class when defining Derived methods · 23bf8945
      When defining method from a member function pointer (e.g. `.def("f",
      &Derived::f)`) we run into a problem if `&Derived::f` is actually
      implemented in some base class `Base` when `Base` isn't
      pybind-registered.
      
      This happens because the class type is deduced from the member function
      pointer, which then becomes a lambda with first argument this deduced
      type.  For a base class implementation, the deduced type is `Base`, not
      `Derived`, and so we generate and registered an overload which takes a
      `Base *` as first argument.  Trying to call this fails if `Base` isn't
      registered (e.g.  because it's an implementation detail class that isn't
      intended to be exposed to Python) because the type caster for an
      unregistered type always fails.
      
      This commit adds a `method_adaptor` function that rebinds a member
      function to a derived type member function and otherwise (i.e. regular
      functions/lambda) leaves the argument as-is.  This is now used for class
      definitions so that they are bound with type being registered rather
      than a potential base type.
      
      A closely related fix in this commit is to similarly update the lambdas
      used for `def_readwrite` (and related) to bind to the class type being
      registered rather than the deduced type so that registering a property
      that resolves to a base class member similarly generates a usable
      function.
      
      Fixes #854, #910.
      
      Co-Authored-By: Dean Moldovan <dean0x7d@gmail.com>
      Jason Rhinelander committed
  2. 02 Jul, 2017 1 commit
    • Fix unsigned error value casting · 259b2faf
      When casting to an unsigned type from a python 2 `int`, we currently
      cast using `(unsigned long long) PyLong_AsUnsignedLong(src.ptr())`.
      If the Python cast fails, it returns (unsigned long) -1, but then we
      cast this to `unsigned long long`, which means we get 4294967295, but
      because that isn't equal to `(unsigned long long) -1`, we don't detect
      the failure.
      
      This commit moves the unsigned casting into a `detail::as_unsigned`
      function which, upon error, casts -1 to the final type, and otherwise
      casts the return value to the final type to avoid the problematic double
      cast when an error occurs.
      
      The error most commonly shows up wherever `long` is 32-bits (e.g. under
      both 32- and 64-bit Windows, and under 32-bit linux) when passing a
      negative value to a bound function taking an `unsigned long`.
      
      Fixes #929.
      
      The added tests also trigger a latent segfault under PyPy: when casting
      to an integer smaller than `long` (e.g. casting to a `uint32_t` on a
      64-bit `long` architecture) we check both for a Python error and also
      that the resulting intermediate value will fit in the final type.  If
      there is no conversion error, but we get a value that would overflow, we
      end up calling `PyErr_ExceptionMatches()` illegally: that call is only
      allowed when there is a current exception.  Under PyPy, this segfaults
      the test suite.  It doesn't appear to segfault under CPython, but the
      documentation suggests that it *could* do so.  The fix is to only check
      for the exception match if we actually got an error.
      Jason Rhinelander committed
  3. 29 Jun, 2017 2 commits
  4. 28 Jun, 2017 1 commit
  5. 27 Jun, 2017 5 commits
  6. 26 Jun, 2017 1 commit
  7. 25 Jun, 2017 1 commit
  8. 24 Jun, 2017 7 commits
  9. 23 Jun, 2017 2 commits
  10. 20 Jun, 2017 1 commit
    • Switch debian docker images to stretch · e067c584
      Debian stretch was just released, so `debian:testing` and
      `debian:stetch` are starting to diverge; this commit keeps the travis-ci
      docker image on stretch for gcc6 and clang3.9.
      
      Debian has also moved gcc 7 from experimental to unstable, so this
      switches the gcc7 build to `sid`.  Once it migrates to `testing` I'll
      switch the gcc 7 build docker image to `testing` and take it out of
      failure-allowed.
      Jason Rhinelander committed
  11. 15 Jun, 2017 2 commits
  12. 14 Jun, 2017 2 commits
    • Make check-style.sh work on stock macOS · d080f833
      ./tools/check-style.sh fails on stock OS X currently; this fixes it:
      
      - use pipes directly rather than exec redirection (macOS's ancient
        version of bash fails with the latter)
      - macOS's ancient bash doesn't support '\e' escapes in `echo -e`;
        replace with \033 instead
      - BSD grep doesn't support GREP_COLORS, but does allow GREP_COLOR.
        Adding both doesn't hurt GNU grep: GREP_COLOR is deprecated, and won't
        be used when GREP_COLORS is set.
      - BSD grep doesn't collapse multiple /'s in the listed filename, so
        failures under `include/` would should up as
        `include//pybind11/whatever.h`.  This removes the / from the include
        directory argument.
      
      Minor other changes:
      - The CRLF detection runs with -l, so GREP_COLORS wasn't doing
        anything; removed it.
      - The trailing whitespace test would trigger on CRLFs, but the CR would
        result in messed up output.  Changed the test to just match trailing
        spaces and tabs, rather than all whitespace.
      Jason Rhinelander committed
    • travis-ci: clang 4.0: install and use ldd-4.0 · 404bcf25
      The clang 4.0/cpp17 build wasn't enabling -flto because the system
      linker didn't like the output generated by clang for some reason.  This
      switches the build to use llvm's lld instead, which lets -flto work
      again (and links considerably faster, too).
      Jason Rhinelander committed
  13. 12 Jun, 2017 2 commits
    • Upgrade pypy to 5.8, use pre-built numpy/scipy wheels · 2cc1916e
      numpy 1.13.0 fails with pypy 5.7.1, so this upgrades to 5.8.0.  I've
      also uploaded pre-built .whl files to imaginary.ca (checked every 4
      hours and rebuilt if needed), and list that as an extra pypi location
      under the pypy pip install to avoid the long travis pypy build times for
      a new release or branch.
      Jason Rhinelander committed
    • Support multiple inheritance from python · e45c2114
      This commit allows multiple inheritance of pybind11 classes from
      Python, e.g.
      
          class MyType(Base1, Base2):
              def __init__(self):
                  Base1.__init__(self)
                  Base2.__init__(self)
      
      where Base1 and Base2 are pybind11-exported classes.
      
      This requires collapsing the various builtin base objects
      (pybind11_object_56, ...) introduced in 2.1 into a single
      pybind11_object of a fixed size; this fixed size object allocates enough
      space to contain either a simple object (one base class & small* holder
      instance), or a pointer to a new allocation that can contain an
      arbitrary number of base classes and holders, with holder size
      unrestricted.
      
      * "small" here means having a sizeof() of at most 2 pointers, which is
      enough to fit unique_ptr (sizeof is 1 ptr) and shared_ptr (sizeof is 2
      ptrs).
      
      To minimize the performance impact, this repurposes
      `internals::registered_types_py` to store a vector of pybind-registered
      base types.  For direct-use pybind types (e.g. the `PyA` for a C++ `A`)
      this is simply storing the same thing as before, but now in a vector;
      for Python-side inherited types, the map lets us avoid having to do a
      base class traversal as long as we've seen the class before.  The
      change to vector is needed for multiple inheritance: Python types
      inheriting from multiple registered bases have one entry per base.
      Jason Rhinelander committed
  14. 10 Jun, 2017 3 commits
  15. 08 Jun, 2017 4 commits
  16. 07 Jun, 2017 2 commits
  17. 06 Jun, 2017 1 commit
    • Explicitly define copy/move constructors for accessor · 91bbe2f2
      `accessor` currently relies on an implicit default copy constructor, but that is deprecated in C++11 when a copy assignment operator is present and can, in some cases, raise deprecation warnings (see #888).  This commit explicitly specifies the default copy constructor and also adds a default move constructor.
      eirrgang committed
  18. 31 May, 2017 1 commit
  19. 30 May, 2017 1 commit
    • std::reference_wrapper: non-generic types; no None · acedd6c7
      This reimplements the std::reference_wrapper<T> caster to be a shell
      around the underlying T caster (rather than assuming T is a generic
      type), which lets it work for things like `std::reference_wrapper<int>`
      or anything else custom type caster with a lvalue cast operator.
      
      This also makes it properly fail when None is provided, just as an
      ordinary lvalue reference argument would similarly fail.
      
      This also adds a static assert to test that T has an appropriate type
      caster.  It triggers for casters like `std::pair`, which have
      return-by-value cast operators.  (In theory this could be supported by
      storing a local temporary for such types, but that's beyond the scope
      of this PR).
      
      This also replaces `automatic` or `take_ownership` return value policies
      with `automatic_reference` as taking ownership of a reference inside a
      reference_wrapper is not valid.
      Jason Rhinelander committed