Fix handling of forward slashes and url encoding in credentials (#1911)

* Add support for forward slashes and url encoding in credentials

* Remove extra newline

* Remove unquote

poetry/repositories/legacy_repository.py

@@ -220,8 +220,8 @@ class LegacyRepository(PyPiRepository):
 
 
         return "{scheme}://{username}:{password}@{netloc}{path}".format(
         return "{scheme}://{username}:{password}@{netloc}{path}".format(
             scheme=parsed.scheme,
             scheme=parsed.scheme,
-            username=quote(self._auth.auth.username),
-            password=quote(self._auth.auth.password),
+            username=quote(self._auth.auth.username, safe=""),
+            password=quote(self._auth.auth.password, safe=""),
             netloc=parsed.netloc,
             netloc=parsed.netloc,
             path=parsed.path,
             path=parsed.path,
         )
         )

tests/repositories/test_legacy_repository.py

@@ -267,7 +267,7 @@ def test_get_package_retrieves_packages_with_no_hashes():
 
 
 
 
 def test_username_password_special_chars():
 def test_username_password_special_chars():
-    auth = Auth("http://foo.bar", "user:", "p@ssword")
+    auth = Auth("http://foo.bar", "user:", "/%2Fp@ssword")
     repo = MockRepository(auth=auth)
     repo = MockRepository(auth=auth)
 
 
-    assert "http://user%3A:p%40ssword@foo.bar" == repo.authenticated_url
+    assert "http://user%3A:%2F%252Fp%40ssword@foo.bar" == repo.authenticated_url