# Pull Request Check List

In order to make GitHub Actions updates less manuals, let's leverage Dependabot for the updates.
Since we mostly pin major versions for the actions, the volume of PRs will be pretty low, so a weekly schedule may be a good fit.

- [ ] Added **tests** for changed code.
- [ ] Updated **documentation** for changed code.

* https://stackoverflow.com/q/73597456/7030591
* https://github.com/python-poetry/poetry/blob/1e1585321e90a771af3da33f5154278fe9ee5ca2/src/poetry/locations.py#L24-L26

# Pull Request Check List

Resolves: #issue-number-here

<!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes.  But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! -->

- [ ] Added **tests** for changed code.
- [x] Updated **documentation** for changed code.

<!-- If you have *any* questions to *any* of the points above, just **submit and ask**!  This checklist is here to *help* you, not to deter you from contributing! -->

The new plan is described in https://github.com/python-poetry/poetry/issues/6377.

With these changes, we see the following behaviors:

```sh
$ python get-poetry.py

Retrieving Poetry metadata

This installer is deprecated, and scheduled for removal from the Poetry repository on or after January 1, 2023.
See https://github.com/python-poetry/poetry/issues/6377 for details.

You should migrate to https://install.python-poetry.org instead, which supports all versions of Poetry, and allows for `self update` of versions 1.1.7 or newer.
Instructions are available at https://python-poetry.org/docs/#installation.

Without an explicit version, this installer will attempt to install the latest version of Poetry.
This installer cannot install Poetry 1.2.0a1 or newer (and installs will be unable to `self update` to 1.2.0a1 or newer).

To continue to use this deprecated installer, you must specify an explicit version with --version <version> or POETRY_VERSION=<version>.
Alternatively, if you wish to force this deprecated installer to use the latest installable release, set GET_POETRY_IGNORE_DEPRECATION=1.

Version 1.2.0 is not supported by this installer! Please specify a version prior to 1.2.0a1 to continue!
```
```sh
$ python get-poetry.py --version 1.2.0

Retrieving Poetry metadata

This installer is deprecated, and scheduled for removal from the Poetry repository on or after January 1, 2023.
See https://github.com/python-poetry/poetry/issues/6377 for details.

You should migrate to https://install.python-poetry.org instead, which supports all versions of Poetry, and allows for `self update` of versions 1.1.7 or newer.
Instructions are available at https://python-poetry.org/docs/#installation.

Without an explicit version, this installer will attempt to install the latest version of Poetry.
This installer cannot install Poetry 1.2.0a1 or newer (and installs will be unable to `self update` to 1.2.0a1 or newer).

To continue to use this deprecated installer, you must specify an explicit version with --version <version> or POETRY_VERSION=<version>.
Alternatively, if you wish to force this deprecated installer to use the latest installable release, set GET_POETRY_IGNORE_DEPRECATION=1.

Version 1.2.0 is not supported by this installer! Please specify a version prior to 1.2.0a1 to continue!
```
```sh
$ python get-poetry.py --version 1.1.15

Retrieving Poetry metadata

This installer is deprecated, and scheduled for removal from the Poetry repository on or after January 1, 2023.
See https://github.com/python-poetry/poetry/issues/6377 for details.

You should migrate to https://install.python-poetry.org instead, which supports all versions of Poetry, and allows for `self update` of versions 1.1.7 or newer.
Instructions are available at https://python-poetry.org/docs/#installation.

[install of 1.1.15]
```
```sh
$ GET_POETRY_IGNORE_DEPRECATION=1 python get-poetry.py

Retrieving Poetry metadata

This installer is deprecated, and scheduled for removal from the Poetry repository on or after January 1, 2023.
See https://github.com/python-poetry/poetry/issues/6377 for details.

You should migrate to https://install.python-poetry.org instead, which supports all versions of Poetry, and allows for `self update` of versions 1.1.7 or newer.
Instructions are available at https://python-poetry.org/docs/#installation.

Version 1.2.0 is available but is not supported by this installer!
Version 1.1.15 will be installed as it is the latest version supported by this installer.

This is not the latest version of Poetry! If you wish to install the latest version, you must move to the new installer as described above!

[install of 1.1.15]
```

Add some recommendations about how to install Poetry into an CI environment.

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>

The example: https://python-poetry.org/docs/plugins/#application-plugins

Creates a `cleo.commands.command` from the factory, which is not compatible with the type `poetry.console.commands.command`. Use the correct type instead.

If a dependency doesn't specify a source type, then a locked package
from any source can satisfy it

The current "Managing Dependencies" documentation contains an error at
[Installing group dependencies](https://python-poetry.org/docs/managing-dependencies/#installing-group-dependencies)

Within the warning concerning the combined use of  `--with` and `--without` the parameters were swapped.

- [ ] Added **tests** for changed code.
- [x] Updated **documentation**

Co-authored-by: Philipp Quenzel <quenzel@dkms-lab.de>
Co-authored-by: finswimmer <finswimmer77@gmail.com>

*- ci: use 3.10 in release workflow
- ci: add 3.11 to the Python matrix

B023:  Functions defined inside a loop must not use variables redefined in the loop, because late-binding closures are a classic gotcha.

Here's some sample code approximating the poetry code:
```python
#!/usr/bin/env python3


def one() -> int:
    return 1


def two() -> int:
    return 2


def three() -> int:
    return 3


factories = [one, two, three]

registered = []
for factory in factories:
    registered.append(lambda: factory())

for registered_factory in registered:
    print(f"result is {registered_factory()}")
```
output is
```
result is 3
result is 3
result is 3
```
which is exactly the gotcha that flake8-bugbear's B023 was trying to warn about.

I've applied one of the workarounds that various parts of the internet recommend, and you can verify for yourself if you're so inclined that doing the same in the toy script gives the expected output.

refactor(provider): remove unused parameter "env" (environment must always be set via contextmanager "use_environment" to avoid inconsistent python_constraint)

refactor(solver): remove unnecessary parameter "provider" (was only used in tests and can cause inconsistencies between a solver and its provider)

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>

Co-authored-by: Bjorn Neergaard <bjorn@neersighted.com>

eg with this dependency
```
pyscf = { git = "https://github.com/pyscf/pyscf", tag = "v2.0.1"}
```
the cloning of submodules fails - because that project has messed up and not committed the file saying what revision they want of the `doc` submodule.

Legacy git client just silently carries on, so I've done the same here.

- regular depth-first search already handles circular dependencies and
  hitting the same package twice
  - the special cases might have saved a teensy amount of work, but the
    simplification is preferable

- pre-release handling here was not consistent with code elsewhere, and
  since "elsewhere" happens first, it wins
  - given a constraint like ">=1.0" the removed code would have allowed
    1.0rc1, but elsewhere in the codebase constraints are taken to mean
    what they say

No functional change or fixes here, just tidier code:
* prefer Path.exists()
* typechecking - NormalizedNames from poetry-core
* clean up some unnecessary duplication
* minor refactor
* gather the pyproject.toml parsing into one block, save a level of indentation
* remove more dead code
* simplify handling of extras at command line
* more abstract types