Commits · 7a1898a04fb3ab83b869e7967ddd7721696490a3 · open / abseil-cpp

20 Dec, 2023 4 commits

AddressIsReadable: improve comments · 7a1898a0

Linux kernel's rt_sigprocmask correctly handles an unaligned user address[1].
The original issue was for qemu-user, which seems long irrelevant.

Tested locally on an AArch64 CPU and qemu-aarch64-static.

The alignment operation actually serves another purpose: when addr resides in
the last 7 bytes of a page (unaligned), check only the current page and not the
next. Update the comment.

[1]:
kernel/signal.c `SYSCALL_DEFINE4(rt_sigprocmask`
arch/arm64/include/asm/uaccess.h:raw_copy_from_user
arch/arm64/lib/copy_template.S  "alignment handled by the hardware"

PiperOrigin-RevId: 592618320
Change-Id: Ifbd05aba42f46e36e710cca940570213036b3ce0

committed Dec 20, 2023

7a1898a0 Browse Files

Unify btree EmptyNode allocation code across compilers. · 299dbc58

We currently have a workaround for MSVC, which has constexpr pointer arithmetic bugs. The bug seems to still exist and the existing code for non-MSVC compilers doesn't build.

This alternative constexpr constructor avoids pointer arithmetic and seems to be working for all, including MSVC.

PiperOrigin-RevId: 592586957
Change-Id: Ic585693c3a7abaab5fbbc0954b8ee924994f8dbf

committed Dec 20, 2023

299dbc58 Browse Files

Create and destroy tables outside of the timer and in batch in Reserve benchmarks. · b559abcb
```
PiperOrigin-RevId: 592483250
Change-Id: I55fa9982c4dbc723b30957cb31da95251e368707
```
Abseil Team committed Dec 20, 2023
b559abcb Browse Files
Add script for Arm build. · 1ae12074
```
PiperOrigin-RevId: 592390284
Change-Id: If5b612a3f8d3144df108deb4ee28c1e9279b858b
```
Richard O'Grady committed Dec 19, 2023
1ae12074 Browse Files

19 Dec, 2023 5 commits

Fix typo: begnning -> beginning · 5afcd807
```
PiperOrigin-RevId: 592337948
Change-Id: I373943b8daf28781e063b302fc916ca5644e8fe1
```
Abseil Team committed Dec 19, 2023
5afcd807 Browse Files
Add a pragma to disable a maybe-uninitialized warning for GCC12+ · 6d17d4bd
```
PiperOrigin-RevId: 592301543
Change-Id: I97e4df805c7313896228430a50a7f991127f3e30
```
Abseil Team committed Dec 19, 2023
6d17d4bd Browse Files
Refactor `EraseMetaOnly` to speed up single group tables. · 46223c86
```
PiperOrigin-RevId: 592272653
Change-Id: I895c5786555227bdc88ab0a4cce8cf5ba65222a1
```
Abseil Team committed Dec 19, 2023
46223c86 Browse Files

Update the CI builds that use the latest compiler versions to · 78c2f648

use Bazel 7.0.0.

CMake is also updated to 3.28.1

PiperOrigin-RevId: 592263272
Change-Id: I4daccdad4bceb483b0400328baebc79591990328

committed Dec 19, 2023

78c2f648 Browse Files

Mutex: Prevent false race in EnableInvariantDebugging. · e54fb4e1

The added test exposes a false TSan race report in
EnableInvariantDebugging/EnableDebugLog related to SynchEvent reuse.

We ignore most of the stuff that happens inside of the Mutex code,
but not for the code inside of EnableInvariantDebugging/EnableDebugLog.
So these can cause occasional false reports on SynchEvent bankruptcy.

Also ignore accesses in EnableInvariantDebugging/EnableDebugLog.

PiperOrigin-RevId: 592226791
Change-Id: I066edb1ef5661ba6cf86a195f91a9d5328b93d10

committed Dec 19, 2023

e54fb4e1 Browse Files

18 Dec, 2023 4 commits

Add the `BM_EraseEmplace` benchmark that constantly adds and removes the same element. · bae26019
```
PiperOrigin-RevId: 591987002
Change-Id: Ic1ed2063aeb95a6e814eefcbed024e1a5a1d8d2f
```
Abseil Team committed Dec 18, 2023
bae26019 Browse Files

Mutex: Fix Condition pointer-to-member cast to respect const qualifier · 8900d7c4

Previously, `absl::Condition` incorrectly used the same (non-`const`)
pointer-to-method type when wrapping both `const` and non-`const` methods.

Unfortunately, this is undefined behavior according to `[expr.reinterpret.cast]`
in the C++ standard:

> The effect of calling a function through a pointer to a function type that is
> not the same as the type used in the definition of the function is undefined.

This fixes the UB.

PiperOrigin-RevId: 591981682
Change-Id: Iaca955346699417232383d3a1800ea9b82ea5761

committed Dec 18, 2023

8900d7c4 Browse Files

Cleanup build file by removing an empty srcs list · d22aa4df
```
PiperOrigin-RevId: 591928115
Change-Id: I55de0886d3ce2d58cc1c94a15ce0f3eefc5eeaaf
```
Derek Mauro committed Dec 18, 2023
d22aa4df Browse Files
Add a pragma to disable a stringop-overflow warning for GCC12+ · 3ccc950c
```
PiperOrigin-RevId: 591894838
Change-Id: Ib3fe72d255f49320e2728c210ba1faabc81e0ef8
```
Abseil Team committed Dec 18, 2023
3ccc950c Browse Files

15 Dec, 2023 2 commits

Remove nullability from Span::{pointer,iterator} · 27478af3

These are in some sense correct (begin()/end() can be null for empty spans), but
don't capture the critical contract that begin() is only null when end() is.
This leads to foreach loops over spans being considered unsafe.

Long-term we may want to express such constraints somehow, but for now giving
these pointers unknown nullability is the best we can do.

PiperOrigin-RevId: 591191038
Change-Id: I1f02e068a445c0ca5996a9212477b64393ef4161

committed Dec 15, 2023

27478af3 Browse Files

Roll back changes to AsciiStrToUpper() and AsciiStrToLower() due to bug report. · a7e3dafd
```
PiperOrigin-RevId: 591161019
Change-Id: Iae2477a24819e20288fbb83b4a343031af71f1bb
```
Abseil Team committed Dec 14, 2023
a7e3dafd Browse Files

14 Dec, 2023 1 commit
- Performance improvement for absl::AsciiStrToUpper() and absl::AsciiStrToLower() · cee0d5b4
```
PiperOrigin-RevId: 591015112
Change-Id: I3e654433f0b0a4ea02ee10e0894e70738e730782
```
  Abseil Team committed Dec 14, 2023
  cee0d5b4 Browse Files
13 Dec, 2023 2 commits

Redirect `GetPageSize()` to C library `getpagesize()` on Hexagon DSP. · dcd5bd5f
```
PiperOrigin-RevId: 590669848
Change-Id: Ibc703b0fbedede86ddaa9682049b7dcc2250fbfb
```
Abseil Team committed Dec 13, 2023
dcd5bd5f Browse Files

Add `ostream<<` and `AbslStringify` to `absl::StatusOr`. · 031d99ab

These methods will only be defined if they're defined for `T`.  Additionally,
we add jitter to the output to discourage people relying on the output format.

PiperOrigin-RevId: 590598988
Change-Id: I4e7173b5f0c66fd3a1cdd3392944e20b8a26641f

committed Dec 13, 2023

031d99ab Browse Files

12 Dec, 2023 2 commits

Unit-tests to verify ABSL raw_hash_set does not double-hash in prod · f16e457b
```
PiperOrigin-RevId: 590337123
Change-Id: Ib98bbb5a5dadbce5e891567038e016f4da2efc0b
```
Abseil Team committed Dec 12, 2023
f16e457b Browse Files

Add `MaskFull` to `Group`. · ad0a6d2f

It is not used at the moment. Usage is planned to be submitted separately.

Useful for faster iterating over all slots in the internal functions.

PiperOrigin-RevId: 590300049
Change-Id: I081f33113268761db868771d29796d94c24e4e7a

committed Dec 12, 2023

ad0a6d2f Browse Files

11 Dec, 2023 3 commits

`absl/utility`: Delete tests for C++11-compatible `integer_sequence` and friends · 011aeede

These used to be independent implementations. Now that they are aliases, maintaining tests doesn't make sense anymore.

PiperOrigin-RevId: 589947915
Change-Id: I555496e3467d56a75468b180383482eee2e8f198

committed Dec 11, 2023

011aeede Browse Files

`absl/utility`: Delete C++11-compatible `integer_sequence` and friends · 8843e8e2

Abseil does not support C++11 anymore: https://github.com/google/oss-policies-info/blob/b842c39db88e6569dfe2cf98be434b03507cb503/foundational-cxx-support-matrix.md

NOTE: This is a breaking change because `std::integer_sequence<T>` requires `std::is_integral_v<T>`, but `absl::integer_sequence<T>` does not.

Unit tests will be deleted in a follow-up.

PiperOrigin-RevId: 589908215
Change-Id: I57a81e4451840304d5fba60bef286e81e024af9c

committed Dec 11, 2023

8843e8e2 Browse Files

Add nullability annotations · 55621d1a
```
PiperOrigin-RevId: 589842893
Change-Id: I9657761d1f71c665582406f278c6605f6d382f6d
```
Dmitri Gribenko committed Dec 11, 2023
55621d1a Browse Files

07 Dec, 2023 3 commits

Enable ABSL_HAVE_POSIX_WRITE for Hexagon DSP build. · fad94622
```
PiperOrigin-RevId: 588893303
Change-Id: I3f9278f2f7f0bc4b8903a87cb4a740daf7349755
```
Abseil Team committed Dec 07, 2023
fad94622 Browse Files

Small table growth optimization. · 0ef87fa0

Details:
- In case the table entirely fits into a single group size (`capacity <= Group::kWidth`), the order of elements is not important.
- For growing upto Group::kWidth we rotate control bytes and slots deterministically (using memcpy).
- We also avoid second find_first_non_full right after resize for small growing.
PiperOrigin-RevId: 588825966
Change-Id: I09bd7fd489e3868dcf56c36b436805d08dae7ab5

committed Dec 07, 2023

0ef87fa0 Browse Files

Elide calls to MakeCheckOpString when ABSL_MIN_LOG_LEVEL makes them unnecessary · 026e9fe0

Reduces final binary size by avoiding stream I/O and all its associated
overhead.

PiperOrigin-RevId: 588789394
Change-Id: Ib8653db77aee0dae45e44f4ac72fe7dd87aa2eba

committed Dec 07, 2023

026e9fe0 Browse Files

06 Dec, 2023 5 commits

Fixing a comment to be correct with the current code. · 3abf3298
```
PiperOrigin-RevId: 588530709
Change-Id: Iee28c7693a4802f11e13728e1c28febee8c8576f
```
Abseil Team committed Dec 06, 2023
3abf3298 Browse Files

absl qualify HasAbslStringify in log_message.h. · d84f20a9

This works around a Clang bug, https://github.com/llvm/llvm-project/issues/25168

PiperOrigin-RevId: 588491254
Change-Id: Ia59afae4df45474d6025a2ab1ca487b381c9ee66

committed Dec 06, 2023

d84f20a9 Browse Files

Remove a global destructor in vlog_config.cc · a436472b

Chromium requires no global destructors.

PiperOrigin-RevId: 588466793
Change-Id: Icd255d9fb37667b4f5ce4b2552b70fa53cbf6ecf

committed Dec 06, 2023

a436472b Browse Files

Avoid leaking an unprefixed VLOG_IS_ON transitively though absl_log.h · 8588e7d1

absl_log.h is supposed to be a mirror of log.h that only uses ABSL_
prefixed macros. This change adds ABSL_VLOG_IS_ON to absl_vlog_is_on.h
and uses it in the implementation of VLOG. VLOG_IS_ON is then only
exported though vlog_is_on.h.

PiperOrigin-RevId: 588435577
Change-Id: Ifa9193afa0b782194b64447f4fedfaf24b72c95a

committed Dec 06, 2023

8588e7d1 Browse Files

Move vlog_config to the internal directory and change the namespace of VLogSite · 9b83dc9f
```
PiperOrigin-RevId: 588403935
Change-Id: I6a3af3c044b887ec65b19390d316cfb3ccdcc853
```
Derek Mauro committed Dec 06, 2023
9b83dc9f Browse Files

05 Dec, 2023 5 commits

Adds support for wchar_t/wchar_t*/std::wstring{_view} arguments to StrFormat(). · 5dc2cc1a
```
This converts to UTF-8 regardless of locale.

PiperOrigin-RevId: 588186076
Change-Id: I2c9598279b413d460e13ad65da2ba421c0b40b83
```
Abseil Team committed Dec 05, 2023
5dc2cc1a Browse Files

Roll-forward: Honor ABSL_MIN_LOG_LEVEL in CHECK_XX, CHECK_STRXX, CHECK_OK, and… · 3e6ecec7

Roll-forward: Honor ABSL_MIN_LOG_LEVEL in CHECK_XX, CHECK_STRXX, CHECK_OK, and the QCHECK flavors of these.

In particular, if ABSL_MIN_LOG_LEVEL exceeds kFatal, these should, upon failure, terminate the program without logging anything. The lack of logging should be visible to the optimizer so that it can strip string literals and stringified variable names from the object file.

Making some edge cases work under Clang required rewriting NormalizeLogSeverity to help make constraints on its return value more obvious to the optimizer.

PiperOrigin-RevId: 588181755
Change-Id: I95db3bae39f8dadb52a307ca3b80775db23de766

committed Dec 05, 2023

3e6ecec7 Browse Files

Fix codegen trunks in `absl/hash/hash_benchmark.cc`. · 71d553b1
```
PiperOrigin-RevId: 588121665
Change-Id: Id057772e426aefe2fe7b2f1e94fd405b97167fed
```
Shahriar Rouf committed Dec 05, 2023
71d553b1 Browse Files

Make `absl::{partial,weak,strong}_ordering` aliases for the `std::` ordering · f845e60a

types when they are available.

This makes them interchangeable in contexts known to be compiled as C++20.
This also makes `absl::` ordering types compatible with `<=>`, allowing to
unconditionally use `absl::` spelling for types but conditionally use `<=>`
when available.

PiperOrigin-RevId: 588085408
Change-Id: I1aa5247f0e31acbb838ee76829b7a13c74b0a94f

committed Dec 05, 2023

f845e60a Browse Files

Add VLOG and friends · 7b6c17e3

These are methods for configurable verbose logging

PiperOrigin-RevId: 588059727
Change-Id: Ib3703edd2493050a5da8b30e88b21adc643b1f7f

committed Dec 05, 2023

7b6c17e3 Browse Files

04 Dec, 2023 1 commit

Remove `absl::weak_equality` and `absl::strong_equality`. · a39d71a8

The corresponding `std` types were removed before C++20 was finalized:
https://wg21.link/P1959R0.

They are unused. The language mechanisms and recommendations changed since they
were originally proposed. In particular:

* An explicitly defaulted `operator==` is defined in terms of memberwise
  `operator==` rather than sibling `operator<=>`.

* An `operator!=` can be implicitly added to an overload set in terms of
  `operator==` rather than `operator<=>`.

* A class which has equality but not ordering defined should provide
  `operator==` rather than `operator<=>`.

PiperOrigin-RevId: 587834267
Change-Id: I2c2513c13f3485b9edc6a345dca4a577d8e65167

committed Dec 04, 2023

a39d71a8 Browse Files

28 Nov, 2023 2 commits
- Avoid #pragma intrinsic(_mm_prefetch) on Arm64EC (and other platforms · 8028a87c
```
without SSE)

Closes #1575

PiperOrigin-RevId: 586009018
Change-Id: Icc34c1201268303dde96bfbb067506b861754b3a
```
  Derek Mauro committed Nov 28, 2023
  8028a87c Browse Files
- `btree_map`: avoid a copy in `map_params::key`. · 0c09fd0f
```
PiperOrigin-RevId: 585892739
Change-Id: I30490dac5826bff2a33d9872f71154d360f9cc0d
```
  Abseil Team committed Nov 28, 2023
  0c09fd0f Browse Files
27 Nov, 2023 1 commit
- Update documentation to reflect best practices (prefer brace initialization) · ac7ec8ea
```
PiperOrigin-RevId: 585691325
Change-Id: Icd18dc0294dfd1e22f9878b628d5e5898fcc8185
```
  Abseil Team committed Nov 27, 2023
  ac7ec8ea Browse Files