1. 20 Feb, 2021 1 commit
  2. 17 Feb, 2021 1 commit
  3. 14 Feb, 2021 1 commit
    • Add pybind11::bytearray (#2799) · 417067ee
      * Add initial implementation
      
      * Add few more methods
      
      * Add tests
      
      * Fix a typo
      
      * Use std::string constructor which takes size
      
      * Fix implicit sign conversion error
      
      * Add size method and test
      
      * Remove implicit conversion
      
      * Fix bytearray constructors and operator std::string()
      
      * Make implicit bytearray constructor explicit
      
      * Rerun tests
      
      * Add null check
      
      * Rerun tests
      
      * Rerun tests - 2
      
      * Remove NULL check
      Vikram Pal committed
  4. 12 Feb, 2021 1 commit
  5. 09 Feb, 2021 1 commit
  6. 08 Feb, 2021 3 commits
  7. 01 Feb, 2021 1 commit
  8. 31 Jan, 2021 2 commits
  9. 30 Jan, 2021 2 commits
    • Adding holder_caster `typename SFINAE = void` hooks to help work around the… · 932769b0
      Adding holder_caster `typename SFINAE = void` hooks to help work around the current lack of smart-pointer interoperability (#2833)
      
      * Adding move_only_holder_caster `typename SFINAE = void` to enable external specializations.
      
      * Adding SFINAE hook also to copyable_holder_caster, for uniformity, with comment to explain the purpose.
      Ralf W. Grosse-Kunstleve committed
    • When determining if a shared_ptr already exists, use a test on the we… (#2819) · 23c3edcf
      * When determining if a shared_ptr already exists, use a test on the weak_ptr instead of a try/catch block.
      
      * When determining if a shared_ptr already exists, use a test on the weak_ptr instead of a try/catch block.
      
      * weak_from_this is only available in C++17 and later
      
      * Switch to use feature flag instead of C++ version flag.
      
      * Add Microsoft-specific check.
      
      * Avoid undefined preprocessor macro warning treated as error.
      
      * Simplify shared_from_this in init_holder
      
      * Include <version> in detail/common.h (~stolen~ borrowed from @bstaletic's #2816)
      
      * Move class_::get_shared_from_this to detail::try_get_shared_from_this
      
      * Simplify try_get_shared_from_this by using weak_ptr::lock()
      
      Co-authored-by: Yannick Jadoul <yannick.jadoul@belgacom.net>
      Edward Lockhart committed
  10. 29 Jan, 2021 1 commit
  11. 28 Jan, 2021 1 commit
  12. 27 Jan, 2021 6 commits
  13. 25 Jan, 2021 3 commits
  14. 24 Jan, 2021 1 commit
    • Force the builtin module key to be the correct type. (#2814) · 9ea39dc3
      * Force the builtin module key to be the correct type.
      
      Previously it was always going to be a std::string which converted into
      unicode. Python 2 appears to want module keys to be normal str types, so
      this was breaking code that expected plain string types in the
      builtins.keys() data structure
      
      * Add a simple unit test to ensure all built-in keys are str
      
      * Update the unit test so it will also run on pypy
      
      * Run pre-commit.
      
      Co-authored-by: Jesse Clemens <jesse.clemens@sony.com>
      crimsoncor committed
  15. 21 Jan, 2021 1 commit
  16. 20 Jan, 2021 3 commits
  17. 19 Jan, 2021 4 commits
  18. 18 Jan, 2021 1 commit
    • fix: Intel ICC C++17 compatibility (#2729) · 48534089
      * CI: Intel icc/icpc via oneAPI
      
      Add testing for Intel icc/icpc via the oneAPI images.
      Intel oneAPI is in a late beta stage, currently shipping
      oneAPI beta09 with ICC 20.2.
      
      CI: Skip Interpreter Tests for Intel
      
      Cannot find how to add this, neiter the package `libc6-dev` nor
      `intel-oneapi-mkl-devel` help when installed to solve this:
      ```
      -- Looking for C++ include pthread.h
      -- Looking for C++ include pthread.h - not found
      CMake Error at /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
        Could NOT find Threads (missing: Threads_FOUND)
      Call Stack (most recent call first):
        /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
        /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindThreads.cmake:234 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
        tests/test_embed/CMakeLists.txt:17 (find_package)
      ```
      
      CI: libc6-dev from GCC for ICC
      
      CI: Run bare metal for oneAPI
      
      CI: Ubuntu 18.04 for oneAPI
      
      CI: Intel +Catch -Eigen
      
      CI: CMake from Apt (ICC tests)
      
      CI: Replace Intel Py with GCC Py
      
      CI: Intel w/o GCC's Eigen
      
      CI: ICC with verbose make
      
      [Debug] Find core dump
      
      tests: use arg{} instead of arg() for Intel
      
      tests: adding a few more missing {}
      
      fix: sync with @tobiasleibner's branch
      
      fix: try ubuntu 20-04
      
      fix: drop exit 1
      
      docs: Apply suggestions from code review
      
      Co-authored-by: Tobias Leibner <tobias.leibner@googlemail.com>
      
      Workaround for ICC enable_if issues
      
      Another workaround for ICC's enable_if issues
      
      fix error in previous commit
      
      Disable one test for the Intel compiler in C++17 mode
      
      Add back one instance of py::arg().noconvert()
      
      Add NOLINT to fix clang-tidy check
      
      Work around for ICC internal error in PYBIND11_EXPAND_SIDE_EFFECTS in C++17 mode
      
      CI: Intel ICC with C++17
      
      docs: pybind11/numpy.h does not require numpy at build time. (#2720)
      
      This is nice enough to be mentioned explicitly in the docs.
      
      docs: Update warning about Python 3.9.0 UB, now that 3.9.1 has been released (#2719)
      
      Adjusting `type_caster<std::reference_wrapper<T>>` to support const/non-const propagation in `cast_op`. (#2705)
      
      * Allow type_caster of std::reference_wrapper<T> to be the same as a native reference.
      
      Before, both std::reference_wrapper<T> and std::reference_wrapper<const T> would
      invoke cast_op<type>. This doesn't allow the type_caster<> specialization for T
      to distinguish reference_wrapper types from value types.
      
      After, the type_caster<> specialization invokes cast_op<type&>, which allows
      reference_wrapper to behave in the same way as a native reference type.
      
      * Add tests/examples for std::reference_wrapper<const T>
      
      * Add tests which use mutable/immutable variants
      
      This test is a chimera; it blends the pybind11 casters with a custom
      pytype implementation that supports immutable and mutable calls.
      
      In order to detect the immutable/mutable state, the cast_op needs
      to propagate it, even through e.g. std::reference<const T>
      
      Note: This is still a work in progress; some things are crashing,
      which likely means that I have a refcounting bug or something else
      missing.
      
      * Add/finish tests that distinguish const& from &
      
      Fixes the bugs in my custom python type implementation,
      demonstrate test that requires const& and reference_wrapper<const T>
      being treated differently from Non-const.
      
      * Add passing a const to non-const method.
      
      * Demonstrate non-const conversion of reference_wrapper in tests.
      
      Apply formatting presubmit check.
      
      * Fix build errors from presubmit checks.
      
      * Try and fix a few more CI errors
      
      * More CI fixes.
      
      * More CI fixups.
      
      * Try and get PyPy to work.
      
      * Additional minor fixups. Getting close to CI green.
      
      * More ci fixes?
      
      * fix clang-tidy warnings from presubmit
      
      * fix more clang-tidy warnings
      
      * minor comment and consistency cleanups
      
      * PyDECREF -> Py_DECREF
      
      * copy/move constructors
      
      * Resolve codereview comments
      
      * more review comment fixes
      
      * review comments: remove spurious &
      
      * Make the test fail even when the static_assert is commented out.
      
      This expands the test_freezable_type_caster a bit by:
      1/ adding accessors .is_immutable and .addr to compare identity
      from python.
      2/ Changing the default cast_op of the type_caster<> specialization
      to return a non-const value. In normal codepaths this is a reasonable
      default.
      3/ adding roundtrip variants to exercise the by reference, by pointer
      and by reference_wrapper in all call paths.  In conjunction with 2/, this
      demonstrates the failure case of the existing std::reference_wrpper conversion,
      which now loses const in a similar way that happens when using the default cast_op_type<>.
      
      * apply presubmit formatting
      
      * Revert inclusion of test_freezable_type_caster
      
      There's some concern that this test is a bit unwieldly because of the use
      of the raw <Python.h> functions. Removing for now.
      
      * Add a test that validates const references propagation.
      
      This test verifies that cast_op may be used to correctly detect
      const reference types when used with std::reference_wrapper.
      
      * mend
      
      * Review comments based changes.
      
      1. std::add_lvalue_reference<type> -> type&
      2. Simplify the test a little more; we're never returning the ConstRefCaster
      type so the class_ definition can be removed.
      
      * formatted files again.
      
      * Move const_ref_caster test to builtin_casters
      
      * Review comments: use cast_op and adjust some comments.
      
      * Simplify ConstRefCasted test
      
      I like this version better as it moves the assertion that matters
      back into python.
      
      ci: drop pypy2 linux, PGI 20.7, add Python 10 dev (#2724)
      
      * ci: drop pypy2 linux, add Python 10 dev
      
      * ci: fix mistake
      
      * ci: commented-out PGI 20.11, drop 20.7
      
      fix: regression with installed pybind11 overriding local one (#2716)
      
      * fix: regression with installed pybind11 overriding discovered one
      
      Closes #2709
      
      * docs: wording incorrect
      
      style: remove redundant instance->owned = true (#2723)
      
      which was just before set to True in instance->allocate_layout()
      
      fix: also throw in the move-constructor added by the PYBIND11_OBJECT macro, after the argument has been moved-out (if necessary) (#2701)
      
      Make args_are_all_* ICC workarounds unconditional
      
      Disable test_aligned on Intel ICC
      
      Fix test_aligned on Intel ICC
      
      Skip test_python_alreadyset_in_destructor on Intel ICC
      
      Fix test_aligned again
      
      ICC CI: Downgrade pytest
      
      pytest 6 does not capture the `discard_as_unraisable` stderr and
      just writes a warning with its content instead.
      
      * refactor: simpler Intel workaround, suggested by @laramiel
      
      * fix: try version with impl to see if it is easier to compile
      
      * docs: update README for ICC
      
      Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
      Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
      Michael Kuron committed
  19. 17 Jan, 2021 2 commits
    • fix: only allow integer type_caster to call __int__ method when conversion is… · 8449a808
      fix: only allow integer type_caster to call __int__ method when conversion is allowed; always call __index__ (#2698)
      
      * Only allow integer type_caster to call __int__ or __index__ method when conversion is allowed
      
      * Remove tests for __index__ as this seems to only be used to convert to int in 3.8+
      
      * Take both `int` and `long` types into account for Python 2
      
      * Add test_numpy_int_convert to assert tests currently fail, even though np.intc has an __index__ method
      
      * Also consider __index__ as noconvert to a C++ integer
      
      * New-style classes for Python 2.7; sigh
      
      * Add some tests on types with custom __index__ method
      
      * Ignore some tests in Python <3.8
      
      * Update comment about conversion from np.float32 to C++ int
      
      * Workaround difference between CPython and PyPy's different PyIndex_Check (unnoticed because we currently don't have PyPy >= 3.8)
      
      * Avoid ICC segfault with py::arg()
      Yannick Jadoul committed
    • docs: update build description slightly (#2794) · 0df11d85
      * docs: update build description slightly
      
      * docs: missing ticks
      Henry Schreiner committed
  20. 15 Jan, 2021 2 commits
    • ci: Intel icc/icpc via oneAPI (#2573) · 0b3df7f9
      * CI: Intel icc/icpc via oneAPI
      
      Add testing for Intel icc/icpc via the oneAPI images.
      Intel oneAPI is in a late beta stage, currently shipping
      oneAPI beta09 with ICC 20.2.
      
      * CI: Skip Interpreter Tests for Intel
      
      Cannot find how to add this, neiter the package `libc6-dev` nor
      `intel-oneapi-mkl-devel` help when installed to solve this:
      ```
      -- Looking for C++ include pthread.h
      -- Looking for C++ include pthread.h - not found
      CMake Error at /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
        Could NOT find Threads (missing: Threads_FOUND)
      Call Stack (most recent call first):
        /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
        /__t/cmake/3.18.4/x64/cmake-3.18.4-Linux-x86_64/share/cmake-3.18/Modules/FindThreads.cmake:234 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
        tests/test_embed/CMakeLists.txt:17 (find_package)
      ```
      
      * CI: libc6-dev from GCC for ICC
      
      * CI: Run bare metal for oneAPI
      
      * CI: Ubuntu 18.04 for oneAPI
      
      * CI: Intel +Catch -Eigen
      
      * CI: CMake from Apt (ICC tests)
      
      * CI: Replace Intel Py with GCC Py
      
      * CI: Intel w/o GCC's Eigen
      
      * CI: ICC with verbose make
      
      * [Debug] Find core dump
      
      * tests: use arg{} instead of arg() for Intel
      
      * tests: adding a few more missing {}
      
      * fix: sync with @tobiasleibner's branch
      
      * fix: try ubuntu 20-04
      
      * fix: drop exit 1
      
      * style: clang tidy fix
      
      * style: fix missing NOLINT
      
      * ICC: Update Compiler Name
      
      Changed upstream with the last oneAPI release.
      
      * ICC CI: Downgrade pytest
      
      pytest 6 does not capture the `discard_as_unraisable` stderr and
      just writes a warning with its content instead.
      
      * Use new test pinning requirements.txt
      
      * tests: add notes about intel, cleanup
      
      Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
      Axel Huebl committed
    • Add a Valgrind build on debug Python 3.9 (#2746) · 0f8d5f2e
      * Adding a valgrind build on debug Python 3.9
      
      Co-authored-by: Boris Staletic <boris.staletic@gmail.com>
      
      * Add Valgrind suppression files
      
      - Introduce suppression file, populate it with a first suppression taken from CPython, and fix one leak in the tests
      - Suppress leak in NumPy
      - More clean tests!
      - Tests with names a-e passing (except for test_buffer)
      - Suppress multiprocessing errors
      - Merge multiprocessing suppressions into other suppression files
      - Numpy seems to be spelled with a big P
      - Append single entry from valgrind-misc.supp to valgrind-python.supp, and make clear valgrind-python.supp is only CPython
      
      Co-authored-by: Boris Staletic <boris.staletic@gmail.com>
      
      * Enable test_virtual_functions with a workaround
      
      * Add a memcheck cmake target
      
      - Add a memcheck cmake target
      - Reformat cmake
      - Appease the formatting overlords - they are angry
      - Format CMake valgrind target decently
      
      * Update CI config to new action versions
      
      * fix: separate memcheck from pytest
      
      * ci: cleanup
      
      * Merge Valgrind and other deadsnakes builds
      
      Co-authored-by: Boris Staletic <boris.staletic@gmail.com>
      Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
      Yannick Jadoul committed
  21. 14 Jan, 2021 2 commits
    • fix: STATIC and SHARED flags not being detected (#2796) · 76a16007
      * Fix STATIC and SHARED flags not being detected
      
      * fix: use classic naming for all lib types
      
      Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
      heyer2 committed
    • Plug leaking function_records in cpp_function initialization in case of… · 08551463
      Plug leaking function_records in cpp_function initialization in case of exceptions (found by Valgrind in #2746) (#2756)
      
      * Plug leaking function_record objects when exceptions are thrown
      
      * Plug leak of strdup'ed strings in function_record
      
      * Some extra comments about the function_record ownership dance
      
      * Clean up the function_record better, in case of exceptions
      
      * Demonstrate some extra function_record leaks
      
      * Change  DeleteStrings template argument to free_strings runtime argument in destruct(function_record *)
      
      * Zero-state unique_function_record deleter object
      
      * Clarify rvalue reference to unique_ptr parameter in initialize_generic
      
      * Use push_back with const char * instead of emplace_back
      Yannick Jadoul committed