Commit 90c34887 by Randy Döring Committed by Bjorn Neergaard

refactor(provider): remove unused parameter "env" (environment must always be…

refactor(provider): remove unused parameter "env" (environment must always be set via contextmanager "use_environment" to avoid inconsistent python_constraint)
parent 26b5062c
...@@ -125,13 +125,13 @@ class Provider: ...@@ -125,13 +125,13 @@ class Provider:
package: Package, package: Package,
pool: Pool, pool: Pool,
io: IO, io: IO,
env: Env | None = None, *,
installed: list[Package] | None = None, installed: list[Package] | None = None,
) -> None: ) -> None:
self._package = package self._package = package
self._pool = pool self._pool = pool
self._io = io self._io = io
self._env = env self._env: Env | None = None
self._python_constraint = package.python_constraint self._python_constraint = package.python_constraint
self._is_debugging: bool = self._io.is_debug() or self._io.is_very_verbose() self._is_debugging: bool = self._io.is_debug() or self._io.is_very_verbose()
self._in_progress = False self._in_progress = False
...@@ -168,7 +168,6 @@ class Provider: ...@@ -168,7 +168,6 @@ class Provider:
@contextmanager @contextmanager
def use_environment(self, env: Env) -> Iterator[Provider]: def use_environment(self, env: Env) -> Iterator[Provider]:
original_env = self._env
original_python_constraint = self._python_constraint original_python_constraint = self._python_constraint
self._env = env self._env = env
...@@ -176,7 +175,7 @@ class Provider: ...@@ -176,7 +175,7 @@ class Provider:
yield self yield self
self._env = original_env self._env = None
self._python_constraint = original_python_constraint self._python_constraint = original_python_constraint
@staticmethod @staticmethod
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment